From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Francisco Iglesias" <francisco.iglesias@amd.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH v2 4/5] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name
Date: Thu, 16 Nov 2023 13:25:26 +0000 [thread overview]
Message-ID: <ZVYYRu9QzzP-xrw-@redhat.com> (raw)
In-Reply-To: <20231116131454.541434-5-thuth@redhat.com>
On Thu, Nov 16, 2023 at 02:14:53PM +0100, Thomas Huth wrote:
> Type names should not contain special characters like ":" (so that
> they are easier to use with QAPI and other parts). We are going to
> forbid such names in an upcoming patch. Thus let's replace the ":"
> here with a "-".
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/unit/test-io-task.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-11-16 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 13:14 [PATCH v2 0/5] Limit type names to alphanumerical and some few special characters Thomas Huth
2023-11-16 13:14 ` [PATCH v2 1/5] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl" Thomas Huth
2023-11-16 13:40 ` Peter Maydell
2023-11-16 13:14 ` [PATCH v2 2/5] hw: Replace anti-social QOM type names (again) Thomas Huth
2023-11-16 13:14 ` [PATCH v2 3/5] memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name Thomas Huth
2023-11-16 13:24 ` David Hildenbrand
2023-11-16 15:45 ` Philippe Mathieu-Daudé
2023-11-16 13:14 ` [PATCH v2 4/5] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name Thomas Huth
2023-11-16 13:25 ` Daniel P. Berrangé [this message]
2023-11-16 15:45 ` Philippe Mathieu-Daudé
2023-11-16 13:14 ` [PATCH v2 5/5] qom/object: Limit type names to alphanumerical and some few special characters Thomas Huth
2023-11-16 13:24 ` Daniel P. Berrangé
2023-11-16 17:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVYYRu9QzzP-xrw-@redhat.com \
--to=berrange@redhat.com \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=francisco.iglesias@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.