From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D60BBC47071 for ; Thu, 16 Nov 2023 17:56:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EB9380046; Thu, 16 Nov 2023 12:56:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39B938003F; Thu, 16 Nov 2023 12:56:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28A6380046; Thu, 16 Nov 2023 12:56:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 187FF8003F for ; Thu, 16 Nov 2023 12:56:17 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D6B5C407A3 for ; Thu, 16 Nov 2023 17:56:16 +0000 (UTC) X-FDA: 81464571552.04.D37245C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 1DE5020012 for ; Thu, 16 Nov 2023 17:56:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700157375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dOlLtlNobE/XGexvocstbFV/qX68zF8wAtj9+JrtSn8=; b=joyKpH+ntAenYRT+LCgHUEcC0dxypepHCuO5Hdj10Biz6tx005kLRuG8PlrdbRIgCTLlzP zZSeqenb9VUbmdXB9T41asIltbap53kurCLl1FC7o0DJpq+DZw4aCnq+TeHLvk5KPcGWII AVbASN+4NIjJKpfLhGL1nWkwKGyC8lU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700157375; a=rsa-sha256; cv=none; b=ZcgCs3PLHUWbKu0NGxTiUuYDJu4fNfiRwD8ZK/NxcktsqWZzg48TZi1TcVbAewSZyajA2x H9kZLqHc1usuC8ktPTurgZvpInKnNaWyXBjlL4mlrXeq5leWNuzQP6fjlGgqRf0esJGbOQ 7twN4IDiB9jrudjFPernJXiHVv0VcAM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 3606AB81C8B; Thu, 16 Nov 2023 17:56:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1216C433C7; Thu, 16 Nov 2023 17:56:11 +0000 (UTC) Date: Thu, 16 Nov 2023 17:56:09 +0000 From: Catalin Marinas To: jim.cromie@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dmitry Vyukov Subject: Re: [PATCH 0/3] kmemleak report format changes Message-ID: References: <20230425222446.170486-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 1DE5020012 X-Rspam-User: X-Stat-Signature: an68k6o3aqjgzips5hex6endbgiyw3di X-Rspamd-Server: rspam01 X-HE-Tag: 1700157374-371970 X-HE-Meta: U2FsdGVkX1905Z0PDmMyS/RYXKgvipa080v3UOt0UvHF5S1P6IPFEIIbgnYDMrkmi9wSxUdnW7lzVJpa1u0lrJoV/IImhwu/CNZMEcVz7Nf+k7/TWshjWO9sh5ZkhC5m0SwLdJaUiBi5+gX885zgzaQV4wJ5Ru5wHqLZ6mYTyidEzeADVtEAw8K9GrCl8ksZqtAmgodDhq3HKcOzQAtYsnHkD8XNTVPRwtzliMiBSRQT2GYfyAR4n8n28OcSnr/6fjSl7fNoInaK5Nlk9YnzqRmPvthYtcgTyBsSD680ENLt8OtmjoWQTklYDmf1sVeWJ9IxObf/B1xDHlYCpZAMJfnHLBEFzvSjgpUale+qyipZV+zjekhWIv/6XN02lLp48Cl31ubdgxb94MCLFnP5NMoY1wc7qHQAslN8itU5gqBRXVuOYXjd+bJrJlL9DuGICXqSmAlfwOyqpwdnmdSZnSU/891m/+YCxUqbcN+363XgjvdVxsUaJSaefTWieKYp3m76kUR+AOzJDUJkFX7DuijskUKb3BrD4wxFlIamsRkb1n3ewd0TTuGxUtt9lHwgYW2QwhlOAzcTbSmNaLPr2s6ne8xV/+d6SQ9Rx75XcP0hoCi+vrp5FQbfnEhd1ciu0qexd845QLQ1UrMs90JfwtH8dC1cG/rbXQWts9xBJWGzWVHoMGQ/XR5GMkTRax95fwcTD/GyunJleujdAK4j8z+AoWgrbLJb/+0sA/knTqH4BgeHstRFR9AhvCbM1eCQ7tBmoxHerHCMoV6cYAMTUSu2u3eng3n2ONJGio65tstqDct/e5SHlu9VsRnhiaN7N2MrmAVuIrdUzddy5cGMvsWCtS7YsViUc/1lyuX1ZUhOG3uPvjO82/FEildz7ovl8K7ryj/BcYOh/LYht4LZ7TLhcZE1S/PyFz3VKVkRgWOQWDtCm+stGsktOJiZuKFwOqEiOiCOUz3clK18L7M +BHIuZk+ CFpZy+wsaYVgBcv7FvAlcNlUMiuC7QXrn5vXNCwFiQSJ7W85Vh+tUEZzXfBs72XryYhcUnJcpu0gsOSwq9EGe0omumt8vSeLcDdJbU6JHl4FYMiceX0MUGEqD8AuPWH8ypeeYB3AbwRxd+rwgWPiAyrl9DcnlKTPmcqXlMNk5b2wygBFVDU9QyRuUdXu+exd2uoJU3dheaMOjul+XA3FkHw/t/cHR3AAYCfyyIA//ua3kl9YtCpKje937TZqDD8WODP8LLekdAlZ/UH7/7yjV9nrBJcYOAYWDMozYXjPkBdkYpQWKZnbTRC81XOB3HtaPNzWz9ZcQvOghaV4RxJRVizP9PZRgVFdL/OKJHBiLV7i1/BqljXL+CN+XghQt+zZFGXtk09RqFDuFplbDEoxuyP3sXoMJq7AJ/Xm0tMvqPZ+GFWXYnfV3rfVk7LbuWPb+jsXolG7vGqTIoOI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 10, 2023 at 05:19:38PM -0700, jim.cromie@gmail.com wrote: > On Fri, Apr 28, 2023 at 11:25 AM Catalin Marinas > wrote: > > On Tue, Apr 25, 2023 at 04:24:43PM -0600, Jim Cromie wrote: > > > If format changes are not /sys/** ABI violating, heres 3 minor ones: > > > > > > 1st strips "age " from output. This makes the output > > > idempotent; unchanging until a new leak is reported. > > > > > > 2nd adds the backtrace.checksum to the "backtrace:" line. This lets a > > > user see repeats without actually reading the whole backtrace. So now > > > the backtrace line looks like this: > > > > > > backtrace (ck 603070071): # also see below > > > > > > Q: should ck be spelled crc ? it feels more communicative. > > > > These all would make sense (and 'crc' sounds better) if they were done > > from the start. I know there are test scripts out there parsing the > > kmemleak sysfs file. I can't tell whether these changes would break > > them. > > > > Cc'ing Dmitry, I think syzbot was regularly checking kmemleak (not sure > > it still does). [...] > QED: there are no kmemleak parsers in public github repos that would > break with these changes Thanks for digging into this, I completely forgot about this series. Would you mind rebasing to the latest kernel and reposting? Thanks. -- Catalin