From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Valek - 2N <jiriv@axis.com>
Cc: Rob Herring <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH v5 3/3] Input: cap11xx - remove unnecessary IRQ parsing
Date: Fri, 17 Nov 2023 02:59:44 +0000 [thread overview]
Message-ID: <ZVbWZXvzudWTFpBk@google.com> (raw)
In-Reply-To: <f2df3ba6-76d2-4e2e-9c7e-54f6a84464b7@axis.com>
On Thu, Nov 16, 2023 at 08:43:00AM +0100, Jiri Valek - 2N wrote:
> On 11/8/23 20:53, Rob Herring wrote:
> > On Wed, Nov 8, 2023 at 9:57 AM Jiri Valek - 2N <jiriv@axis.com> wrote:
> >>
> >> Separate IRQ parsing is not necessary, I2C core do the job.
> >>
> >> Signed-off-by: Jiri Valek - 2N <jiriv@axis.com>
> >> ---
> >> drivers/input/keyboard/cap11xx.c | 10 ++--------
> >> 1 file changed, 2 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> >> index 4711ea985627..ccca9936ef25 100644
> >> --- a/drivers/input/keyboard/cap11xx.c
> >> +++ b/drivers/input/keyboard/cap11xx.c
> >> @@ -518,7 +518,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> >> struct device *dev = &i2c_client->dev;
> >> struct cap11xx_priv *priv;
> >> const struct cap11xx_hw_model *cap;
> >> - int i, error, irq;
> >> + int i, error;
> >> unsigned int val, rev;
> >>
> >> if (id->driver_data >= ARRAY_SIZE(cap11xx_devices)) {
> >> @@ -624,13 +624,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> >> if (error)
> >> return error;
> >>
> >> - irq = irq_of_parse_and_map(dev->of_node, 0);
> >
> > Probably can drop the include of of_irq.h as well.
> Ack. Thanks for notice!
I replaced it with #include <of.h> and applied, thank you.
--
Dmitry
prev parent reply other threads:[~2023-11-17 3:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:56 [PATCH v5 0/3] Input: cap11xx add advanced sensitivity settings Jiri Valek - 2N
2023-11-08 15:56 ` [PATCH v5 1/3] dt-bindings: input: microchip,cap11xx: " Jiri Valek - 2N
2023-11-10 8:22 ` Krzysztof Kozlowski
2023-11-16 16:00 ` Jiri Valek - 2N
2023-11-16 17:24 ` Krzysztof Kozlowski
2023-11-08 15:56 ` [PATCH v5 2/3] Input: cap11xx - " Jiri Valek - 2N
2023-11-08 15:56 ` [PATCH v5 3/3] Input: cap11xx - remove unnecessary IRQ parsing Jiri Valek - 2N
2023-11-08 19:53 ` Rob Herring
2023-11-16 7:43 ` Jiri Valek - 2N
2023-11-17 2:59 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVbWZXvzudWTFpBk@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jiriv@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.