From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B528C072A2 for ; Fri, 17 Nov 2023 21:06:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BF7010E794; Fri, 17 Nov 2023 21:06:34 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1823010E793; Fri, 17 Nov 2023 21:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700255192; x=1731791192; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=P/2jZ6JHxUbZa9SDIcVD15ATpthu+hET9d9WFIL3VoU=; b=gRMse5a+U3hLfiYNIlhaZDGZEvkDy1x/4pJ6A+KxL9Dml2PFahkcQEvL +570fOubRktGmdA3joEgSI099CGGGokjYlH4IeZ/CfUmkZa0EULLXjdb0 9FBv7JW+f0vh+Xe1r63pbQfPQD7aLSJH6HeX8p5bRmBf9ad7GSlKIVWGT cA12B7AMW1R12nMnmeoojFa6Fxq4own/cOiIcfXl+QW0/Yf27IVqkMIOu Y+BhxizeKZBaZyGc5CrAgLmCjELgO5sHTNTTR431qQ7KrbKIwQJ4Rh9yp vwVSDZgw/TITlNc+2CpBF3FfHVOBN4cMyFsZxSSdw77VwxrmZY6EuCkc1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="371547065" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="371547065" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:06:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="769319948" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="769319948" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:06:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r462j-0000000Eu2V-3x4X; Fri, 17 Nov 2023 23:06:25 +0200 Date: Fri, 17 Nov 2023 23:06:25 +0200 From: Andy Shevchenko To: Hans de Goede Message-ID: References: <20231103201831.1037416-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Rodrigo Vivi , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote: > On 11/3/23 21:18, Andy Shevchenko wrote: > > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct > > talking to GPIO IP behind the actual driver's back. A second attempt > > to fix that is here. > > > > If I understood correctly, my approach should work in the similar way as > > the current IOSF GPIO. > > > > Hans, I believe you have some devices that use this piece of code, > > is it possible to give a test run on (one of) them? > > Ok, this now has been testen on both a BYT and a CHT device which > actually use GPIO controls in their MIPI sequences so this > series is: > > Tested-by: Hans de Goede > > And the code of the entire series also looks good to me: > > Reviewed-by: Hans de Goede > > for the series. Good news so far, thank you! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C965C54FB9 for ; Fri, 17 Nov 2023 21:06:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCEBE10E793; Fri, 17 Nov 2023 21:06:33 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1823010E793; Fri, 17 Nov 2023 21:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700255192; x=1731791192; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=P/2jZ6JHxUbZa9SDIcVD15ATpthu+hET9d9WFIL3VoU=; b=gRMse5a+U3hLfiYNIlhaZDGZEvkDy1x/4pJ6A+KxL9Dml2PFahkcQEvL +570fOubRktGmdA3joEgSI099CGGGokjYlH4IeZ/CfUmkZa0EULLXjdb0 9FBv7JW+f0vh+Xe1r63pbQfPQD7aLSJH6HeX8p5bRmBf9ad7GSlKIVWGT cA12B7AMW1R12nMnmeoojFa6Fxq4own/cOiIcfXl+QW0/Yf27IVqkMIOu Y+BhxizeKZBaZyGc5CrAgLmCjELgO5sHTNTTR431qQ7KrbKIwQJ4Rh9yp vwVSDZgw/TITlNc+2CpBF3FfHVOBN4cMyFsZxSSdw77VwxrmZY6EuCkc1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="371547065" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="371547065" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:06:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="769319948" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="769319948" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:06:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r462j-0000000Eu2V-3x4X; Fri, 17 Nov 2023 23:06:25 +0200 Date: Fri, 17 Nov 2023 23:06:25 +0200 From: Andy Shevchenko To: Hans de Goede Subject: Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO Message-ID: References: <20231103201831.1037416-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote: > On 11/3/23 21:18, Andy Shevchenko wrote: > > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct > > talking to GPIO IP behind the actual driver's back. A second attempt > > to fix that is here. > > > > If I understood correctly, my approach should work in the similar way as > > the current IOSF GPIO. > > > > Hans, I believe you have some devices that use this piece of code, > > is it possible to give a test run on (one of) them? > > Ok, this now has been testen on both a BYT and a CHT device which > actually use GPIO controls in their MIPI sequences so this > series is: > > Tested-by: Hans de Goede > > And the code of the entire series also looks good to me: > > Reviewed-by: Hans de Goede > > for the series. Good news so far, thank you! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE5FC5ACB3 for ; Fri, 17 Nov 2023 21:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346185AbjKQVGi (ORCPT ); Fri, 17 Nov 2023 16:06:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjKQVGe (ORCPT ); Fri, 17 Nov 2023 16:06:34 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1B7CB6 for ; Fri, 17 Nov 2023 13:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700255191; x=1731791191; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=P/2jZ6JHxUbZa9SDIcVD15ATpthu+hET9d9WFIL3VoU=; b=HDt4vLdVAL3werq5LYHDuhjkxNLH6tMOvkB48zaiM9piZPVOo6Wwq78+ jkbZAFtpDMVzogOEgycYgjY5DfP0Nh4vp23+k3sgOPTzL0LbrpLnu3wiB ljaBBr98azNgew4b7nhWJhwrEV2dQhKg7n3OHjwx7yLBJWpNhILa3ZGGw SuTE2wIncf+jfUo5olFOuSdRSYDE0qHpvL1rdVIlHGojcLgmGvLWwNRf3 rMx7Xmpzjxq2UQL8fbj9yASVW87ETGwjP9XxaxocFgM0h8GQ1CyKKKVQg eX0xAf+fOs/AGnM5D4Kfna7rTQZvi5hnN+DZqvUfjfuuXrsiBVX9/3od5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="371547064" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="371547064" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:06:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="769319948" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="769319948" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:06:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r462j-0000000Eu2V-3x4X; Fri, 17 Nov 2023 23:06:25 +0200 Date: Fri, 17 Nov 2023 23:06:25 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Subject: Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO Message-ID: References: <20231103201831.1037416-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote: > On 11/3/23 21:18, Andy Shevchenko wrote: > > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct > > talking to GPIO IP behind the actual driver's back. A second attempt > > to fix that is here. > > > > If I understood correctly, my approach should work in the similar way as > > the current IOSF GPIO. > > > > Hans, I believe you have some devices that use this piece of code, > > is it possible to give a test run on (one of) them? > > Ok, this now has been testen on both a BYT and a CHT device which > actually use GPIO controls in their MIPI sequences so this > series is: > > Tested-by: Hans de Goede > > And the code of the entire series also looks good to me: > > Reviewed-by: Hans de Goede > > for the series. Good news so far, thank you! -- With Best Regards, Andy Shevchenko