From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15098125A5 for ; Mon, 20 Nov 2023 09:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="eAF0KRxg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RRH8ihRwgqqNWiOQXVgz2lSe5cF5QqM2TrvGcFPpVxQ=; b=eAF0KRxgbthRFbPQ6izZC3J3oy NoICC18OIT3Qs7cMSCHEyKdPJVEqlqYYz46JeVVogCAoBWUhXiyxhy9SzyCivvREMDfvxXZSrMpqk BHZ3abqeLK7FySm29lIYiV3szbHsZGZ0MEwL9YBdWcQ/tt0m9Epi+ARclf048DAo9sTRBExtXyU2Y OWqc0bZ0sBPg5y7tECdJwrgrcIV0utpcws+XvnYsepZe+SO7zSvE1M0Dc3TnoMMhyx+qLFfvV/gAy zBVN1YBhtJaSqBUjieLhtAr5Xh4FKBvt+x6MQT63nLwsYbtpT2WmNNA7nk4PLOb78D4oGUQs88/cg AGe8pcpA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43368) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r512Z-0005Gn-2Y; Mon, 20 Nov 2023 09:58:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r512Z-00034w-8Z; Mon, 20 Nov 2023 09:58:03 +0000 Date: Mon, 20 Nov 2023 09:58:03 +0000 From: "Russell King (Oracle)" To: Jianyong Wu Cc: "linux-pm@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-acpi@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "kvmarm@lists.linux.dev" , "x86@kernel.org" , "linux-csky@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-parisc@vger.kernel.org" , Salil Mehta , Jean-Philippe Brucker , Justin He , James Morse , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi Subject: Re: [PATCH 34/39] arm64: psci: Ignore DENIED CPUs Message-ID: References: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) On Mon, Nov 20, 2023 at 09:36:05AM +0000, Jianyong Wu wrote: > > > > -----Original Message----- > > From: Russell King > > Sent: 2023年11月20日 17:25 > > To: Jianyong Wu > > Cc: linux-pm@vger.kernel.org; loongarch@lists.linux.dev; > > linux-acpi@vger.kernel.org; linux-arch@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-riscv@lists.infradead.org; kvmarm@lists.linux.dev; x86@kernel.org; > > linux-csky@vger.kernel.org; linux-doc@vger.kernel.org; > > linux-ia64@vger.kernel.org; linux-parisc@vger.kernel.org; Salil Mehta > > ; Jean-Philippe Brucker ; > > Justin He ; James Morse ; > > Catalin Marinas ; Will Deacon ; > > Mark Rutland ; Lorenzo Pieralisi > > > > Subject: Re: [PATCH 34/39] arm64: psci: Ignore DENIED CPUs > > > > On Thu, Nov 16, 2023 at 07:45:51AM +0000, Jianyong Wu wrote: > > > Hi Russell, > > > > > > One inline comment. > > ... > > > > Changes since RFC v2 > > > > * Add specification reference > > > > * Use EPERM rather than EPROBE_DEFER > > ... > > > > @@ -40,7 +40,7 @@ static int cpu_psci_cpu_boot(unsigned int cpu) { > > > > phys_addr_t pa_secondary_entry = __pa_symbol(secondary_entry); > > > > int err = psci_ops.cpu_on(cpu_logical_map(cpu), pa_secondary_entry); > > > > - if (err) > > > > + if (err && err != -EPROBE_DEFER) > > > > > > Should this be EPERM? As the following psci cpu_on op will return it. > > > I think you miss to change this when apply Jean-Philippe's patch. > > > > It looks like James didn't properly update all places. Also, > > > > > > diff --git a/drivers/firmware/psci/psci.c > > > > b/drivers/firmware/psci/psci.c index d9629ff87861..ee82e7880d8c > > > > 100644 > > > > --- a/drivers/firmware/psci/psci.c > > > > +++ b/drivers/firmware/psci/psci.c > > > > @@ -218,6 +218,8 @@ static int __psci_cpu_on(u32 fn, unsigned long > > > > cpuid, unsigned long entry_point) > > > > int err; > > > > > > > > err = invoke_psci_fn(fn, cpuid, entry_point, 0); > > > > + if (err == PSCI_RET_DENIED) > > > > + return -EPERM; > > > > return psci_to_linux_errno(err); > > > > This change is unnecessary - probably comes from when -EPROBE_DEFER was > > being used. psci_to_linux_errno() already does: > > But may print lots of noise like: > > [ 0.008955] smp: Bringing up secondary CPUs ... > [ 0.009661] psci: failed to boot CPU1 (-1) > [ 0.010360] psci: failed to boot CPU2 (-1) > [ 0.011164] psci: failed to boot CPU3 (-1) > [ 0.011946] psci: failed to boot CPU4 (-1) > [ 0.012764] psci: failed to boot CPU5 (-1) > [ 0.013534] psci: failed to boot CPU6 (-1) > [ 0.014349] psci: failed to boot CPU7 (-1) > [ 0.014820] smp: Brought up 1 node, 1 CPU > > Is this expected? Please read my email again, and take note of the _context_ above the places that I've commented. Context matters. What I'm saying is that this change: err = invoke_psci_fn(fn, cpuid, entry_point, 0); + if (err == PSCI_RET_DENIED) + return -EPERM; return psci_to_linux_errno(err); Is unnecessary when psci_to_linux_errno() already does: static __always_inline int psci_to_linux_errno(int errno) { switch (errno) { ... case PSCI_RET_DENIED: return -EPERM; So, a return of PSCI_RET_DENIED from invoke_psci_fn() above will _already_ be translated to -EPERM (which is -1) by psci_to_linux_errno(). There is no need to add that extra if() statement in __psci_cpu_on(). I was _not_ saying that the entire patch was unnecessary. Context matters. That's why we include context in replies. Standard email etiquette (before Microsoft messed it up) is to quote the email that is being replied to, trimming hard irrelevant content, and to place the reply comments immediately below the original content to which the comments relate, to give the reply comments the context necessary for correct interpretation. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63513C54E76 for ; Mon, 20 Nov 2023 09:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sK/zLAaNHCr8oVWF7QpF3G92abYJb0bIhOU1tmStiUk=; b=iooHW+nTXYmQx/ C+uqTREgRzOXQwbkCDfmaWSIRNYqOuH57rpnt7D1NWrQwmcgqAojwS8JQR67sgKNaLinHiCx48DoY OjflIfiY9zg1KT6uTIUi33S8bqZ3QNdeLnnPb8t0N2RpR59gbq3Q+fyWixzAzEyUXcT7oZPS/keNV X5zeD9txtnkWRIbnP3A6JPrmC9b5uHtvoFJ9qdX9exkXZ9DBhNkvf/T2oFDEQd87xmr8lWzA11gAV 51kZF6GfDp1TGAZGRHOE7LUTzUUMiXF52hzFGekSSzx3jU1tYKiTnJWKpM0bk8GJU2mobutDLRFCE uPikYwF6aaD/UAPtgW4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r512t-00Bi4D-0A; Mon, 20 Nov 2023 09:58:23 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r512j-00Bhyz-0p; Mon, 20 Nov 2023 09:58:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RRH8ihRwgqqNWiOQXVgz2lSe5cF5QqM2TrvGcFPpVxQ=; b=eAF0KRxgbthRFbPQ6izZC3J3oy NoICC18OIT3Qs7cMSCHEyKdPJVEqlqYYz46JeVVogCAoBWUhXiyxhy9SzyCivvREMDfvxXZSrMpqk BHZ3abqeLK7FySm29lIYiV3szbHsZGZ0MEwL9YBdWcQ/tt0m9Epi+ARclf048DAo9sTRBExtXyU2Y OWqc0bZ0sBPg5y7tECdJwrgrcIV0utpcws+XvnYsepZe+SO7zSvE1M0Dc3TnoMMhyx+qLFfvV/gAy zBVN1YBhtJaSqBUjieLhtAr5Xh4FKBvt+x6MQT63nLwsYbtpT2WmNNA7nk4PLOb78D4oGUQs88/cg AGe8pcpA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43368) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r512Z-0005Gn-2Y; Mon, 20 Nov 2023 09:58:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r512Z-00034w-8Z; Mon, 20 Nov 2023 09:58:03 +0000 Date: Mon, 20 Nov 2023 09:58:03 +0000 From: "Russell King (Oracle)" To: Jianyong Wu Cc: "linux-pm@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-acpi@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "kvmarm@lists.linux.dev" , "x86@kernel.org" , "linux-csky@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-parisc@vger.kernel.org" , Salil Mehta , Jean-Philippe Brucker , Justin He , James Morse , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi Subject: Re: [PATCH 34/39] arm64: psci: Ignore DENIED CPUs Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_015813_294607_0572E10F X-CRM114-Status: GOOD ( 25.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMjAsIDIwMjMgYXQgMDk6MzY6MDVBTSArMDAwMCwgSmlhbnlvbmcgV3Ugd3Jv dGU6Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTogUnVzc2Vs bCBLaW5nIDxsaW51eEBhcm1saW51eC5vcmcudWs+Cj4gPiBTZW50OiAyMDIz5bm0MTHmnIgyMOaX pSAxNzoyNQo+ID4gVG86IEppYW55b25nIFd1IDxKaWFueW9uZy5XdUBhcm0uY29tPgo+ID4gQ2M6 IGxpbnV4LXBtQHZnZXIua2VybmVsLm9yZzsgbG9vbmdhcmNoQGxpc3RzLmxpbnV4LmRldjsKPiA+ IGxpbnV4LWFjcGlAdmdlci5rZXJuZWwub3JnOyBsaW51eC1hcmNoQHZnZXIua2VybmVsLm9yZzsK PiA+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZzsKPiA+IGxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmc7IGt2bWFy bUBsaXN0cy5saW51eC5kZXY7IHg4NkBrZXJuZWwub3JnOwo+ID4gbGludXgtY3NreUB2Z2VyLmtl cm5lbC5vcmc7IGxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmc7Cj4gPiBsaW51eC1pYTY0QHZnZXIu a2VybmVsLm9yZzsgbGludXgtcGFyaXNjQHZnZXIua2VybmVsLm9yZzsgU2FsaWwgTWVodGEKPiA+ IDxzYWxpbC5tZWh0YUBodWF3ZWkuY29tPjsgSmVhbi1QaGlsaXBwZSBCcnVja2VyIDxqZWFuLXBo aWxpcHBlQGxpbmFyby5vcmc+Owo+ID4gSnVzdGluIEhlIDxKdXN0aW4uSGVAYXJtLmNvbT47IEph bWVzIE1vcnNlIDxKYW1lcy5Nb3JzZUBhcm0uY29tPjsKPiA+IENhdGFsaW4gTWFyaW5hcyA8Q2F0 YWxpbi5NYXJpbmFzQGFybS5jb20+OyBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPjsKPiA+ IE1hcmsgUnV0bGFuZCA8TWFyay5SdXRsYW5kQGFybS5jb20+OyBMb3JlbnpvIFBpZXJhbGlzaQo+ ID4gPGxwaWVyYWxpc2lAa2VybmVsLm9yZz4KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMzQvMzld IGFybTY0OiBwc2NpOiBJZ25vcmUgREVOSUVEIENQVXMKPiA+IAo+ID4gT24gVGh1LCBOb3YgMTYs IDIwMjMgYXQgMDc6NDU6NTFBTSArMDAwMCwgSmlhbnlvbmcgV3Ugd3JvdGU6Cj4gPiA+IEhpIFJ1 c3NlbGwsCj4gPiA+Cj4gPiA+IE9uZSBpbmxpbmUgY29tbWVudC4KPiA+IC4uLgo+ID4gPiA+IENo YW5nZXMgc2luY2UgUkZDIHYyCj4gPiA+ID4gICogQWRkIHNwZWNpZmljYXRpb24gcmVmZXJlbmNl Cj4gPiA+ID4gICogVXNlIEVQRVJNIHJhdGhlciB0aGFuIEVQUk9CRV9ERUZFUgo+ID4gLi4uCj4g PiA+ID4gQEAgLTQwLDcgKzQwLDcgQEAgc3RhdGljIGludCBjcHVfcHNjaV9jcHVfYm9vdCh1bnNp Z25lZCBpbnQgY3B1KSAgewo+ID4gPiA+ICAJcGh5c19hZGRyX3QgcGFfc2Vjb25kYXJ5X2VudHJ5 ID0gX19wYV9zeW1ib2woc2Vjb25kYXJ5X2VudHJ5KTsKPiA+ID4gPiAgCWludCBlcnIgPSBwc2Np X29wcy5jcHVfb24oY3B1X2xvZ2ljYWxfbWFwKGNwdSksIHBhX3NlY29uZGFyeV9lbnRyeSk7Cj4g PiA+ID4gLQlpZiAoZXJyKQo+ID4gPiA+ICsJaWYgKGVyciAmJiBlcnIgIT0gLUVQUk9CRV9ERUZF UikKPiA+ID4KPiA+ID4gU2hvdWxkIHRoaXMgYmUgRVBFUk0/IEFzIHRoZSBmb2xsb3dpbmcgcHNj aSBjcHVfb24gb3Agd2lsbCByZXR1cm4gaXQuCj4gPiA+IEkgdGhpbmsgeW91IG1pc3MgdG8gY2hh bmdlIHRoaXMgd2hlbiBhcHBseSBKZWFuLVBoaWxpcHBlJ3MgcGF0Y2guCj4gPiAKPiA+IEl0IGxv b2tzIGxpa2UgSmFtZXMgZGlkbid0IHByb3Blcmx5IHVwZGF0ZSBhbGwgcGxhY2VzLiBBbHNvLAo+ ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZmlybXdhcmUvcHNjaS9wc2NpLmMKPiA+ ID4gPiBiL2RyaXZlcnMvZmlybXdhcmUvcHNjaS9wc2NpLmMgaW5kZXggZDk2MjlmZjg3ODYxLi5l ZTgyZTc4ODBkOGMKPiA+ID4gPiAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2Zpcm13YXJl L3BzY2kvcHNjaS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9maXJtd2FyZS9wc2NpL3BzY2kuYwo+ ID4gPiA+IEBAIC0yMTgsNiArMjE4LDggQEAgc3RhdGljIGludCBfX3BzY2lfY3B1X29uKHUzMiBm biwgdW5zaWduZWQgbG9uZwo+ID4gPiA+IGNwdWlkLCB1bnNpZ25lZCBsb25nIGVudHJ5X3BvaW50 KQo+ID4gPiA+ICAJaW50IGVycjsKPiA+ID4gPgo+ID4gPiA+ICAJZXJyID0gaW52b2tlX3BzY2lf Zm4oZm4sIGNwdWlkLCBlbnRyeV9wb2ludCwgMCk7Cj4gPiA+ID4gKwlpZiAoZXJyID09IFBTQ0lf UkVUX0RFTklFRCkKPiA+ID4gPiArCQlyZXR1cm4gLUVQRVJNOwo+ID4gPiA+ICAJcmV0dXJuIHBz Y2lfdG9fbGludXhfZXJybm8oZXJyKTsKPiA+IAo+ID4gVGhpcyBjaGFuZ2UgaXMgdW5uZWNlc3Nh cnkgLSBwcm9iYWJseSBjb21lcyBmcm9tIHdoZW4gLUVQUk9CRV9ERUZFUiB3YXMKPiA+IGJlaW5n IHVzZWQuIHBzY2lfdG9fbGludXhfZXJybm8oKSBhbHJlYWR5IGRvZXM6Cj4gCj4gQnV0IG1heSBw cmludCBsb3RzIG9mIG5vaXNlIGxpa2U6Cj4gCj4gWyAgICAwLjAwODk1NV0gc21wOiBCcmluZ2lu ZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4KPiBbICAgIDAuMDA5NjYxXSBwc2NpOiBmYWlsZWQgdG8g Ym9vdCBDUFUxICgtMSkKPiBbICAgIDAuMDEwMzYwXSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFUy ICgtMSkKPiBbICAgIDAuMDExMTY0XSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFUzICgtMSkKPiBb ICAgIDAuMDExOTQ2XSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFU0ICgtMSkKPiBbICAgIDAuMDEy NzY0XSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFU1ICgtMSkKPiBbICAgIDAuMDEzNTM0XSBwc2Np OiBmYWlsZWQgdG8gYm9vdCBDUFU2ICgtMSkKPiBbICAgIDAuMDE0MzQ5XSBwc2NpOiBmYWlsZWQg dG8gYm9vdCBDUFU3ICgtMSkKPiBbICAgIDAuMDE0ODIwXSBzbXA6IEJyb3VnaHQgdXAgMSBub2Rl LCAxIENQVQo+IAo+IElzIHRoaXMgZXhwZWN0ZWQ/CgpQbGVhc2UgcmVhZCBteSBlbWFpbCBhZ2Fp biwgYW5kIHRha2Ugbm90ZSBvZiB0aGUgX2NvbnRleHRfIGFib3ZlIHRoZQpwbGFjZXMgdGhhdCBJ J3ZlIGNvbW1lbnRlZC4gQ29udGV4dCBtYXR0ZXJzLgoKV2hhdCBJJ20gc2F5aW5nIGlzIHRoYXQg dGhpcyBjaGFuZ2U6CgogCWVyciA9IGludm9rZV9wc2NpX2ZuKGZuLCBjcHVpZCwgZW50cnlfcG9p bnQsIDApOworCWlmIChlcnIgPT0gUFNDSV9SRVRfREVOSUVEKQorCQlyZXR1cm4gLUVQRVJNOwog CXJldHVybiBwc2NpX3RvX2xpbnV4X2Vycm5vKGVycik7CgpJcyB1bm5lY2Vzc2FyeSB3aGVuIHBz Y2lfdG9fbGludXhfZXJybm8oKSBhbHJlYWR5IGRvZXM6CgpzdGF0aWMgX19hbHdheXNfaW5saW5l IGludCBwc2NpX3RvX2xpbnV4X2Vycm5vKGludCBlcnJubykKewoJc3dpdGNoIChlcnJubykgewoJ Li4uCgljYXNlIFBTQ0lfUkVUX0RFTklFRDoKCQlyZXR1cm4gLUVQRVJNOwoKU28sIGEgcmV0dXJu IG9mIFBTQ0lfUkVUX0RFTklFRCBmcm9tIGludm9rZV9wc2NpX2ZuKCkgYWJvdmUgd2lsbApfYWxy ZWFkeV8gYmUgdHJhbnNsYXRlZCB0byAtRVBFUk0gKHdoaWNoIGlzIC0xKSBieQpwc2NpX3RvX2xp bnV4X2Vycm5vKCkuIFRoZXJlIGlzIG5vIG5lZWQgdG8gYWRkIHRoYXQgZXh0cmEgaWYoKQpzdGF0 ZW1lbnQgaW4gX19wc2NpX2NwdV9vbigpLgoKSSB3YXMgX25vdF8gc2F5aW5nIHRoYXQgdGhlIGVu dGlyZSBwYXRjaCB3YXMgdW5uZWNlc3NhcnkuCgpDb250ZXh0IG1hdHRlcnMuIFRoYXQncyB3aHkg d2UgaW5jbHVkZSBjb250ZXh0IGluIHJlcGxpZXMuCgpTdGFuZGFyZCBlbWFpbCBldGlxdWV0dGUg KGJlZm9yZSBNaWNyb3NvZnQgbWVzc2VkIGl0IHVwKSBpcyB0byBxdW90ZSB0aGUKZW1haWwgdGhh dCBpcyBiZWluZyByZXBsaWVkIHRvLCB0cmltbWluZyBoYXJkIGlycmVsZXZhbnQgY29udGVudCwg YW5kIHRvCnBsYWNlIHRoZSByZXBseSBjb21tZW50cyBpbW1lZGlhdGVseSBiZWxvdyB0aGUgb3Jp Z2luYWwgY29udGVudCB0byB3aGljaAp0aGUgY29tbWVudHMgcmVsYXRlLCB0byBnaXZlIHRoZSBy ZXBseSBjb21tZW50cyB0aGUgY29udGV4dCBuZWNlc3NhcnkKZm9yIGNvcnJlY3QgaW50ZXJwcmV0 YXRpb24uCgpUaGFua3MuCgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1s aW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVFAgaXMgaGVyZSEgODBNYnBzIGRvd24g MTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0IGxhc3QhCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QK bGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB0DC54E76 for ; Mon, 20 Nov 2023 09:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k6YsJxl/JJw/Que9dnjRxVDXixyn65JrCNI3jb0sX9U=; b=Sw3dk6pN6EtWMa qKxqVT74ju7aJN+yXmSFm2SIhWtMuJ/yDunSxZYjir6jOqmvfJb4CQwlfotk2y3na22ZcpyB1OfNr S34iYT7KCX3vPGe5QriLfhhqHIE91m4ovGTkX1v0kdXFZI0lI/ISwM45+BrXb6Jy6MLo0uK2s0XaU Cq2f1ibth77TeziRD7f3jUntSM49TfnURPul8Yp4ERQS7Qs080kYqjXgSTMvwicBgj43FoKjyZYld aTjLCaCG9wmWmvpJe2Yw6ky4Fuv2hwHwTPBoSe2E/nxbCNJBf+HTM1SS+/FXjGSknJ9bjzNG6WqAy dL5/VnYNmtmQMWgv17HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r512s-00Bi3f-0k; Mon, 20 Nov 2023 09:58:22 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r512j-00Bhyz-0p; Mon, 20 Nov 2023 09:58:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RRH8ihRwgqqNWiOQXVgz2lSe5cF5QqM2TrvGcFPpVxQ=; b=eAF0KRxgbthRFbPQ6izZC3J3oy NoICC18OIT3Qs7cMSCHEyKdPJVEqlqYYz46JeVVogCAoBWUhXiyxhy9SzyCivvREMDfvxXZSrMpqk BHZ3abqeLK7FySm29lIYiV3szbHsZGZ0MEwL9YBdWcQ/tt0m9Epi+ARclf048DAo9sTRBExtXyU2Y OWqc0bZ0sBPg5y7tECdJwrgrcIV0utpcws+XvnYsepZe+SO7zSvE1M0Dc3TnoMMhyx+qLFfvV/gAy zBVN1YBhtJaSqBUjieLhtAr5Xh4FKBvt+x6MQT63nLwsYbtpT2WmNNA7nk4PLOb78D4oGUQs88/cg AGe8pcpA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43368) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r512Z-0005Gn-2Y; Mon, 20 Nov 2023 09:58:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r512Z-00034w-8Z; Mon, 20 Nov 2023 09:58:03 +0000 Date: Mon, 20 Nov 2023 09:58:03 +0000 From: "Russell King (Oracle)" To: Jianyong Wu Cc: "linux-pm@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-acpi@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "kvmarm@lists.linux.dev" , "x86@kernel.org" , "linux-csky@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-parisc@vger.kernel.org" , Salil Mehta , Jean-Philippe Brucker , Justin He , James Morse , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi Subject: Re: [PATCH 34/39] arm64: psci: Ignore DENIED CPUs Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_015813_294607_0572E10F X-CRM114-Status: GOOD ( 25.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMjAsIDIwMjMgYXQgMDk6MzY6MDVBTSArMDAwMCwgSmlhbnlvbmcgV3Ugd3Jv dGU6Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTogUnVzc2Vs bCBLaW5nIDxsaW51eEBhcm1saW51eC5vcmcudWs+Cj4gPiBTZW50OiAyMDIz5bm0MTHmnIgyMOaX pSAxNzoyNQo+ID4gVG86IEppYW55b25nIFd1IDxKaWFueW9uZy5XdUBhcm0uY29tPgo+ID4gQ2M6 IGxpbnV4LXBtQHZnZXIua2VybmVsLm9yZzsgbG9vbmdhcmNoQGxpc3RzLmxpbnV4LmRldjsKPiA+ IGxpbnV4LWFjcGlAdmdlci5rZXJuZWwub3JnOyBsaW51eC1hcmNoQHZnZXIua2VybmVsLm9yZzsK PiA+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZzsKPiA+IGxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmc7IGt2bWFy bUBsaXN0cy5saW51eC5kZXY7IHg4NkBrZXJuZWwub3JnOwo+ID4gbGludXgtY3NreUB2Z2VyLmtl cm5lbC5vcmc7IGxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmc7Cj4gPiBsaW51eC1pYTY0QHZnZXIu a2VybmVsLm9yZzsgbGludXgtcGFyaXNjQHZnZXIua2VybmVsLm9yZzsgU2FsaWwgTWVodGEKPiA+ IDxzYWxpbC5tZWh0YUBodWF3ZWkuY29tPjsgSmVhbi1QaGlsaXBwZSBCcnVja2VyIDxqZWFuLXBo aWxpcHBlQGxpbmFyby5vcmc+Owo+ID4gSnVzdGluIEhlIDxKdXN0aW4uSGVAYXJtLmNvbT47IEph bWVzIE1vcnNlIDxKYW1lcy5Nb3JzZUBhcm0uY29tPjsKPiA+IENhdGFsaW4gTWFyaW5hcyA8Q2F0 YWxpbi5NYXJpbmFzQGFybS5jb20+OyBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPjsKPiA+ IE1hcmsgUnV0bGFuZCA8TWFyay5SdXRsYW5kQGFybS5jb20+OyBMb3JlbnpvIFBpZXJhbGlzaQo+ ID4gPGxwaWVyYWxpc2lAa2VybmVsLm9yZz4KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMzQvMzld IGFybTY0OiBwc2NpOiBJZ25vcmUgREVOSUVEIENQVXMKPiA+IAo+ID4gT24gVGh1LCBOb3YgMTYs IDIwMjMgYXQgMDc6NDU6NTFBTSArMDAwMCwgSmlhbnlvbmcgV3Ugd3JvdGU6Cj4gPiA+IEhpIFJ1 c3NlbGwsCj4gPiA+Cj4gPiA+IE9uZSBpbmxpbmUgY29tbWVudC4KPiA+IC4uLgo+ID4gPiA+IENo YW5nZXMgc2luY2UgUkZDIHYyCj4gPiA+ID4gICogQWRkIHNwZWNpZmljYXRpb24gcmVmZXJlbmNl Cj4gPiA+ID4gICogVXNlIEVQRVJNIHJhdGhlciB0aGFuIEVQUk9CRV9ERUZFUgo+ID4gLi4uCj4g PiA+ID4gQEAgLTQwLDcgKzQwLDcgQEAgc3RhdGljIGludCBjcHVfcHNjaV9jcHVfYm9vdCh1bnNp Z25lZCBpbnQgY3B1KSAgewo+ID4gPiA+ICAJcGh5c19hZGRyX3QgcGFfc2Vjb25kYXJ5X2VudHJ5 ID0gX19wYV9zeW1ib2woc2Vjb25kYXJ5X2VudHJ5KTsKPiA+ID4gPiAgCWludCBlcnIgPSBwc2Np X29wcy5jcHVfb24oY3B1X2xvZ2ljYWxfbWFwKGNwdSksIHBhX3NlY29uZGFyeV9lbnRyeSk7Cj4g PiA+ID4gLQlpZiAoZXJyKQo+ID4gPiA+ICsJaWYgKGVyciAmJiBlcnIgIT0gLUVQUk9CRV9ERUZF UikKPiA+ID4KPiA+ID4gU2hvdWxkIHRoaXMgYmUgRVBFUk0/IEFzIHRoZSBmb2xsb3dpbmcgcHNj aSBjcHVfb24gb3Agd2lsbCByZXR1cm4gaXQuCj4gPiA+IEkgdGhpbmsgeW91IG1pc3MgdG8gY2hh bmdlIHRoaXMgd2hlbiBhcHBseSBKZWFuLVBoaWxpcHBlJ3MgcGF0Y2guCj4gPiAKPiA+IEl0IGxv b2tzIGxpa2UgSmFtZXMgZGlkbid0IHByb3Blcmx5IHVwZGF0ZSBhbGwgcGxhY2VzLiBBbHNvLAo+ ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZmlybXdhcmUvcHNjaS9wc2NpLmMKPiA+ ID4gPiBiL2RyaXZlcnMvZmlybXdhcmUvcHNjaS9wc2NpLmMgaW5kZXggZDk2MjlmZjg3ODYxLi5l ZTgyZTc4ODBkOGMKPiA+ID4gPiAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2Zpcm13YXJl L3BzY2kvcHNjaS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9maXJtd2FyZS9wc2NpL3BzY2kuYwo+ ID4gPiA+IEBAIC0yMTgsNiArMjE4LDggQEAgc3RhdGljIGludCBfX3BzY2lfY3B1X29uKHUzMiBm biwgdW5zaWduZWQgbG9uZwo+ID4gPiA+IGNwdWlkLCB1bnNpZ25lZCBsb25nIGVudHJ5X3BvaW50 KQo+ID4gPiA+ICAJaW50IGVycjsKPiA+ID4gPgo+ID4gPiA+ICAJZXJyID0gaW52b2tlX3BzY2lf Zm4oZm4sIGNwdWlkLCBlbnRyeV9wb2ludCwgMCk7Cj4gPiA+ID4gKwlpZiAoZXJyID09IFBTQ0lf UkVUX0RFTklFRCkKPiA+ID4gPiArCQlyZXR1cm4gLUVQRVJNOwo+ID4gPiA+ICAJcmV0dXJuIHBz Y2lfdG9fbGludXhfZXJybm8oZXJyKTsKPiA+IAo+ID4gVGhpcyBjaGFuZ2UgaXMgdW5uZWNlc3Nh cnkgLSBwcm9iYWJseSBjb21lcyBmcm9tIHdoZW4gLUVQUk9CRV9ERUZFUiB3YXMKPiA+IGJlaW5n IHVzZWQuIHBzY2lfdG9fbGludXhfZXJybm8oKSBhbHJlYWR5IGRvZXM6Cj4gCj4gQnV0IG1heSBw cmludCBsb3RzIG9mIG5vaXNlIGxpa2U6Cj4gCj4gWyAgICAwLjAwODk1NV0gc21wOiBCcmluZ2lu ZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi4KPiBbICAgIDAuMDA5NjYxXSBwc2NpOiBmYWlsZWQgdG8g Ym9vdCBDUFUxICgtMSkKPiBbICAgIDAuMDEwMzYwXSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFUy ICgtMSkKPiBbICAgIDAuMDExMTY0XSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFUzICgtMSkKPiBb ICAgIDAuMDExOTQ2XSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFU0ICgtMSkKPiBbICAgIDAuMDEy NzY0XSBwc2NpOiBmYWlsZWQgdG8gYm9vdCBDUFU1ICgtMSkKPiBbICAgIDAuMDEzNTM0XSBwc2Np OiBmYWlsZWQgdG8gYm9vdCBDUFU2ICgtMSkKPiBbICAgIDAuMDE0MzQ5XSBwc2NpOiBmYWlsZWQg dG8gYm9vdCBDUFU3ICgtMSkKPiBbICAgIDAuMDE0ODIwXSBzbXA6IEJyb3VnaHQgdXAgMSBub2Rl LCAxIENQVQo+IAo+IElzIHRoaXMgZXhwZWN0ZWQ/CgpQbGVhc2UgcmVhZCBteSBlbWFpbCBhZ2Fp biwgYW5kIHRha2Ugbm90ZSBvZiB0aGUgX2NvbnRleHRfIGFib3ZlIHRoZQpwbGFjZXMgdGhhdCBJ J3ZlIGNvbW1lbnRlZC4gQ29udGV4dCBtYXR0ZXJzLgoKV2hhdCBJJ20gc2F5aW5nIGlzIHRoYXQg dGhpcyBjaGFuZ2U6CgogCWVyciA9IGludm9rZV9wc2NpX2ZuKGZuLCBjcHVpZCwgZW50cnlfcG9p bnQsIDApOworCWlmIChlcnIgPT0gUFNDSV9SRVRfREVOSUVEKQorCQlyZXR1cm4gLUVQRVJNOwog CXJldHVybiBwc2NpX3RvX2xpbnV4X2Vycm5vKGVycik7CgpJcyB1bm5lY2Vzc2FyeSB3aGVuIHBz Y2lfdG9fbGludXhfZXJybm8oKSBhbHJlYWR5IGRvZXM6CgpzdGF0aWMgX19hbHdheXNfaW5saW5l IGludCBwc2NpX3RvX2xpbnV4X2Vycm5vKGludCBlcnJubykKewoJc3dpdGNoIChlcnJubykgewoJ Li4uCgljYXNlIFBTQ0lfUkVUX0RFTklFRDoKCQlyZXR1cm4gLUVQRVJNOwoKU28sIGEgcmV0dXJu IG9mIFBTQ0lfUkVUX0RFTklFRCBmcm9tIGludm9rZV9wc2NpX2ZuKCkgYWJvdmUgd2lsbApfYWxy ZWFkeV8gYmUgdHJhbnNsYXRlZCB0byAtRVBFUk0gKHdoaWNoIGlzIC0xKSBieQpwc2NpX3RvX2xp bnV4X2Vycm5vKCkuIFRoZXJlIGlzIG5vIG5lZWQgdG8gYWRkIHRoYXQgZXh0cmEgaWYoKQpzdGF0 ZW1lbnQgaW4gX19wc2NpX2NwdV9vbigpLgoKSSB3YXMgX25vdF8gc2F5aW5nIHRoYXQgdGhlIGVu dGlyZSBwYXRjaCB3YXMgdW5uZWNlc3NhcnkuCgpDb250ZXh0IG1hdHRlcnMuIFRoYXQncyB3aHkg d2UgaW5jbHVkZSBjb250ZXh0IGluIHJlcGxpZXMuCgpTdGFuZGFyZCBlbWFpbCBldGlxdWV0dGUg KGJlZm9yZSBNaWNyb3NvZnQgbWVzc2VkIGl0IHVwKSBpcyB0byBxdW90ZSB0aGUKZW1haWwgdGhh dCBpcyBiZWluZyByZXBsaWVkIHRvLCB0cmltbWluZyBoYXJkIGlycmVsZXZhbnQgY29udGVudCwg YW5kIHRvCnBsYWNlIHRoZSByZXBseSBjb21tZW50cyBpbW1lZGlhdGVseSBiZWxvdyB0aGUgb3Jp Z2luYWwgY29udGVudCB0byB3aGljaAp0aGUgY29tbWVudHMgcmVsYXRlLCB0byBnaXZlIHRoZSBy ZXBseSBjb21tZW50cyB0aGUgY29udGV4dCBuZWNlc3NhcnkKZm9yIGNvcnJlY3QgaW50ZXJwcmV0 YXRpb24uCgpUaGFua3MuCgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1s aW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVFAgaXMgaGVyZSEgODBNYnBzIGRvd24g MTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0IGxhc3QhCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==