From: Peter Xu <peterx@redhat.com>
To: Zongmin Zhou <zhouzongmin@kylinos.cn>
Cc: berrange@redhat.com, farosas@suse.de, leobras@redhat.com,
qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH v3] migration: free 'saddr' since be no longer used
Date: Mon, 20 Nov 2023 09:01:03 -0500 [thread overview]
Message-ID: <ZVtmn0WXTKPxCbKU@x1n> (raw)
In-Reply-To: <20231120031428.908295-1-zhouzongmin@kylinos.cn>
On Mon, Nov 20, 2023 at 11:14:28AM +0800, Zongmin Zhou wrote:
> Since socket_parse() will allocate memory for 'saddr',and its value
> will pass to 'addr' that allocated by migrate_uri_parse(),
> then 'saddr' will no longer used,need to free.
> But due to 'saddr->u' is shallow copying the contents of the union,
> the members of this union containing allocated strings,and will be used after that.
> So just free 'saddr' itself without doing a deep free on the contents of the SocketAddress.
>
> Fixes: 72a8192e225c ("migration: convert migration 'uri' into 'MigrateAddress'")
> Signed-off-by: Zongmin Zhou<zhouzongmin@kylinos.cn>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2023-11-20 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 3:27 [PATCH] migration: free 'saddr' since be no longer used Zongmin Zhou
2023-11-15 9:49 ` Daniel P. Berrangé
2023-11-15 16:44 ` Peter Xu
2023-11-16 6:34 ` [PATCH v2] " Zongmin Zhou
2023-11-16 14:19 ` Juan Quintela
2023-11-17 2:51 ` Zongmin Zhou
2023-11-17 13:56 ` Peter Xu
2023-11-20 3:14 ` [PATCH v3] " Zongmin Zhou
2023-11-20 9:08 ` Daniel P. Berrangé
2023-11-20 14:01 ` Peter Xu [this message]
2023-11-29 2:09 ` Zongmin Zhou
2023-11-29 14:47 ` Peter Xu
2023-11-30 10:20 ` Het Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVtmn0WXTKPxCbKU@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.