From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED8B730D1E for ; Tue, 21 Nov 2023 11:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BBD48FEC; Tue, 21 Nov 2023 03:55:29 -0800 (PST) Received: from arm.com (e121798.cambridge.arm.com [10.1.197.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD1103F7A6; Tue, 21 Nov 2023 03:54:38 -0800 (PST) Date: Tue, 21 Nov 2023 11:54:36 +0000 From: Alexandru Elisei To: Peter Collingbourne Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC 20/37] mm: compaction: Reserve metadata storage in compaction_alloc() Message-ID: References: <20230823131350.114942-1-alexandru.elisei@arm.com> <20230823131350.114942-21-alexandru.elisei@arm.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Peter, On Mon, Nov 20, 2023 at 08:49:32PM -0800, Peter Collingbourne wrote: > Hi Alexandru, > > On Wed, Aug 23, 2023 at 6:16 AM Alexandru Elisei > wrote: > > > > If the source page being migrated has metadata associated with it, make > > sure to reserve the metadata storage when choosing a suitable destination > > page from the free list. > > > > Signed-off-by: Alexandru Elisei > > --- > > mm/compaction.c | 9 +++++++++ > > mm/internal.h | 1 + > > 2 files changed, 10 insertions(+) > > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index cc0139fa0cb0..af2ee3085623 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -570,6 +570,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > > bool locked = false; > > unsigned long blockpfn = *start_pfn; > > unsigned int order; > > + int ret; > > > > /* Strict mode is for isolation, speed is secondary */ > > if (strict) > > @@ -626,6 +627,11 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > > > > /* Found a free page, will break it into order-0 pages */ > > order = buddy_order(page); > > + if (metadata_storage_enabled() && cc->reserve_metadata) { > > + ret = reserve_metadata_storage(page, order, cc->gfp_mask); > > At this point the zone lock is held and preemption is disabled, which > makes it invalid to call reserve_metadata_storage. You are correct, I missed that. I dropped reserving tag storage during compaction in the next iteration, so fortunately I unintentionally fixed it. Thanks, Alex > > Peter > > > + if (ret) > > + goto isolate_fail; > > + } > > isolated = __isolate_free_page(page, order); > > if (!isolated) > > break; > > @@ -1757,6 +1763,9 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) > > struct compact_control *cc = (struct compact_control *)data; > > struct folio *dst; > > > > + if (metadata_storage_enabled()) > > + cc->reserve_metadata = folio_has_metadata(src); > > + > > if (list_empty(&cc->freepages)) { > > isolate_freepages(cc); > > > > diff --git a/mm/internal.h b/mm/internal.h > > index d28ac0085f61..046cc264bfbe 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -492,6 +492,7 @@ struct compact_control { > > */ > > bool alloc_contig; /* alloc_contig_range allocation */ > > bool source_has_metadata; /* source pages have associated metadata */ > > + bool reserve_metadata; > > }; > > > > /* > > -- > > 2.41.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99BCEC54FB9 for ; Tue, 21 Nov 2023 11:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Zh6JrTvK4BRzjtmk0/5kmCwigW1EgF1yda+ZgAkqtg=; b=QzZsY15AmK247U 5OKPniBrO+A/Fj96jjWs4IgRGa9f+hVyUoNew0RqLTZdUnPXAmqNpjCaVS/n2wSVyiNk9nZyjaUP6 reZ5vZSZMHCDiL3+ndVg/dcLebTjr5ySo9fDAcALp1DyCDk+9qvoA1HEMvS2GlEZkFwC6wbcMqPU+ uocR3dPHhHOF7R6H5/MXKO1APffKBLC17w41MfBEY9JsO26oi2Ad8JXV3NvEPEaP3dAZ5Dcqg0ibs G7wxG96epuv25CJDuMsB9teQ5YfPRjqRvm7juC4MK/jB0/ArCMMK0GIy3mhUOoeD1IcRSn4q28QaQ j9rap1Mf33bEOeEf6ZFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5PL7-00GcJt-0z; Tue, 21 Nov 2023 11:54:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5PL3-00GcIO-2h for linux-arm-kernel@lists.infradead.org; Tue, 21 Nov 2023 11:54:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BBD48FEC; Tue, 21 Nov 2023 03:55:29 -0800 (PST) Received: from arm.com (e121798.cambridge.arm.com [10.1.197.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD1103F7A6; Tue, 21 Nov 2023 03:54:38 -0800 (PST) Date: Tue, 21 Nov 2023 11:54:36 +0000 From: Alexandru Elisei To: Peter Collingbourne Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC 20/37] mm: compaction: Reserve metadata storage in compaction_alloc() Message-ID: References: <20230823131350.114942-1-alexandru.elisei@arm.com> <20230823131350.114942-21-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_035445_964648_110CB94B X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGV0ZXIsCgpPbiBNb24sIE5vdiAyMCwgMjAyMyBhdCAwODo0OTozMlBNIC0wODAwLCBQZXRl ciBDb2xsaW5nYm91cm5lIHdyb3RlOgo+IEhpIEFsZXhhbmRydSwKPiAKPiBPbiBXZWQsIEF1ZyAy MywgMjAyMyBhdCA2OjE24oCvQU0gQWxleGFuZHJ1IEVsaXNlaQo+IDxhbGV4YW5kcnUuZWxpc2Vp QGFybS5jb20+IHdyb3RlOgo+ID4KPiA+IElmIHRoZSBzb3VyY2UgcGFnZSBiZWluZyBtaWdyYXRl ZCBoYXMgbWV0YWRhdGEgYXNzb2NpYXRlZCB3aXRoIGl0LCBtYWtlCj4gPiBzdXJlIHRvIHJlc2Vy dmUgdGhlIG1ldGFkYXRhIHN0b3JhZ2Ugd2hlbiBjaG9vc2luZyBhIHN1aXRhYmxlIGRlc3RpbmF0 aW9uCj4gPiBwYWdlIGZyb20gdGhlIGZyZWUgbGlzdC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBB bGV4YW5kcnUgRWxpc2VpIDxhbGV4YW5kcnUuZWxpc2VpQGFybS5jb20+Cj4gPiAtLS0KPiA+ICBt bS9jb21wYWN0aW9uLmMgfCA5ICsrKysrKysrKwo+ID4gIG1tL2ludGVybmFsLmggICB8IDEgKwo+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQg YS9tbS9jb21wYWN0aW9uLmMgYi9tbS9jb21wYWN0aW9uLmMKPiA+IGluZGV4IGNjMDEzOWZhMGNi MC4uYWYyZWUzMDg1NjIzIDEwMDY0NAo+ID4gLS0tIGEvbW0vY29tcGFjdGlvbi5jCj4gPiArKysg Yi9tbS9jb21wYWN0aW9uLmMKPiA+IEBAIC01NzAsNiArNTcwLDcgQEAgc3RhdGljIHVuc2lnbmVk IGxvbmcgaXNvbGF0ZV9mcmVlcGFnZXNfYmxvY2soc3RydWN0IGNvbXBhY3RfY29udHJvbCAqY2Ms Cj4gPiAgICAgICAgIGJvb2wgbG9ja2VkID0gZmFsc2U7Cj4gPiAgICAgICAgIHVuc2lnbmVkIGxv bmcgYmxvY2twZm4gPSAqc3RhcnRfcGZuOwo+ID4gICAgICAgICB1bnNpZ25lZCBpbnQgb3JkZXI7 Cj4gPiArICAgICAgIGludCByZXQ7Cj4gPgo+ID4gICAgICAgICAvKiBTdHJpY3QgbW9kZSBpcyBm b3IgaXNvbGF0aW9uLCBzcGVlZCBpcyBzZWNvbmRhcnkgKi8KPiA+ICAgICAgICAgaWYgKHN0cmlj dCkKPiA+IEBAIC02MjYsNiArNjI3LDExIEBAIHN0YXRpYyB1bnNpZ25lZCBsb25nIGlzb2xhdGVf ZnJlZXBhZ2VzX2Jsb2NrKHN0cnVjdCBjb21wYWN0X2NvbnRyb2wgKmNjLAo+ID4KPiA+ICAgICAg ICAgICAgICAgICAvKiBGb3VuZCBhIGZyZWUgcGFnZSwgd2lsbCBicmVhayBpdCBpbnRvIG9yZGVy LTAgcGFnZXMgKi8KPiA+ICAgICAgICAgICAgICAgICBvcmRlciA9IGJ1ZGR5X29yZGVyKHBhZ2Up Owo+ID4gKyAgICAgICAgICAgICAgIGlmIChtZXRhZGF0YV9zdG9yYWdlX2VuYWJsZWQoKSAmJiBj Yy0+cmVzZXJ2ZV9tZXRhZGF0YSkgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0g cmVzZXJ2ZV9tZXRhZGF0YV9zdG9yYWdlKHBhZ2UsIG9yZGVyLCBjYy0+Z2ZwX21hc2spOwo+IAo+ IEF0IHRoaXMgcG9pbnQgdGhlIHpvbmUgbG9jayBpcyBoZWxkIGFuZCBwcmVlbXB0aW9uIGlzIGRp c2FibGVkLCB3aGljaAo+IG1ha2VzIGl0IGludmFsaWQgdG8gY2FsbCByZXNlcnZlX21ldGFkYXRh X3N0b3JhZ2UuCgpZb3UgYXJlIGNvcnJlY3QsIEkgbWlzc2VkIHRoYXQuIEkgZHJvcHBlZCByZXNl cnZpbmcgdGFnIHN0b3JhZ2UgZHVyaW5nCmNvbXBhY3Rpb24gaW4gdGhlIG5leHQgaXRlcmF0aW9u LCBzbyBmb3J0dW5hdGVseSBJIHVuaW50ZW50aW9uYWxseSBmaXhlZAppdC4KClRoYW5rcywKQWxl eAoKPiAKPiBQZXRlcgo+IAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJldCkKPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBpc29sYXRlX2ZhaWw7Cj4gPiAr ICAgICAgICAgICAgICAgfQo+ID4gICAgICAgICAgICAgICAgIGlzb2xhdGVkID0gX19pc29sYXRl X2ZyZWVfcGFnZShwYWdlLCBvcmRlcik7Cj4gPiAgICAgICAgICAgICAgICAgaWYgKCFpc29sYXRl ZCkKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ID4gQEAgLTE3NTcsNiArMTc2 Myw5IEBAIHN0YXRpYyBzdHJ1Y3QgZm9saW8gKmNvbXBhY3Rpb25fYWxsb2Moc3RydWN0IGZvbGlv ICpzcmMsIHVuc2lnbmVkIGxvbmcgZGF0YSkKPiA+ICAgICAgICAgc3RydWN0IGNvbXBhY3RfY29u dHJvbCAqY2MgPSAoc3RydWN0IGNvbXBhY3RfY29udHJvbCAqKWRhdGE7Cj4gPiAgICAgICAgIHN0 cnVjdCBmb2xpbyAqZHN0Owo+ID4KPiA+ICsgICAgICAgaWYgKG1ldGFkYXRhX3N0b3JhZ2VfZW5h YmxlZCgpKQo+ID4gKyAgICAgICAgICAgICAgIGNjLT5yZXNlcnZlX21ldGFkYXRhID0gZm9saW9f aGFzX21ldGFkYXRhKHNyYyk7Cj4gPiArCj4gPiAgICAgICAgIGlmIChsaXN0X2VtcHR5KCZjYy0+ ZnJlZXBhZ2VzKSkgewo+ID4gICAgICAgICAgICAgICAgIGlzb2xhdGVfZnJlZXBhZ2VzKGNjKTsK PiA+Cj4gPiBkaWZmIC0tZ2l0IGEvbW0vaW50ZXJuYWwuaCBiL21tL2ludGVybmFsLmgKPiA+IGlu ZGV4IGQyOGFjMDA4NWY2MS4uMDQ2Y2MyNjRiZmJlIDEwMDY0NAo+ID4gLS0tIGEvbW0vaW50ZXJu YWwuaAo+ID4gKysrIGIvbW0vaW50ZXJuYWwuaAo+ID4gQEAgLTQ5Miw2ICs0OTIsNyBAQCBzdHJ1 Y3QgY29tcGFjdF9jb250cm9sIHsKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKi8KPiA+ICAgICAgICAgYm9vbCBhbGxvY19jb250aWc7ICAgICAgICAgICAgICAv KiBhbGxvY19jb250aWdfcmFuZ2UgYWxsb2NhdGlvbiAqLwo+ID4gICAgICAgICBib29sIHNvdXJj ZV9oYXNfbWV0YWRhdGE7ICAgICAgIC8qIHNvdXJjZSBwYWdlcyBoYXZlIGFzc29jaWF0ZWQgbWV0 YWRhdGEgKi8KPiA+ICsgICAgICAgYm9vbCByZXNlcnZlX21ldGFkYXRhOwo+ID4gIH07Cj4gPgo+ ID4gIC8qCj4gPiAtLQo+ID4gMi40MS4wCj4gPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=