From: Anthony Iliopoulos <ailiop@suse.com>
To: Srivathsa Dara <srivathsa.d.dara@oracle.com>
Cc: "mark@fasheh.com" <mark@fasheh.com>,
"jlbec@evilplan.org" <jlbec@evilplan.org>,
"joseph.qi@linux.alibaba.com" <joseph.qi@linux.alibaba.com>,
Rajesh Sivaramasubramaniom
<rajesh.sivaramasubramaniom@oracle.com>,
Junxiao Bi <junxiao.bi@oracle.com>,
"ocfs2-devel@lists.linux.dev" <ocfs2-devel@lists.linux.dev>,
Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com>
Subject: Re: [PATCH] ocfs2: call ocfs2_abort when journal abort
Date: Tue, 21 Nov 2023 13:39:26 +0100 [thread overview]
Message-ID: <ZVyk/v4YRCEMOcrY@technoir> (raw)
In-Reply-To: <DM6PR10MB4347E075A7DADE3FEA97707BA0BBA@DM6PR10MB4347.namprd10.prod.outlook.com>
On Tue, Nov 21, 2023 at 12:19:03PM +0000, Srivathsa Dara wrote:
> [Srivathsa]: Isn't it a bad idea to leave the filesystem like a way it is
> with a journal error. Because journal is not working as expected, we
> might run into some trouble in future.
The journal being in an aborted state is part of the expected design. It
implies that the filesystem accordingly should be in read-only state.
Anything else is a bug, and you'd have to be much more specific which
exact bug you're trying to address. Resorting to panic is simply
obscuring any potential issues that may actually need fixing.
> [Srivathsa]: Switching to read-only and self fencing affect
> performance in production systems.
How so? Again, please elaborate with specific technical details.
Regards,
Anthony
next prev parent reply other threads:[~2023-11-21 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 12:00 [PATCH] ocfs2: call ocfs2_abort when journal abort Srivathsa Dara
2023-10-31 23:23 ` Anthony Iliopoulos
2023-11-09 19:26 ` Srivathsa Dara
2023-11-09 23:58 ` Anthony Iliopoulos
2023-11-21 12:19 ` Srivathsa Dara
2023-11-21 12:39 ` Anthony Iliopoulos [this message]
2023-11-01 1:13 ` Joseph Qi
2023-11-01 2:42 ` Heming Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVyk/v4YRCEMOcrY@technoir \
--to=ailiop@suse.com \
--cc=gautham.ananthakrishna@oracle.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=junxiao.bi@oracle.com \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=srivathsa.d.dara@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.