From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:b00f:b0:9d0:bf65:29fa with SMTP id v15csp527942ejy; Tue, 21 Nov 2023 06:57:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWMpwoTa2D3BbjBU4AEl9DSaNv/3PE/gYnybKBC5sD8UlX3JxXDpnDAddn1JAfBkN7RmKM X-Received: by 2002:a05:620a:3c10:b0:778:969e:3a0c with SMTP id tn16-20020a05620a3c1000b00778969e3a0cmr3685697qkn.27.1700578639690; Tue, 21 Nov 2023 06:57:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700578639; cv=none; d=google.com; s=arc-20160816; b=RjRFz+/7bp0ZpLaJnF+9e9HdX70IYecQCfnx4FiP2uPFSxDG9uYcvmmt6VVPjgZbv3 FoJPxd06FA7/a6XMknhDN6QcL5I342Ng4C61dK7etSGnsZmQ/fspro6cxWEvU6jIhNbp SIaBIFc3+x1Po1S0JvXmRQJ6C01nPMTvLpaVgePOx7tkWn3zktVAhekRRFIOh5jO3whw Cl5vUseetpWjx2I2ZFsjZo6RonK1GArLOW/JdpgsCbJkf8hvPUwEghBwj2xb8EYltSnA XLj08Z4RJTPV/vrzI7okSBzSTlrkn9Lr61/aTYyz230eIGLUDnXWESNhBWS8UxCxXWk6 nSgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q1tol34Cz9PAtyxmhj5j92MDJbcFqe96Y+qbUd3Cbrc=; fh=CsdiWNFHKpDi85bv+LYNHOHQERFxFhU1c1y9HbqB3eA=; b=vSnDfyi0BozI0x5LhR+/gGFL+Lgt/4pCFErSt8cpdStyk/ibphixFFr1BlMtHiNe9z t43Y0thU+hZPAm4fvaLheOiOY1TG4PNJDi32FYuZGv9+7+ko9gnU5jxJqSg5bYW/Sw6/ uyGKupBbmJDv+38ZQgIflbpd5LFBCw31BzA8dZxYuUHMPU6HSY/sLHf18XV2Z3XCwJcc EpF6Zz/A5DZ3LGE2lmh14e8XPO8RY8Wx6CmM5xyXU9uZUHbfZLT0WWFHo+cn4iKJr+Ea 9Yt2M1Tq/iqolewmZ/YpGTN2ms4ZcZcRr+95++AYi9F++70S4SyIHyYiKL/sTjoC/xEO ebJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GAGkxwDr; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n3-20020a05620a294300b007757beeb5acsi11621698qkp.445.2023.11.21.06.57.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Nov 2023 06:57:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GAGkxwDr; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5SBL-0002VX-6I; Tue, 21 Nov 2023 09:56:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5SBJ-0002Qv-Ot for qemu-devel@nongnu.org; Tue, 21 Nov 2023 09:56:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5SB4-0003NQ-GO for qemu-devel@nongnu.org; Tue, 21 Nov 2023 09:56:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700578597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q1tol34Cz9PAtyxmhj5j92MDJbcFqe96Y+qbUd3Cbrc=; b=GAGkxwDrMkb/Y85acNCvyspYEdisZXyqxgMUyS86phXp9YbbHDBwnXmgjQP8t7F5sTv5JA TKBI450Uv4vEy8kRwKYoqtIZvnPxFVgUYsZSjYMo2hzvqNmGK9yHJlsSfFho2BmJChxjS7 xb9S38tchjyiumg7gwMeV4JcnUTkGQw= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-zwJ2pumVN-ioMVVWfqEmqg-1; Tue, 21 Nov 2023 09:56:35 -0500 X-MC-Unique: zwJ2pumVN-ioMVVWfqEmqg-1 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-7bdcb82e66bso507610241.1 for ; Tue, 21 Nov 2023 06:56:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700578595; x=1701183395; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q1tol34Cz9PAtyxmhj5j92MDJbcFqe96Y+qbUd3Cbrc=; b=Gv0M7Kw2sLuB3nS9TKvvyOpJgW1h5NMg1OmVRfE0oMSZ8U3PKmLeeSNO2Y4/gz+uOe wVZUlxDWfkT7V8sPUPLJxeR1CnDzAbyI+DryMiCn7X6qEvFR8BObvmknvxzHc5JMM/1H ppIaTlIb5UfLhEvCfrk70qHJ2U9ZHIkUU3P+fuNMdC/xDT1dbO69qusqnqvBUEoh6xl8 LReGqrIQSBS1SAU5Liy4zUOBZoVmwDiepewOCwBLWSyhm7kmDVs5c5ptWG0R4GDEi8VU S+lMuxV2H8Nu563BP066evTbItoU5dxSWoHrNIKGzNK1gfoVfNsxlJ0PywLVbiNx2ysW fyfQ== X-Gm-Message-State: AOJu0Yyaan/5M3FkqbPYIQAZvwBwGL2oV1SvQJmE5X5SAhplvuINGlKN EPxiBv6mFJksEdlWQ41yLQWs0UjEIuOvxqrJ1/xsXisaZjUpyVmcciwRKm1ukyFRXJsLhpEvMz2 JA2rxiUca8fDLSBg= X-Received: by 2002:a05:6102:2c4:b0:462:ba47:96ba with SMTP id h4-20020a05610202c400b00462ba4796bamr729216vsh.0.1700578594823; Tue, 21 Nov 2023 06:56:34 -0800 (PST) X-Received: by 2002:a05:6102:2c4:b0:462:ba47:96ba with SMTP id h4-20020a05610202c400b00462ba4796bamr729173vsh.0.1700578594241; Tue, 21 Nov 2023 06:56:34 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id bn44-20020a05620a2aec00b007758b25ac3bsm3673657qkb.82.2023.11.21.06.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 06:56:33 -0800 (PST) Date: Tue, 21 Nov 2023 09:56:31 -0500 From: Peter Xu To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, David Hildenbrand , Peter Maydell , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Mark Cave-Ayland , Markus Armbruster , Paolo Bonzini , Igor Mammedov , qemu-ppc@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH-for-9.0 01/25] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean Message-ID: References: <20231120213301.24349-1-philmd@linaro.org> <20231120213301.24349-2-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231120213301.24349-2-philmd@linaro.org> Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: ZufmIDnjf4m0 On Mon, Nov 20, 2023 at 10:32:35PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() s/cpu_exec_realizefn/memory_region_init_ram_nomigrate/ Similar issue for initial 3 patches (or just not call out the function name). > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe Mathieu-Daudé Other than that: Reviewed-by: Peter Xu -- Peter Xu