From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A99BC61D90 for ; Tue, 21 Nov 2023 16:00:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ElJWlHaH; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CrAFxo+y; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SZTcT4zvpz3dJb for ; Wed, 22 Nov 2023 03:00:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ElJWlHaH; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CrAFxo+y; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SZTbP1CvKz3c82 for ; Wed, 22 Nov 2023 02:59:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700582380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JLQMSJj5cT+I2UqS+X9OetiKtxPgKmgg9Mky3rgL5p8=; b=ElJWlHaHuSZy71M7B3dOQp8J/2OzWUhKuFd8uKuMe8cujuldou89HalsmJdmj4TLGCuZNm BPjf4A3MspR6oe8b7koLqdrzIbMjiGtkLzsAlk3WWZABSntPrnsbxbUj6JICU+TgwhwMfu 4iVkQeoDOPNnX3OQXhFgZWSg2kNrAvE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700582381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JLQMSJj5cT+I2UqS+X9OetiKtxPgKmgg9Mky3rgL5p8=; b=CrAFxo+ydw8C6CbTxUbBIaihHmYR6ig8k/MtfOpRtrd0RljEr+Ya2KItvfoyWQHbsGdFtN h2noGDl4792ZLDm2wOTIapJbDdaB7q9k1gDawGnwsUJY0g1HMu2vLOKe0bGvy8PMMPFRSu 2THHOi/MDiY/3nxa2HMeRhO6qNkJ++A= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-rbsngHtjMVWkpo5o_HBmIg-1; Tue, 21 Nov 2023 10:59:39 -0500 X-MC-Unique: rbsngHtjMVWkpo5o_HBmIg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6716c2696c7so15014376d6.1 for ; Tue, 21 Nov 2023 07:59:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700582379; x=1701187179; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JLQMSJj5cT+I2UqS+X9OetiKtxPgKmgg9Mky3rgL5p8=; b=NmyYBxUdgQItJRF6Sy4eNfVv6FE/N+paaWzm88cXlkVxYB+U03svv2gnKVDMiDMNhl 3GYB9cdkSULnQ4mcxvMmYgjARi9i/R9y/WoW6Z5xVHSh+eHsmP3FA7te0dB7sTiLSQhv exYACrrg4umseWbdH/r78tvl8hc1OYPsAEwsVoQE9LqLIJKVdsqXcMFnkZNd8FzzGVBG yRqWMxR/cifWFcTbELAjUzq4y/qewVzN5Ar/2tpruFINtrwjmGp8qMxA05fY72tJkfU0 Ej2ij1g3cSo1Wp0+MsDVxF8zfDr+dwpnJZMaqj93GJ0+EPdiVmDDxgEANGJXgHQInZxU zWJA== X-Gm-Message-State: AOJu0YyzYAj5lXMyPYEca008yxxSrfW3Gs58FohSjwq6jhkx4gQakDDE DQfbkH2ArQF0UG8lYqe3hwPz3/ex/7hi2/WX++jtXE4swFzUjC6jjSo9Io8q5yOOufvApemdE6/ DT+OV6SBwW4a6t0rZIluTlkHurQ== X-Received: by 2002:a0c:c582:0:b0:66d:1012:c16a with SMTP id a2-20020a0cc582000000b0066d1012c16amr10534479qvj.1.1700582378974; Tue, 21 Nov 2023 07:59:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9jPSayCUuCFnqS3WxavS9ST6O5WwQE1cldTJjdWqW9XI/Aaj5okJ+Mn7wuuqXunOLRSa0AQ== X-Received: by 2002:a0c:c582:0:b0:66d:1012:c16a with SMTP id a2-20020a0cc582000000b0066d1012c16amr10534438qvj.1.1700582378610; Tue, 21 Nov 2023 07:59:38 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id a12-20020a0562140c2c00b00679d9547310sm2051153qvd.31.2023.11.21.07.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 07:59:38 -0800 (PST) Date: Tue, 21 Nov 2023 10:59:35 -0500 From: Peter Xu To: Christoph Hellwig Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, Mike Rapoport , Jason Gunthorpe , "Kirill A . Shutemov" , Axel Rasmussen , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Vlastimil Babka , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Nov 20, 2023 at 12:26:24AM -0800, Christoph Hellwig wrote: > On Wed, Nov 15, 2023 at 08:29:02PM -0500, Peter Xu wrote: > > Hugepd format is only used in PowerPC with hugetlbfs. In commit > > a6e79df92e4a ("mm/gup: disallow FOLL_LONGTERM GUP-fast writing to > > file-backed mappings"), we added a check to fail gup-fast if there's > > potential risk of violating GUP over writeback file systems. That should > > never apply to hugepd. > > > > Drop that check, not only because it'll never be true for hugepd, but also > > it paves way for reusing the function outside fast-gup. > > What prevents us from ever using hugepd with file mappings? I think > it would naturally fit in with how large folios for the pagecache work. > > So keeping this check and generalizing it seems like the better idea to > me. But then it means we're still keeping that dead code for fast-gup even if we know that fact.. Or do we have a plan to add that support very soon, so this code will be destined to add back? The other option is I can always add a comment above gup_huge_pd() explaining this special bit, so that when someone is adding hugepd support to file large folios we'll hopefully not forget it? But then that generalization work will only happen when the code will be needed. Thanks, -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11832C61D85 for ; Tue, 21 Nov 2023 15:59:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B6F96B049C; Tue, 21 Nov 2023 10:59:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 968036B049E; Tue, 21 Nov 2023 10:59:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82F176B049F; Tue, 21 Nov 2023 10:59:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70EFC6B049C for ; Tue, 21 Nov 2023 10:59:44 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 21B7EC09A3 for ; Tue, 21 Nov 2023 15:59:44 +0000 (UTC) X-FDA: 81482421888.20.845D9B0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id DCF7340010 for ; Tue, 21 Nov 2023 15:59:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CrAFxo+y; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700582382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JLQMSJj5cT+I2UqS+X9OetiKtxPgKmgg9Mky3rgL5p8=; b=zmg4SFhqHLF0ianfodV10UlKqxkX16hmgcBppGqn0nNqp/F9QGW/jyjxXWk6AP7Pzzjv8B kUeBR6V5Y2oY2HmpUb37OkrQul7qM/EWOYs/R1i7Ej9X2JU6EYFbBuh4uYb53VIKL8Xyw9 AG00DfkzHO0Pmo5Cf5z1wHLIPsCUbcQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CrAFxo+y; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700582382; a=rsa-sha256; cv=none; b=qnRQ9piI9qQsrWgpmb/5r0YYwJn5iulBNHRg8Rv+bQpuCF2rAY4E0s8SK7KL60ZkTz7N/q oA72cBTPYmkAR7yxYd7Js3PXhrAAITSGg7lSvH8Mi8W0dZq+gv4rU4D/+Tbmq8Iu0D+KCL x1n/Mx/Pk8gYp7yKYH25v3Fi2q1y+38= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700582381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JLQMSJj5cT+I2UqS+X9OetiKtxPgKmgg9Mky3rgL5p8=; b=CrAFxo+ydw8C6CbTxUbBIaihHmYR6ig8k/MtfOpRtrd0RljEr+Ya2KItvfoyWQHbsGdFtN h2noGDl4792ZLDm2wOTIapJbDdaB7q9k1gDawGnwsUJY0g1HMu2vLOKe0bGvy8PMMPFRSu 2THHOi/MDiY/3nxa2HMeRhO6qNkJ++A= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-x1_iU2HqP82ZF5xBJ4wwyQ-1; Tue, 21 Nov 2023 10:59:39 -0500 X-MC-Unique: x1_iU2HqP82ZF5xBJ4wwyQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-678b8124ed4so7114156d6.0 for ; Tue, 21 Nov 2023 07:59:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700582379; x=1701187179; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JLQMSJj5cT+I2UqS+X9OetiKtxPgKmgg9Mky3rgL5p8=; b=k8x7YF8NmNKtrsGRrpebgsa4ywzWySmseCihCqTgIJkmN2WfcKaDe3HsjPWkOsGBjd g3pkQuPPUt6bbk2nRTvedqLd0yss7K+/sn6cNUZTS0o6nevO239oZWd2dJBGd6oqnhD/ 10GqRnUEidjOzuTeHWlkUkfzfnH0klWbZxu/QQobbJyg7Km7KU/G5Xlisoh8eOY59gnN rkp/DrkBVjhJSAfYWiTkn4di7z1tt2Q9Haa0JxtVSx8JE4Ah0dGLCewsI0g/fCLbGsV5 JMrMTwSX4sEDBkK2RkGte7W9lKfJT2kL4ndZLTX6rWnsarakBoeJvTwzVi1uzPWYNdIJ R0AA== X-Gm-Message-State: AOJu0YyAioEGkZeSijR+eNHAsnBlGBg/K2n0XqUg6O7YB+rqMa3uUf6W om5JgPLn2D13e0XJHbC1KBrYawlsZ5yNuwQjTIWv9lbz8iLs+zoVJaJsPyDFcaV+jPfqAZD3ukt crPY2VqV5MV0= X-Received: by 2002:a0c:c582:0:b0:66d:1012:c16a with SMTP id a2-20020a0cc582000000b0066d1012c16amr10534458qvj.1.1700582378836; Tue, 21 Nov 2023 07:59:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9jPSayCUuCFnqS3WxavS9ST6O5WwQE1cldTJjdWqW9XI/Aaj5okJ+Mn7wuuqXunOLRSa0AQ== X-Received: by 2002:a0c:c582:0:b0:66d:1012:c16a with SMTP id a2-20020a0cc582000000b0066d1012c16amr10534438qvj.1.1700582378610; Tue, 21 Nov 2023 07:59:38 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id a12-20020a0562140c2c00b00679d9547310sm2051153qvd.31.2023.11.21.07.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 07:59:38 -0800 (PST) Date: Tue, 21 Nov 2023 10:59:35 -0500 From: Peter Xu To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: DCF7340010 X-Rspam-User: X-Stat-Signature: txo4ybwtx5t9njqrmg51hmhjyaz4p8e8 X-Rspamd-Server: rspam01 X-HE-Tag: 1700582381-216854 X-HE-Meta: U2FsdGVkX1/2184/el05uJogCcDgu8edo2lcIFIju22m1u+ETR241x3IAvGdtK5jo8L1gi4C28KpeDS0Uihf9CfvFcQC4y+ueAue5DVoo0wQBhtLKMt+DPxThCaS38YNLGIDfRoBwG22jVJRIeRpLtZo1QGU5aSu2tUOouexi/Akyy9qihDHBXMIdV1OvXVR/JQ6rgbtxRbxXT3zFhyRFUOu9TRay5CQBETUjkcB2Dw+Gr1QBEC02AGHpeloT3ScEtjsYYJ7Dqkd/8ebNXhgFwxmG4WxVYBcaGsHZu+KP8n6P55zX2kPFFvRCZo4hIcCuSysBQAWe3QAqmIh30XvnQPotnBe2e7S564Cp44c2jB7rkhmulFq2NAfKunBW9+iF9TVzWAdt6CjBR3G3E+OSonqUrlbP7Xvy8wSKK//9JXM8nsoeuVSqS2uCaOWLkpmahiZYLDfmLtcLIbcINkkKklzBvrPQgwmIkMZxQ77bTXxPK71jpSJnBgUYGYOZ70/V0NhBrw2RGwWuGSy5OTpx3RthdLFg2t41iHEB/sltjqzFwjuzExBK0YqxBjdHm66vbN9limf8Fa0QjWTMJ4GAuEVhlnB4QgOke/fq6HtBwOrqqE7HhfFVnCkyNRst53f94SymxKpASOnRsLFNf1MTlOOy/ng75n6R8yHI5B1vv+836RWxcscOt7W3zi9/Frsq1W9fIHd3nSfd7WHVmJlgJ1qNiEIOhbV1BdjPrDHNEuTpsPjPPbaUO4N9Ws1ZN0tANkALQG5azaqLtd4+mMaDNlPyHs1z7t6sABjW6Xwh5rFgOIB9fosjIkhoeqLEETWDCcZCfTGyu5xC4Xb0p4U8+wI3jgAOeNl6ce89NK0H6oQWHXiQecfmrxnjqvX21wBGgzZ7L+5U2vyzI10Vta795PQ+15w/+pAik2rlp4cqcQNGtUEeUbI+YUoeRH9P3zIvHc3nFQ6wztdTXE9XpF 523gXuTc EtX0eXRqBbgeTKeiWLhWYvu3u3zU3O6C2kQNW7NAFppcaOWNTksKMcgAHKGVT9sh6YaPP3yQLB6k9S5UD+qfQ7ajdqlKn1+tC9Y5+aqeZZm5cwdK7P6O0jlU5KTWBe5BFuTBlsO4vK+ZEKsFSgmuiwGhHomTK4BW17XaqtmBMl6V53VA4YLXVqgodDOcVMfrCydhQoJ3dB62r/jvZLeVZBINJkDG3dD92oZgGB4m40KQ81O0ck27qQg8c5A8AvDgpoalwVWufb3E/wW4SzenbJ0qJ5IP0lccgO5i1TliO/BBkkiaVf/Lzs4ujZxurodNd2d42laVsdEPaDgGCHk/T0hNVOixh7PJsp7ibcSa7FnUj1ZiTmKWrS+wQ9gR/CuMMJleNpgAArLNqfQRTGwjB4M20crOfDIJrseLb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 12:26:24AM -0800, Christoph Hellwig wrote: > On Wed, Nov 15, 2023 at 08:29:02PM -0500, Peter Xu wrote: > > Hugepd format is only used in PowerPC with hugetlbfs. In commit > > a6e79df92e4a ("mm/gup: disallow FOLL_LONGTERM GUP-fast writing to > > file-backed mappings"), we added a check to fail gup-fast if there's > > potential risk of violating GUP over writeback file systems. That should > > never apply to hugepd. > > > > Drop that check, not only because it'll never be true for hugepd, but also > > it paves way for reusing the function outside fast-gup. > > What prevents us from ever using hugepd with file mappings? I think > it would naturally fit in with how large folios for the pagecache work. > > So keeping this check and generalizing it seems like the better idea to > me. But then it means we're still keeping that dead code for fast-gup even if we know that fact.. Or do we have a plan to add that support very soon, so this code will be destined to add back? The other option is I can always add a comment above gup_huge_pd() explaining this special bit, so that when someone is adding hugepd support to file large folios we'll hopefully not forget it? But then that generalization work will only happen when the code will be needed. Thanks, -- Peter Xu