Re: [PATCH] ALSA: hda/realtek: add new framework to quirk chain

[Geraldo Nascimento <geraldogabriel@gmail.com>]

On Tue, Dec 05, 2023 at 06:42:00PM -0500, Tim Bosse wrote:
> The Framework Laptop 13 (AMD Ryzen 7040Series) has an ALC 295 with
> a disconnected or faulty headset mic presence detect and works with the
> same quirk chain as 309d7363ca3d9fcdb92ff2d958be14d7e8707f68. This model
> has a VID:PID of f111:0006.
> 
> Signed-off-by: Tim Bosse <flinn@timbos.se>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f9ddacfd920e..59f2578839ed 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10271,6 +10271,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10),
>  	SND_PCI_QUIRK(0x8086, 0x3038, "Intel NUC 13", ALC295_FIXUP_CHROME_BOOK),
>  	SND_PCI_QUIRK(0xf111, 0x0001, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
> +	SND_PCI_QUIRK(0xf111, 0x0006, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
>  
>  #if 0
>  	/* Below is a quirk table taken from the old code.
> -- 
> 2.43.0

Hi Tim, you forgot to add at least Takashi to the Cc: and your patch
will most likely be missed, so putting him in the loop.

Also, not much to say here since it's a simple desirable fix but would
you mind sending v2 with a rewording of the commit info? The way you put
it sounds like a new framework is being added to the realtek quirk
chain, which is not the case, you're adding a new Framework-brand laptop
to the quirks.

Thank you,
Geraldo Nascimento