All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Llamas <cmllamas@google.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	"Christian Brauner" <christian@brauner.io>,
	"Suren Baghdasaryan" <surenb@google.com>
Subject: Re: [PATCH] android: binder: fix a kernel-doc enum warning
Date: Tue, 5 Dec 2023 23:15:48 +0000	[thread overview]
Message-ID: <ZW-vJGvhQY6oftiJ@google.com> (raw)
In-Reply-To: <20231205225324.32362-1-rdunlap@infradead.org>

On Tue, Dec 05, 2023 at 02:53:18PM -0800, Randy Dunlap wrote:
> Add kernel-doc notation for @LOOP_END to prevent a kernel-doc
> warning.
> 
> binder_alloc_selftest.c:76: warning: Enum value 'LOOP_END' not described in enum 'buf_end_align_type'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arve Hjønnevåg <arve@android.com>
> Cc: Todd Kjos <tkjos@android.com>
> Cc: Martijn Coenen <maco@android.com>
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Cc: Christian Brauner <christian@brauner.io>
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: Suren Baghdasaryan <surenb@google.com>
> ---
>  drivers/android/binder_alloc_selftest.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff -- a/drivers/android/binder_alloc_selftest.c b/drivers/android/binder_alloc_selftest.c
> --- a/drivers/android/binder_alloc_selftest.c
> +++ b/drivers/android/binder_alloc_selftest.c
> @@ -72,6 +72,10 @@ enum buf_end_align_type {
>  	 * buf1 ]|[ buf2 | buf2 | buf2 ][ ...
>  	 */
>  	NEXT_NEXT_UNALIGNED,
> +	/**
> +	 * @LOOP_END: The number of enum values in &buf_end_align_type.
> +	 * It is used for controlling loop termination.
> +	 */
>  	LOOP_END,
>  };
>  

'LOOP_END' seems self explanatory to me but if this helps to clear the
warning then why not. Thanks Randy!

Acked-by: Carlos Llamas <cmllamas@google.com>

      reply	other threads:[~2023-12-05 23:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 22:53 [PATCH] android: binder: fix a kernel-doc enum warning Randy Dunlap
2023-12-05 23:15 ` Carlos Llamas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZW-vJGvhQY6oftiJ@google.com \
    --to=cmllamas@google.com \
    --cc=arve@android.com \
    --cc=christian@brauner.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=rdunlap@infradead.org \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.