From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Fku5W+sM" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8784E95; Mon, 4 Dec 2023 08:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705754; x=1733241754; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=XNcK+nowG13Y865Fjff3FDTvFJmZG2WRC888K2sx/o0=; b=Fku5W+sMy8iBM7D/n3hL378vSuVSR9c8WlUhlqIiZNy3LaGTV7fvhcOV 3LolxtdbOJYDqNYEAUrtXRH85kHMnano9qphTB3bWbTkqtGIH1VqeD6De 928YwY0NI5+YLVco2aOh/ndKJRxJ57f60VH06ABXfB2xB1LBIGWIb1ptS my7LPHYO30rIvaKRNCjGfGxRC5NQ697/vMkhpWng1fZ/9OlgP6QusW1tJ 79dfGAL+MKGY78perCo99yrbJz2SIO0jsw7EPAmyH/6S/zu/1aAlgQ5ly TTYWRGuU941147mBZATQvvU7teMm13qy4JkJF9wzohVuX17ULC4xKWJIL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="631786" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="631786" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:02:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="861419788" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="861419788" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:02:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rABOl-00000001nOJ-2TZj; Mon, 04 Dec 2023 18:02:19 +0200 Date: Mon, 4 Dec 2023 18:02:19 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Marek Szyprowski , Linus Walleij , Bartosz Golaszewski , Rasmus Villemoes , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Krzysztof Kozlowski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Biju Das , Claudiu Beznea , Jianlong Huang , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ray Jui , Scott Branden , Broadcom internal kernel review list , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Paul Cercueil , Lakshmi Sowjanya D , Bjorn Andersson , Andy Gross , Konrad Dybcio , Emil Renner Berthing , Hal Feng , Krzysztof Kozlowski Subject: Re: [PATCH v4 12/23] pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC() Message-ID: References: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com> <20231129161459.1002323-13-andriy.shevchenko@linux.intel.com> <9e4e65de-7234-4234-8091-796277a1f1c5@samsung.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Dec 04, 2023 at 02:39:37PM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 4, 2023 at 2:32 PM Andy Shevchenko > wrote: > > On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko > > > wrote: > > > > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > > > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > > > > > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > > > > to (struct group_desc), what breaks users of the above macros. > > > > > > > > There is no cast (*). > > > > Thanks for report, I will check. > > > > > > > > But this was v4 of the series and LKP actually sent a positive feedback. > > > > Besides that I have tested this locally with modules enabled. > > > > > > > > *) It's a compound literal, _not_ a cast. > > > > Taking above into consideration I'm wondering what compilers > > > > are in use? > > > > > > kisskb reported the following m68k failures to me: > > > linux-next/m68k-allmodconfig/m68k-gcc8 > > > linux-next/m68k-allmodconfig/m68k-gcc11 > > > linux-next/m68k-allmodconfig/m68k-gcc12 > > > > > > However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 > > > did succeed, so I guess you are using gcc13? > > > > Yes, I compiled with these: > > > > $ gcc --version > > gcc (Debian 13.2.0-5) 13.2.0 > > Time to install and try an older version ;-) Yeah, compound literals seems the often-to-break topic (as per GCC bugzilla). Tried with GCC 8 for ARM64 and indeed it doesn't build it well. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AE95C4167B for ; Mon, 4 Dec 2023 16:03:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OAYC/0hhsYhJmzkMq3O/lfSj2LJSbzoBrE8ZwPoc3F8=; b=o9hNXWCQobOtpT fr0IdMD83Y7w5AJxj04SzPKpi2xZ7dAguLmIZiEraygBynJjsnF3rq5yTgWLnuv5j63OJGXbMjSq5 EXePzwCWiJ490CpZCaY6z6p5nior/jJJB+kKjom6gjTy8pDrSIXDTnRamXu9Ewez3VifnP16bb7It /Yj5L/LF0BAicB+9oAuN0VmjzkdDma+X67vWYVJo4imqLqG6R+lWgJP5Nd9flrxmC8/sZ6nbe/I9p 6JCCXv12IbKtNXcOSs4FLdi9wWYAZ8xg8qqrJidv09NgSjO4DP8jRws8vnMkl2dhaGW5+8ikSUxZJ 0mUA/7xnm8dBwwSJMtcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rABP5-0052Tb-0k; Mon, 04 Dec 2023 16:02:39 +0000 Received: from mgamail.intel.com ([198.175.65.11]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rABP2-0052SY-0A; Mon, 04 Dec 2023 16:02:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705756; x=1733241756; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=XNcK+nowG13Y865Fjff3FDTvFJmZG2WRC888K2sx/o0=; b=ltQ4D38h8jwNXqAMVcMr9BQcYUc8fA4XMXzYKoYYWE9eb119decIE1rZ t0a2E2Q2jH88VaysGN6nLBwqIyJiMNoJo15mDXTzNmE2MQssJTNdDnZb3 tIQnwH81EzqGm9tlLwWxZWUleGdd2Ke2cmpLh0L31e2HSLuvQJ9Zf2Cu+ fucOYB3mmcQdorcboCOZeEmfdieSV1GLz4KJL0BKe9y/oHngMQFvb4pxY 0vvqqfsb+g9ORTczq06BCZqxgQQ2QmxZ1OfBQz9mbzbaLvt/0S2n6cNBn 7KPmRwwce3zVxZgazeTD4gIS9Rdq5lRcGtHX0Yot0gxsHHg3bUCva4oiA A==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="631788" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="631788" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:02:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="861419788" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="861419788" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:02:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rABOl-00000001nOJ-2TZj; Mon, 04 Dec 2023 18:02:19 +0200 Date: Mon, 4 Dec 2023 18:02:19 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Marek Szyprowski , Linus Walleij , Bartosz Golaszewski , Rasmus Villemoes , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Krzysztof Kozlowski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Biju Das , Claudiu Beznea , Jianlong Huang , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ray Jui , Scott Branden , Broadcom internal kernel review list , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Paul Cercueil , Lakshmi Sowjanya D , Bjorn Andersson , Andy Gross , Konrad Dybcio , Emil Renner Berthing , Hal Feng , Krzysztof Kozlowski Subject: Re: [PATCH v4 12/23] pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC() Message-ID: References: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com> <20231129161459.1002323-13-andriy.shevchenko@linux.intel.com> <9e4e65de-7234-4234-8091-796277a1f1c5@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_080236_611177_A0DC3808 X-CRM114-Status: GOOD ( 23.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgMDQsIDIwMjMgYXQgMDI6Mzk6MzdQTSArMDEwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IE9uIE1vbiwgRGVjIDQsIDIwMjMgYXQgMjozMuKAr1BNIEFuZHkgU2hldmNo ZW5rbwo+IDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24g TW9uLCBEZWMgMDQsIDIwMjMgYXQgMDI6MTk6MTBQTSArMDEwMCwgR2VlcnQgVXl0dGVyaG9ldmVu IHdyb3RlOgo+ID4gPiBPbiBNb24sIERlYyA0LCAyMDIzIGF0IDI6MTDigK9QTSBBbmR5IFNoZXZj aGVua28KPiA+ID4gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4g PiA+ID4gT24gTW9uLCBEZWMgMDQsIDIwMjMgYXQgMTI6NDA6MzhQTSArMDEwMCwgTWFyZWsgU3p5 cHJvd3NraSB3cm90ZToKPiA+ID4gPiA+IE9uIDI5LjExLjIwMjMgMTc6MDYsIEFuZHkgU2hldmNo ZW5rbyB3cm90ZToKPiA+ID4gPiA+ID4gTWFrZSB1c2Ugb2YgUElOQ1RSTF9HUk9VUF9ERVNDKCkg aW5zdGVhZCBvZiBvcGVuIGNvZGluZyBpdC4KPiA+ID4gPgo+ID4gPiA+ID4gUElOQ1RSTF9HUk9V UF9ERVNDKCkgbWFjcm8gZnJvbSBkcml2ZXJzL3BpbmN0cmwvY29yZS5oIGNvbnRhaW5zIGEgY2Fz dAo+ID4gPiA+ID4gdG8gKHN0cnVjdCBncm91cF9kZXNjKSwgd2hhdCBicmVha3MgdXNlcnMgb2Yg dGhlIGFib3ZlIG1hY3Jvcy4KPiA+ID4gPgo+ID4gPiA+IFRoZXJlIGlzIG5vIGNhc3QgKCopLgo+ ID4gPiA+IFRoYW5rcyBmb3IgcmVwb3J0LCBJIHdpbGwgY2hlY2suCj4gPiA+ID4KPiA+ID4gPiBC dXQgdGhpcyB3YXMgdjQgb2YgdGhlIHNlcmllcyBhbmQgTEtQIGFjdHVhbGx5IHNlbnQgYSBwb3Np dGl2ZSBmZWVkYmFjay4KPiA+ID4gPiBCZXNpZGVzIHRoYXQgSSBoYXZlIHRlc3RlZCB0aGlzIGxv Y2FsbHkgd2l0aCBtb2R1bGVzIGVuYWJsZWQuCj4gPiA+ID4KPiA+ID4gPiAqKSBJdCdzIGEgY29t cG91bmQgbGl0ZXJhbCwgX25vdF8gYSBjYXN0Lgo+ID4gPiA+ICAgIFRha2luZyBhYm92ZSBpbnRv IGNvbnNpZGVyYXRpb24gSSdtIHdvbmRlcmluZyB3aGF0IGNvbXBpbGVycwo+ID4gPiA+ICAgIGFy ZSBpbiB1c2U/Cj4gPiA+Cj4gPiA+IGtpc3NrYiByZXBvcnRlZCB0aGUgZm9sbG93aW5nIG02OGsg ZmFpbHVyZXMgdG8gbWU6Cj4gPiA+ICAgICBsaW51eC1uZXh0L202OGstYWxsbW9kY29uZmlnL202 OGstZ2NjOAo+ID4gPiAgICAgbGludXgtbmV4dC9tNjhrLWFsbG1vZGNvbmZpZy9tNjhrLWdjYzEx Cj4gPiA+ICAgICBsaW51eC1uZXh0L202OGstYWxsbW9kY29uZmlnL202OGstZ2NjMTIKPiA+ID4K PiA+ID4gSG93ZXZlciwgYWNjb3JkaW5nIHRvIFsxXSwgbGludXgtbmV4dC9tNjhrLWFsbG1vZGNv bmZpZy9tNjhrLWdjYzEzCj4gPiA+IGRpZCBzdWNjZWVkLCBzbyBJIGd1ZXNzIHlvdSBhcmUgdXNp bmcgZ2NjMTM/Cj4gPgo+ID4gWWVzLCBJIGNvbXBpbGVkIHdpdGggdGhlc2U6Cj4gPgo+ID4gJCBn Y2MgLS12ZXJzaW9uCj4gPiBnY2MgKERlYmlhbiAxMy4yLjAtNSkgMTMuMi4wCj4gCj4gVGltZSB0 byBpbnN0YWxsIGFuZCB0cnkgYW4gb2xkZXIgdmVyc2lvbiA7LSkKClllYWgsIGNvbXBvdW5kIGxp dGVyYWxzIHNlZW1zIHRoZSBvZnRlbi10by1icmVhayB0b3BpYyAoYXMgcGVyIEdDQyBidWd6aWxs YSkuClRyaWVkIHdpdGggR0NDIDggZm9yIEFSTTY0IGFuZCBpbmRlZWQgaXQgZG9lc24ndCBidWls ZCBpdCB3ZWxsLgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=