From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F75FC4167B for ; Mon, 4 Dec 2023 13:54:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3498E83E; Mon, 4 Dec 2023 14:54:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3498E83E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701698061; bh=esHuCLsnYzWLmm5Oa6L+Kmza70Ps3RCO18AT+iUJYoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=fKijj2U1nwQWm/3IpLwQjShwLSxCZdrwIFUVVcf8LLUfvin708fWz7laQv4nC8H0l gfEkL3mjuoDgOVnF2XBykKEcf/MIPqPsb8v6POFgCOfffaerqNFYPRf8F8Wpr+sCXE YAVtpOTbI4Gn2Iacy8G6AwDqcGb9deu21yWRw1u8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id DD421F805BA; Mon, 4 Dec 2023 14:53:32 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 32688F805AC; Mon, 4 Dec 2023 14:53:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5A039F8024E; Mon, 4 Dec 2023 14:53:26 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6562CF800D2 for ; Mon, 4 Dec 2023 14:53:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6562CF800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=S7jPfNYo Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6DA03B80EF5; Mon, 4 Dec 2023 13:53:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B81ACC433C8; Mon, 4 Dec 2023 13:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701697999; bh=esHuCLsnYzWLmm5Oa6L+Kmza70Ps3RCO18AT+iUJYoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S7jPfNYoSehiFCVmvkeB3YWHBnjgSiFuETLq9dY1RH90k0MXl6dSB376aJQmxz/SJ QRqiBrCPDEv1NNNLFRdNyVkjtcdqEqUL/zpg/AxF++c9EonLkx58tZ+UvojQSP6YXE 62SIy3Jbw8gCBjUohCYs20csnvEtT+ev3iQwuumVREZmjFQv/HL4+Z6/ikawOUcHaD JW0zXl6b3XoZFkJE+nF3JlC2xpaEMk9MhOOQFq4Dz0q2tgyz7G4hyemrsz9elc7pyY lVqrA/RCi1ut+Rh8FCFmoevezMjQhYb7V/4hj5lL35IcaU/LhMTlMSJYbRWuEnne3T MMAeJQzpMoK1A== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rA9Ob-0003VA-1F; Mon, 04 Dec 2023 14:54:01 +0100 Date: Mon, 4 Dec 2023 14:54:01 +0100 From: Johan Hovold To: srinivas.kandagatla@linaro.org Cc: broonie@kernel.org, alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org Subject: Re: [PATCH 2/2] ASoC: qcom: sc8280xp: Limit speaker digital volumes Message-ID: References: <20231204124736.132185-1-srinivas.kandagatla@linaro.org> <20231204124736.132185-3-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204124736.132185-3-srinivas.kandagatla@linaro.org> Message-ID-Hash: 4TI2HKZT2SN3RD7BHCWFVZVWCPA47TI5 X-Message-ID-Hash: 4TI2HKZT2SN3RD7BHCWFVZVWCPA47TI5 X-MailFrom: johan@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Dec 04, 2023 at 12:47:36PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla > > Limit the speaker digital gains to 0dB so that the users will not damage them. > Currently there is a limit in UCM, but this does not stop the user form > changing the digital gains from command line. So limit this in driver > which makes the speakers more safer without active speaker protection in > place. > > Signed-off-by: Srinivas Kandagatla Works as intended: Reviewed-by: Johan Hovold Tested-by: Johan Hovold Given the reason for why you are adding this, it seems you should have added: Cc: stable@vger.kernel.org # 6.5 as well. Johan