From: Johan Hovold <johan@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: broonie@kernel.org, alsa-devel@alsa-project.org, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, johan+linaro@kernel.org
Subject: Re: [PATCH 1/2] ASoC: ops: add correct range check for limiting volume
Date: Mon, 4 Dec 2023 14:51:31 +0100 [thread overview]
Message-ID: <ZW3ZY_2_G64dNAeS@hovoldconsulting.com> (raw)
In-Reply-To: <20231204124736.132185-2-srinivas.kandagatla@linaro.org>
On Mon, Dec 04, 2023 at 12:47:35PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> Volume can have ranges that start with negative values, ex: -84dB to
> +40dB. Apply correct range check in snd_soc_limit_volume before setting
> the platform_max. Without this patch, for example setting a 0dB limit on
> a volume range of -84dB to +40dB would fail.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Seems to work as intended with the following patch on the X13s:
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Should you add a Fixes and CC-stable tag so we can get this backported
(at least to 6.5 for the X13s)?
Johan
next prev parent reply other threads:[~2023-12-04 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 12:47 [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker srinivas.kandagatla
2023-12-04 12:47 ` [PATCH 1/2] ASoC: ops: add correct range check for limiting volume srinivas.kandagatla
2023-12-04 13:51 ` Johan Hovold [this message]
2023-12-04 12:47 ` [PATCH 2/2] ASoC: qcom: sc8280xp: Limit speaker digital volumes srinivas.kandagatla
2023-12-04 13:54 ` Johan Hovold
2023-12-05 13:11 ` [PATCH 0/2] ASoC: qcom: Limit Digital gains on speaker Mark Brown
2023-12-11 8:08 ` Johan Hovold
2023-12-11 12:40 ` Greg Kroah-Hartman
2023-12-11 12:54 ` Greg Kroah-Hartman
2023-12-11 13:29 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW3ZY_2_G64dNAeS@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.