From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KH4huRNS" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 591E0F2 for ; Mon, 4 Dec 2023 06:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701698606; x=1733234606; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Hc3GDWAuiWFVq4OPHL/bpZJQWt8nhUFwuxno2A4bz/Q=; b=KH4huRNSQayz+aeQrA7Dueva6be1vkDqKlXugfLWsuoBAEo9Y5+AMGrP tUpqwLeMv7XQyhAhQkcF2YRYr6vwKup4Sbko9dBJyMBNCClsnNMxkd4AC 88R+CeS4OdQNN8RWD6KWov8JvzfPtqklOtdvroa8OjVWwo9SOsffhyn89 wXmXlhmfZiyZZdjkH8KN0TEpbNq+4bXx7cyySdK8kXD8gwzTtXHkyWJTq 6DIgkW3aSPYELwCnl3nTclK/UNqhqR0xRplRkJSwJtaDJJNkJvwUsH7uQ XLfmIJ2MMm932o2NMNMycmGxRPHtwtngQrk9F2lBwUbesE1TuC4HxESX0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="396540385" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="396540385" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 06:03:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="746843628" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="746843628" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 06:03:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rA9Xd-00000001lqn-05Lo; Mon, 04 Dec 2023 16:03:21 +0200 Date: Mon, 4 Dec 2023 16:03:20 +0200 From: Andy Shevchenko To: Stefan Wahren Cc: Bartosz Golaszewski , Linus Walleij , Pavel Machek , Lee Jones , linux-leds@vger.kernel.org Subject: Re: [PATCH V3] leds: gpio: Add kernel log if devm_fwnode_gpiod_get fails Message-ID: References: <20231202183636.7055-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231202183636.7055-1-wahrenst@gmx.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sat, Dec 02, 2023 at 07:36:36PM +0100, Stefan Wahren wrote: > In case leds-gpio fails to get at least one of possibly many GPIOs > from the DT (e.g. the GPIO is already requested) neither gpiolib nor > the driver does provide any helpful error log: > > leds-gpio: probe of leds failed with error -16 > > As the driver knows better how to handle errors with such mandatory > GPIOs, let's implement an error log which points to the affected > GPIO. As we have had a consensus, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko