All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Qi.Chen@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] docker: remove unnecessary dependencies
Date: Mon, 4 Dec 2023 21:01:35 +0000	[thread overview]
Message-ID: <ZW4+L9pBEV5Vs9N9@gmail.com> (raw)
In-Reply-To: <20231128065014.3729629-1-Qi.Chen@windriver.com>

merged.

I've been meaning to clean that up, so this saves me
the effort.

The go dependencies as packages was a short lived attempt
at handling build requirements and is no longer viable!

Bruce

In message: [meta-virtualization][PATCH] docker: remove unnecessary dependencies
on 28/11/2023 Chen Qi via lists.yoctoproject.org wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
> 
> The build is not using the codes from these source packages.
> Remove the dependencies.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  recipes-containers/docker/docker.inc | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/recipes-containers/docker/docker.inc b/recipes-containers/docker/docker.inc
> index 4a4bc4f6..48f7d3ec 100644
> --- a/recipes-containers/docker/docker.inc
> +++ b/recipes-containers/docker/docker.inc
> @@ -1,21 +1,6 @@
>  DEPENDS = " \
> -    go-cli \
> -    go-pty \
> -    go-context \
> -    go-mux \
> -    go-patricia \
> -    go-logrus \
> -    go-fsnotify \
> -    go-dbus \
> -    go-capability \
> -    go-systemd \
>      btrfs-tools \
>      sqlite3 \
> -    go-distribution \
> -    compose-file \
> -    go-connections \
> -    notary \
> -    grpc-go \
>      libtool-native \
>      libtool \
>      "
> @@ -78,7 +63,7 @@ do_compile() {
>  	ln -sf ${WORKDIR}/git/libnetwork .gopath/src/github.com/docker/libnetwork
>  	ln -sf ${WORKDIR}/git/cli .gopath/src/github.com/docker/cli
>  
> -	export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor:${STAGING_DIR_TARGET}/${prefix}/local/go"
> +	export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor"
>  	export GOROOT="${STAGING_DIR_NATIVE}/${nonarch_libdir}/${HOST_SYS}/go"
>  
>  	# Pass the needed cflags/ldflags so that cgo
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8475): https://lists.yoctoproject.org/g/meta-virtualization/message/8475
> Mute This Topic: https://lists.yoctoproject.org/mt/102846564/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2023-12-04 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28  6:50 [meta-virtualization][PATCH] docker: remove unnecessary dependencies Qi.Chen
2023-12-04 21:01 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZW4+L9pBEV5Vs9N9@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=Qi.Chen@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.