From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE68B2E847 for ; Mon, 4 Dec 2023 19:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="skGr+AUr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18A96C433C7; Mon, 4 Dec 2023 19:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701718877; bh=RXdn7YdWXNah7nltudb7qfhHrrahkAbHAZJ9llIwtKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=skGr+AUrsXfkqS8yjxDbQcG1zzlrRlu6/XRbuE/W1hpt7mvk3YKmkmqnk0r1w4CcT 4WN2hCtnHymCJWtSmr2QbG4PbzJRvGlWkXTqiNiYPMQbOHiHiYG4Idp3vhRseXYdpZ vo7P6CgJoQPm67QxvSMW4fGwefcYs1WyVhsF80C79Ymr7tmIb6GKKanV9QJorMqULn xxosg2gN7/8TkIHIrcFHd5BfGo2Q4KvqMw9xFPl7WO5j0PACRfzCSqgbvvTjxZeSN8 YrQxgFn9RvTcKWsXSAXY98uzdE4ertHEuBks4tjh9SP6esxgRgOM5qqR7VbML6v9G5 gQsqAQio3ta+Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D568240094; Mon, 4 Dec 2023 16:41:13 -0300 (-03) Date: Mon, 4 Dec 2023 16:41:13 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Ilkka Koskinen , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 1/3] perf vendor events arm64: AmpereOne: Add missing DefaultMetricgroupName fields Message-ID: References: <20231201021550.1109196-1-ilkka@os.amperecomputing.com> <20231201021550.1109196-2-ilkka@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Mon, Dec 04, 2023 at 11:02:31AM -0800, Ian Rogers escreveu: > On Thu, Nov 30, 2023 at 6:16 PM Ilkka Koskinen > wrote: > > > > AmpereOne metrics were missing DefaultMetricgroupName from metrics with > > "Default" in group name resulting perf to segfault. Add the missing > > field to address the issue. > > > > Fixes: 59faeaf80d02 ("perf vendor events arm64: Fix for AmpereOne metrics") > > Signed-off-by: Ilkka Koskinen > > Sorry, I just stumbled across this and sent a fix too. > https://lore.kernel.org/lkml/20231204182330.654255-1-irogers@google.com/ > The patches are identical so I'd suggest taking this one and the first > patch in my changes. > > Reviewed-by: Ian Rogers Thanks, applied the series. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A131FC4167B for ; Mon, 4 Dec 2023 19:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oczhn0GpX23bPgbqBLFDw1caTP82m/7o66wu5sPAl3Y=; b=jKG9zHN/CQ1xM9 Wd7B2UQrTv+uWa1u1M9HYmOv1+upqwh/qfNqlabTw9ulJhiQUUVGpQC5bMtlLXaz8+c/c0E/iNgXy XMuHD4xF+xGm9MjNv1e8epTYV5TMMRPVBAEmFv26I0Lt0ldqED1OBCZu/XPwv3TCIF7WsT01RtGP6 eDZJLJSaQsX2hdZQIk7buzJYVCUAhv8ow/sLTUEDyThmmwYQ2JNlLWClJkIRhDyScsGVyAykhaUiC 2WpWjaMfrrSc/KnnlCAlKwu16BdGVcZluiyMeiiVjGMUeEgUkWZ/gE9OC+qqZBp7QtLoNKecQN9vp YdI+gXQ117U1TcAGmEfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAEok-005TU8-01; Mon, 04 Dec 2023 19:41:22 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAEoi-005TTM-28 for linux-arm-kernel@bombadil.infradead.org; Mon, 04 Dec 2023 19:41:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=oIjmrA5gLXoQtnpVEc18dGh9/Tho2Y0YA2jVySTmzCA=; b=Q5Mwh4JvDveSS6GK4/N95K2FYa Wb/zll5bpq3wkpKqZDM6YuXREOluZxfQ/TUiEmpWRpbEvZzah/0McHrJ2YhnE0PKHrjY2+pH1w2O+ UWYuavHkTcwzbJGId2+9RPrDNMIo+Ob+HM+jVLU/x0e+L0g5KvdY0V6N5Y3ZihiEal2THtlJB8YFO 9bHJkq7SJsZjMde+q8r88O9Bz0qJNfCVgqre5biX1vdyMevVc3Tehty4GhMR6L+QWhEomtd34OUwq aMCpUOkphAXOtUupJWAUr3mtJ/fJbpY1V5RHKVwMESjK8JcpCCjchv/FS80DOSAwY0SVI8CYpePBB qL7Rf2MA==; Received: from [200.166.87.243] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1rAEog-001120-7z; Mon, 04 Dec 2023 19:41:18 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D568240094; Mon, 4 Dec 2023 16:41:13 -0300 (-03) Date: Mon, 4 Dec 2023 16:41:13 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Ilkka Koskinen , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 1/3] perf vendor events arm64: AmpereOne: Add missing DefaultMetricgroupName fields Message-ID: References: <20231201021550.1109196-1-ilkka@os.amperecomputing.com> <20231201021550.1109196-2-ilkka@os.amperecomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBEZWMgMDQsIDIwMjMgYXQgMTE6MDI6MzFBTSAtMDgwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBPbiBUaHUsIE5vdiAzMCwgMjAyMyBhdCA2OjE24oCvUE0gSWxra2EgS29za2luZW4K PiA8aWxra2FAb3MuYW1wZXJlY29tcHV0aW5nLmNvbT4gd3JvdGU6Cj4gPgo+ID4gQW1wZXJlT25l IG1ldHJpY3Mgd2VyZSBtaXNzaW5nIERlZmF1bHRNZXRyaWNncm91cE5hbWUgZnJvbSBtZXRyaWNz IHdpdGgKPiA+ICJEZWZhdWx0IiBpbiBncm91cCBuYW1lIHJlc3VsdGluZyBwZXJmIHRvIHNlZ2Zh dWx0LiBBZGQgdGhlIG1pc3NpbmcKPiA+IGZpZWxkIHRvIGFkZHJlc3MgdGhlIGlzc3VlLgo+ID4K PiA+IEZpeGVzOiA1OWZhZWFmODBkMDIgKCJwZXJmIHZlbmRvciBldmVudHMgYXJtNjQ6IEZpeCBm b3IgQW1wZXJlT25lIG1ldHJpY3MiKQo+ID4gU2lnbmVkLW9mZi1ieTogSWxra2EgS29za2luZW4g PGlsa2thQG9zLmFtcGVyZWNvbXB1dGluZy5jb20+Cj4gCj4gU29ycnksIEkganVzdCBzdHVtYmxl ZCBhY3Jvc3MgdGhpcyBhbmQgc2VudCBhIGZpeCB0b28uCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5v cmcvbGttbC8yMDIzMTIwNDE4MjMzMC42NTQyNTUtMS1pcm9nZXJzQGdvb2dsZS5jb20vCj4gVGhl IHBhdGNoZXMgYXJlIGlkZW50aWNhbCBzbyBJJ2Qgc3VnZ2VzdCB0YWtpbmcgdGhpcyBvbmUgYW5k IHRoZSBmaXJzdAo+IHBhdGNoIGluIG15IGNoYW5nZXMuCj4gCj4gUmV2aWV3ZWQtYnk6IElhbiBS b2dlcnMgPGlyb2dlcnNAZ29vZ2xlLmNvbT4KClRoYW5rcywgYXBwbGllZCB0aGUgc2VyaWVzLgoK LSBBcm5hbGRvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==