All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Xiangyu Chen <xiangyu.chen@eng.windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] lxc: add distrosysconfdir option to make sure the lxc configuration in correct folder
Date: Mon, 4 Dec 2023 22:19:49 +0000	[thread overview]
Message-ID: <ZW5QhUaOkNq0pXEC@gmail.com> (raw)
In-Reply-To: <20231130054524.1125012-1-xiangyu.chen@eng.windriver.com>

merged.

Bruce

In message: [meta-virtualization][PATCH] lxc: add distrosysconfdir option to make sure the lxc configuration in correct folder
on 30/11/2023 Xiangyu Chen wrote:

> From: Xiangyu Chen <xiangyu.chen@windriver.com>
> 
> After the commit[1] "meson.build: allow explicit distrosysconfdir", the config of lxc would install
> to distrosysconfdir[2], if this value not set, it might set to /etc/sysconfig, that cause lxc-net
> configuration cannot be found[3] due to our bb file install the lxc-net to /etc/default folder.
> 
> Ref:
> [1] https://github.com/lxc/lxc/commit/16ebb29dccb35bf74e8a19e8c45d2513f927476f
> [2] https://github.com/lxc/lxc/blob/main/config/sysconfig/meson.build#L9
> [3] https://github.com/lxc/lxc/blob/main/config/sysconfig/lxc.in#L28
> 
> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
> ---
>  recipes-containers/lxc/lxc_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
> index 94e71087..33ea4ee7 100644
> --- a/recipes-containers/lxc/lxc_git.bb
> +++ b/recipes-containers/lxc/lxc_git.bb
> @@ -60,7 +60,7 @@ PTEST_CONF = "${@bb.utils.contains('DISTRO_FEATURES', 'ptest', '-Dtests=true', '
>  
>  # No meson equivalent for --with-distro
>  # EXTRA_OECONF += "--with-distro=${DISTRO} ${PTEST_CONF}"
> -EXTRA_OEMESON += "${PTEST_CONF}"
> +EXTRA_OEMESON += "${PTEST_CONF} -Ddistrosysconfdir=${sysconfdir}/default"
>  # No meson equivalent for these yet
>  # EXTRA_OECONF += "--enable-log-src-basename --disable-werror"
>  
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8482): https://lists.yoctoproject.org/g/meta-virtualization/message/8482
> Mute This Topic: https://lists.yoctoproject.org/mt/102888929/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2023-12-04 22:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  5:45 [meta-virtualization][PATCH] lxc: add distrosysconfdir option to make sure the lxc configuration in correct folder Xiangyu Chen
2023-12-04 22:19 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZW5QhUaOkNq0pXEC@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=xiangyu.chen@eng.windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.