From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 004AEC4167B for ; Tue, 5 Dec 2023 14:31:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.647961.1011779 (Exim 4.92) (envelope-from ) id 1rAWRa-0002i6-Tn; Tue, 05 Dec 2023 14:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 647961.1011779; Tue, 05 Dec 2023 14:30:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rAWRa-0002hz-R8; Tue, 05 Dec 2023 14:30:38 +0000 Received: by outflank-mailman (input) for mailman id 647961; Tue, 05 Dec 2023 14:30:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rAWRZ-0000ZF-6A for xen-devel@lists.xenproject.org; Tue, 05 Dec 2023 14:30:37 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da729a70-937a-11ee-9b0f-b553b5be7939; Tue, 05 Dec 2023 15:30:35 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40c0873cf84so30768645e9.1 for ; Tue, 05 Dec 2023 06:30:35 -0800 (PST) Received: from localhost ([213.195.113.99]) by smtp.gmail.com with ESMTPSA id n10-20020a05600c4f8a00b0040b4b2a15ebsm18736978wmq.28.2023.12.05.06.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 06:30:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da729a70-937a-11ee-9b0f-b553b5be7939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1701786635; x=1702391435; darn=lists.xenproject.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=As6pafrDewdwd74baYtQQACTLUGczckFKgBD8E77da0=; b=kb9R3bOYU4wmCMs9GF9i+PymeXTappG1jAb0mfavg0tfItuso72gSdl4biqoTeBgqR Ok1uiHiQKd7CMyA0FkD0K3Dw01kAwkKP88nXIN+n4+2l1GU42M8E++hBBnR/K0BAxUdm mlfMg98ZDMU+//VD1trswwuhsXlYByZVnQslQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701786635; x=1702391435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=As6pafrDewdwd74baYtQQACTLUGczckFKgBD8E77da0=; b=G+kUjDpiGSiXDr1KV2d8ORvxMw6MFUMKqdqBWGhoHMIb2OJkLVMduFTNVxMH9u9li6 XYHR2uSosm01pMdGRKxeRNzLYIZJCjpCwWGg+awTu6GlOUrYvwX7WiW9jfJD9YniZnF+ m79GjvQtqztRTBlFhGhRGkNd2Ooi1y0f2vC5ybevBbusuJkc4tvAto9wp+8WvdxJB3q/ WZmZxbuIq/Y0XJyfzhxily4D6TYYNI31oMJIBUjdrjSs9E/van482H6JV1Xq4hpOhDEi UhpWtbMcfm5AsysnKaQ6gktjPVTOXXNcT9L9u9vRxgbKwIM5fJTUnSSVpsEPjHUC45sw UNmg== X-Gm-Message-State: AOJu0YxMHkyq+wdVryy1qrCftvJJ1GBLM41SRy/3E3bxBy5tKyjmelXr bdccIW4LV/foPWbRbqwa6lbRUw== X-Google-Smtp-Source: AGHT+IE+FfmlLUFlpjq5XT0UuSzGs8n67PWdYn2FROaxRpQrkQJU4mFjkJEpw1+++PexJfOoCEpMcw== X-Received: by 2002:a05:600c:16d3:b0:40b:5e59:c55f with SMTP id l19-20020a05600c16d300b0040b5e59c55fmr592412wmn.137.1701786635114; Tue, 05 Dec 2023 06:30:35 -0800 (PST) Date: Tue, 5 Dec 2023 15:30:34 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/6] iommu/vt-d: do not assume page table levels for quarantine domain Message-ID: References: <20231204094305.59267-1-roger.pau@citrix.com> <20231204094305.59267-2-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Dec 05, 2023 at 03:24:46PM +0100, Jan Beulich wrote: > On 04.12.2023 10:43, Roger Pau Monne wrote: > > Like XSA-445, do not assume IOMMU page table levels on VT-d are always set > > based on DEFAULT_DOMAIN_ADDRESS_WIDTH and instead fetch the value set by > > intel_iommu_hwdom_init() from the domain iommu structure. This prevents > > changes to intel_iommu_hwdom_init() possibly getting the levels out of sync > > In both cases, don't you mean intel_iommu_domain_init() instead? Only if Indeed, sorry. > so > Reviewed-by: Jan Beulich > (and happy to adjust while committing). Thanks. > Otherwise I must be missing something. No, you are right. Roger.