From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 579485F1EE for ; Tue, 5 Dec 2023 15:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n6KocxkD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0A3DC433C8; Tue, 5 Dec 2023 15:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701791474; bh=Qg5ESRd5FBfKW+n1IMVwA9nXFoeDUKVN3mRCnzAwGNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n6KocxkDs7zs6xJqEs1RwbNasZrkNYn/OOPqK2h6Zar0nQQ/ZiGIKcsRNdxFHOi/s mMmf4IV0SNrfOEQ54GRoNeA5i1oS1sMqNRp3TcKHV6h2tD5A3Go4hqvdxmuKRqokXw 6GOtJWx/JqcrTepMgWkn4TmYYGs0Xs/VqACqr6j3zri8JcycBlrsu6XPd/1ZpZ1UVA l8BKBp1zNmuNfRIqa/QUDNg0oFjLI96mWjuOYINVQ+PIdGi0ZgXl/k+4ufq5mc3V1s hPli+d7MB8sVLC8RKvdyu/ah+9ps2K3yDZkX8Kyq5Q3V5rYa+emDnK10N/Z0V2XDv6 bFh5MNrkk2I2A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1882540094; Tue, 5 Dec 2023 12:51:12 -0300 (-03) Date: Tue, 5 Dec 2023 12:51:12 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ilkka Koskinen , Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Kajol Jain , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] perf metrics: Avoid segv if default metricgroup isn't set Message-ID: References: <20231204182330.654255-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Mon, Dec 04, 2023 at 07:33:18PM -0800, Namhyung Kim escreveu: > On Mon, Dec 4, 2023 at 2:45 PM Ilkka Koskinen wrote: > > On Mon, 4 Dec 2023, Ian Rogers wrote: > > > A metric is default by having "Default" within its groups. The default > > > metricgroup name needn't be set and this can result in segv in > > > default_metricgroup_cmp and perf_stat__print_shadow_stats_metricgroup > > > that assume it has a value when there is a Default metric group. To > > > avoid the segv initialize the value to "". > > > Fixes: 1c0e47956a8e ("perf metrics: Sort the Default metricgroup") > > > Signed-off-by: Ian Rogers > > Thanks! I was going to look for the bug but got pulled to other > > tasks. The patch looks good to me and I tested it successfully on > > AmpereOne. > > Reviewed-and-tested-by: Ilkka Koskinen > Looks like it needs to go through perf-tools for v6.7. > Ian, do you think this one is enough? So I had this on my local perf-tools-next, removed now, I also have some other fixes by Ian on the tmp.perf-tools-next, please let me know what you guys decide to have in perf-tools for v6.7 so that I can remove it from there. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7987C4167B for ; Tue, 5 Dec 2023 15:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/6Ns3UCa5A1+pIswmNOAsNoZUYrPkkgHIBSUul6KqGc=; b=bDLe8KfD/blmhx 5impVa+Z2gNlpoVH5pcRUiwD2NMitrdl0EZCemMKolJZ7ULf4txvI1L+xw7y+bccGbM+xHDjjz9DB 19U51Fy19qiRTi19XqjSuOnZpaHPES3T9Qcsopw2yQ5PpPvo1bCe6DGZo2pk7bAghWkxAVk3tJvg0 sByQh9XMcIEMqLHFyqOrkuTlzfP4is8hRJzhfkSS/n29PcYvX5w6SsDOYN7Shi3tHLCkF8tQaIszd h3GSDHfIbPpMeeab8mSsSpeMpSsHZfma1T7uoQltDf51oQv/vmyPnQDhKw+web4EDpXLecHRNKzPc LHSINIcV94zjWmZErKeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAXhd-007nwv-0C; Tue, 05 Dec 2023 15:51:17 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAXhc-007nwl-0z for linux-arm-kernel@bombadil.infradead.org; Tue, 05 Dec 2023 15:51:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=ZDotk90CexayQPSnBMckA120iMd9UxQLNu+ClvXLgNc=; b=ZF1f8cA4uCeSaWseBgRmDHiTg+ ZGHqZUfiMNv3+Nug/HZlUQMVP2K9JCPCAvbIu0bTg/3ELnsfN7lsCWjgXadTYIgqjsIelYzkv5mrS Lu4J4EjpKfnwzGncChizmEiZXAFaxyHaKKYD+FaozHh8mpWjuAXEsEcXZR8doKyDd+8hXL8oVZRS4 n3zeya4IDcS7Ut4vDByzcWml1NkbdFypVlJWega7CZodzxyjJiBELy/hKAjlwTm6STpCHWlNyevLC PREeu3yLppxDcKqnGyG8WeVECdy7sTDSEUyNcozDBUJgThIMTzTYYZm/lLEd3Smytu9vkyzf/ht68 UgZMZzFA==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rAXha-004niv-2I; Tue, 05 Dec 2023 15:51:15 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1882540094; Tue, 5 Dec 2023 12:51:12 -0300 (-03) Date: Tue, 5 Dec 2023 12:51:12 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ilkka Koskinen , Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Kajol Jain , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] perf metrics: Avoid segv if default metricgroup isn't set Message-ID: References: <20231204182330.654255-1-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBEZWMgMDQsIDIwMjMgYXQgMDc6MzM6MThQTSAtMDgwMCwgTmFtaHl1bmcgS2ltIGVz Y3JldmV1Ogo+IE9uIE1vbiwgRGVjIDQsIDIwMjMgYXQgMjo0NeKAr1BNIElsa2thIEtvc2tpbmVu IDxpbGtrYUBvcy5hbXBlcmVjb21wdXRpbmcuY29tPiB3cm90ZToKPiA+IE9uIE1vbiwgNCBEZWMg MjAyMywgSWFuIFJvZ2VycyB3cm90ZToKPiA+ID4gQSBtZXRyaWMgaXMgZGVmYXVsdCBieSBoYXZp bmcgIkRlZmF1bHQiIHdpdGhpbiBpdHMgZ3JvdXBzLiBUaGUgZGVmYXVsdAo+ID4gPiBtZXRyaWNn cm91cCBuYW1lIG5lZWRuJ3QgYmUgc2V0IGFuZCB0aGlzIGNhbiByZXN1bHQgaW4gc2VndiBpbgo+ ID4gPiBkZWZhdWx0X21ldHJpY2dyb3VwX2NtcCBhbmQgcGVyZl9zdGF0X19wcmludF9zaGFkb3df c3RhdHNfbWV0cmljZ3JvdXAKPiA+ID4gdGhhdCBhc3N1bWUgaXQgaGFzIGEgdmFsdWUgd2hlbiB0 aGVyZSBpcyBhIERlZmF1bHQgbWV0cmljIGdyb3VwLiBUbwo+ID4gPiBhdm9pZCB0aGUgc2VndiBp bml0aWFsaXplIHRoZSB2YWx1ZSB0byAiIi4KCj4gPiA+IEZpeGVzOiAxYzBlNDc5NTZhOGUgKCJw ZXJmIG1ldHJpY3M6IFNvcnQgdGhlIERlZmF1bHQgbWV0cmljZ3JvdXAiKQo+ID4gPiBTaWduZWQt b2ZmLWJ5OiBJYW4gUm9nZXJzIDxpcm9nZXJzQGdvb2dsZS5jb20+Cgo+ID4gVGhhbmtzISBJIHdh cyBnb2luZyB0byBsb29rIGZvciB0aGUgYnVnIGJ1dCBnb3QgcHVsbGVkIHRvIG90aGVyCj4gPiB0 YXNrcy4gVGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUgYW5kIEkgdGVzdGVkIGl0IHN1Y2Nlc3Nm dWxseSBvbgo+ID4gQW1wZXJlT25lLgoKPiA+ICAgIFJldmlld2VkLWFuZC10ZXN0ZWQtYnk6IEls a2thIEtvc2tpbmVuIDxpbGtrYUBvcy5hbXBlcmVjb21wdXRpbmcuY29tPgogCj4gTG9va3MgbGlr ZSBpdCBuZWVkcyB0byBnbyB0aHJvdWdoIHBlcmYtdG9vbHMgZm9yIHY2LjcuCj4gSWFuLCBkbyB5 b3UgdGhpbmsgdGhpcyBvbmUgaXMgZW5vdWdoPwoKU28gSSBoYWQgdGhpcyBvbiBteSBsb2NhbCBw ZXJmLXRvb2xzLW5leHQsIHJlbW92ZWQgbm93LCBJIGFsc28gaGF2ZSBzb21lCm90aGVyIGZpeGVz IGJ5IElhbiBvbiB0aGUgdG1wLnBlcmYtdG9vbHMtbmV4dCwgcGxlYXNlIGxldCBtZSBrbm93IHdo YXQKeW91IGd1eXMgZGVjaWRlIHRvIGhhdmUgaW4gcGVyZi10b29scyBmb3IgdjYuNyBzbyB0aGF0 IEkgY2FuIHJlbW92ZSBpdApmcm9tIHRoZXJlLgoKLSBBcm5hbGRvCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==