From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Paul Durrant" <paul@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Lukasz Hawrylko" <lukasz@hawrylko.pl>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
"Mateusz Mówka" <mateusz.mowka@intel.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 6/6] x86/iommu: cleanup unused functions
Date: Tue, 5 Dec 2023 16:48:29 +0100 [thread overview]
Message-ID: <ZW9GTeqW4Gsqi5Rg@macbook> (raw)
In-Reply-To: <37624f9d-a679-44c8-84ab-42fb8e6a28a0@suse.com>
On Tue, Dec 05, 2023 at 04:29:18PM +0100, Jan Beulich wrote:
> On 04.12.2023 10:43, Roger Pau Monne wrote:
> > Remove xen_in_range() and vpci_is_mmcfg_address() now that hey are unused.
>
> Of the latter you remove only the declaration. Stale patch maybe?
Fixed.
> For the former, am I misremembering that Andrew had asked for the function
> to stay?
https://lore.kernel.org/xen-devel/81534803-9da4-49b7-894e-f3fb5e8fb131@citrix.com
I did read Andrew's response as it being fine to switch the current
function to use a rangeset, but not as a request to duplicate it.
Thanks, Roger.
next prev parent reply other threads:[~2023-12-05 15:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 9:42 [PATCH v2 0/6] x86/iommu: improve setup time of hwdom IOMMU Roger Pau Monne
2023-12-04 9:43 ` [PATCH v2 1/6] iommu/vt-d: do not assume page table levels for quarantine domain Roger Pau Monne
2023-12-05 14:24 ` Jan Beulich
2023-12-05 14:30 ` Roger Pau Monné
2023-12-04 9:43 ` [PATCH v2 2/6] amd-vi: set IOMMU page table levels based on guest reported paddr width Roger Pau Monne
2023-12-05 14:32 ` Jan Beulich
2023-12-05 15:11 ` Roger Pau Monné
2023-12-05 15:19 ` Jan Beulich
2023-12-04 9:43 ` [PATCH v2 3/6] x86/iommu: introduce a rangeset to perform hwdom IOMMU setup Roger Pau Monne
2023-12-05 14:50 ` Jan Beulich
2023-12-05 15:29 ` Roger Pau Monné
2023-12-04 9:43 ` [PATCH v2 4/6] x86/iommu: remove regions not to be mapped Roger Pau Monne
2023-12-05 15:11 ` Jan Beulich
2023-12-05 15:31 ` Roger Pau Monné
2023-12-05 15:34 ` Jan Beulich
2023-12-04 9:43 ` [PATCH v2 5/6] x86/iommu: switch hwdom IOMMU to use a rangeset Roger Pau Monne
2023-12-05 15:27 ` Jan Beulich
2023-12-05 15:43 ` Roger Pau Monné
2023-12-05 15:47 ` Jan Beulich
2023-12-05 16:07 ` Roger Pau Monné
2023-12-04 9:43 ` [PATCH v2 6/6] x86/iommu: cleanup unused functions Roger Pau Monne
2023-12-05 15:29 ` Jan Beulich
2023-12-05 15:48 ` Roger Pau Monné [this message]
2023-12-05 15:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW9GTeqW4Gsqi5Rg@macbook \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=jbeulich@suse.com \
--cc=lukasz@hawrylko.pl \
--cc=mateusz.mowka@intel.com \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.