From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7277F5F1FC for ; Tue, 5 Dec 2023 18:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QZKjDzvk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16059C433C8; Tue, 5 Dec 2023 18:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701802121; bh=5KqBzScuuu0YI5DInZYG3ftxv+0rWvUyxh+PzEZeATI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QZKjDzvkJSQBXK8TntRGXYf2rczkwCY4sVeQFHovoP2DyA2ysnAM4Gy/c055Iz9I0 FsrwMI1YY4txcLFV93Eiowat8OUq62y0GCxEQjR6EFbysWa518vbGByXwdFioCbLE5 PpelimSqY+EyUYZkFOccUDaoWdL4IkSqH3UDdxeHoulCpUo9JrMHkejsGm2lxCkdgN xwVVh+Q7iZDMt+bv/dBfM0Np37JNAC/vQ2e1mYpqPCvnVzkZejyUfrXHRN1elk5ECw ewPxsQtXXWkyBK9dUjeBClATbpE/VLUSM5/IzywmpSrJJDbRrBP5KK/YvsYqWMIWOh nhDV9V8ve4/9w== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3CE7F40094; Tue, 5 Dec 2023 15:48:38 -0300 (-03) Date: Tue, 5 Dec 2023 15:48:38 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ilkka Koskinen , Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Kajol Jain , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] perf metrics: Avoid segv if default metricgroup isn't set Message-ID: References: <20231204182330.654255-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Tue, Dec 05, 2023 at 09:24:42AM -0800, Namhyung Kim escreveu: > Hi Arnaldo, > > On Tue, Dec 5, 2023 at 7:51 AM Arnaldo Carvalho de Melo wrote: > > > > Em Mon, Dec 04, 2023 at 07:33:18PM -0800, Namhyung Kim escreveu: > > > On Mon, Dec 4, 2023 at 2:45 PM Ilkka Koskinen wrote: > > > > On Mon, 4 Dec 2023, Ian Rogers wrote: > > > > > A metric is default by having "Default" within its groups. The default > > > > > metricgroup name needn't be set and this can result in segv in > > > > > default_metricgroup_cmp and perf_stat__print_shadow_stats_metricgroup > > > > > that assume it has a value when there is a Default metric group. To > > > > > avoid the segv initialize the value to "". > > > > > > > Fixes: 1c0e47956a8e ("perf metrics: Sort the Default metricgroup") > > > > > Signed-off-by: Ian Rogers > > > > > > Thanks! I was going to look for the bug but got pulled to other > > > > tasks. The patch looks good to me and I tested it successfully on > > > > AmpereOne. > > > > > > Reviewed-and-tested-by: Ilkka Koskinen > > > > > Looks like it needs to go through perf-tools for v6.7. > > > Ian, do you think this one is enough? > > > > So I had this on my local perf-tools-next, removed now, I also have some > > other fixes by Ian on the tmp.perf-tools-next, please let me know what > > you guys decide to have in perf-tools for v6.7 so that I can remove it > > from there. > > I think we need this one and the Ampere default-metric-group fix. > > https://lore.kernel.org/r/20231201021550.1109196-2-ilkka@os.amperecomputing.com/ > > Also perf list JSON fix can go to v6.7. > > https://lore.kernel.org/r/20231129213428.2227448-2-irogers@google.com/ Ok, removed both, please augment the later description to: "perf list: Fix JSON segfault by setting the used skip_fuplicate_pmus callback" The original description was vague, improving it a bit like that helps when just looking at the output of "git log --oneline". Thanks, - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 306DCC4167B for ; Tue, 5 Dec 2023 18:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n8GaDI/+wWf3TAfy2JmMiyU5m59W6tBpqetm5Od9wqI=; b=Xd19IY6UcW20Ac nvBepFqwzkpxjEggiwOMUoGr+OMHspRzn7irX5KX2fwtAsSk/uVqe9PQohXGwoEmtktaDKtgUtIfZ vi0AnXlfroP89urg/09u6VYxvObnFsXlJIYQNfJRq7Nvkci766bZRcWjbAmTH4aPnXfcBpTD2nqOK RWIDB/m/6uuTrN4qZi9DOJ+PNJr5vLzySGi7ghOA3smawzRgZhL5NW2nJ8AXccPGLQ8C/G60eQJTH kezxfzvUo8xlrKOLcRGpegFEdKo+tSWPSv+BVTLytBRQ22+ivjNSUUpU0v6sGcEZr/VfIZ+K4bENm P68vlfNNUrsZ5F8UmIfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAaTN-008CSx-2h; Tue, 05 Dec 2023 18:48:45 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAaTM-008CSB-2B for linux-arm-kernel@bombadil.infradead.org; Tue, 05 Dec 2023 18:48:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=2Pblm++TLW4aHpmgBpne7DfTFw6hm2e/aCbB0CQjpvs=; b=qTm3MUCr1P+UeGy9XLz7xxnYKa kaY4nKB/oAka7/VnpxJ1YgwmSsnm3J+m4bLHmtpc04fVVuDXiGQ3RK8ZXd9jmMhP4GGS3HKcigI3i T1oBA5IcML5CO9BrsvJIWbC5DXA+DxtBsUOTRiIkiEtP9mlpIBa6f7gCrsqHoJQrBxLHPnKfbNrti wUyKNTjANBOtk3sG4NkZT2KPdmn+3wrwP0frnNM28S8VNZAiccdT4+UAPm/qUuWTtDDV5PQY6kAZi dtQOPMrMwLhkxmvQqF8gQNN7qjxcl6j4q+JmE2V1541o6dNfgvCkgCgZzueuxOOWGvJGqBKxEe/+e 10LU507Q==; Received: from [187.19.173.117] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1rAaTK-0029mv-9j; Tue, 05 Dec 2023 18:48:42 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3CE7F40094; Tue, 5 Dec 2023 15:48:38 -0300 (-03) Date: Tue, 5 Dec 2023 15:48:38 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ilkka Koskinen , Ian Rogers , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Kajol Jain , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] perf metrics: Avoid segv if default metricgroup isn't set Message-ID: References: <20231204182330.654255-1-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gVHVlLCBEZWMgMDUsIDIwMjMgYXQgMDk6MjQ6NDJBTSAtMDgwMCwgTmFtaHl1bmcgS2ltIGVz Y3JldmV1Ogo+IEhpIEFybmFsZG8sCj4gCj4gT24gVHVlLCBEZWMgNSwgMjAyMyBhdCA3OjUx4oCv QU0gQXJuYWxkbyBDYXJ2YWxobyBkZSBNZWxvIDxhY21lQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4K PiA+IEVtIE1vbiwgRGVjIDA0LCAyMDIzIGF0IDA3OjMzOjE4UE0gLTA4MDAsIE5hbWh5dW5nIEtp bSBlc2NyZXZldToKPiA+ID4gT24gTW9uLCBEZWMgNCwgMjAyMyBhdCAyOjQ14oCvUE0gSWxra2Eg S29za2luZW4gPGlsa2thQG9zLmFtcGVyZWNvbXB1dGluZy5jb20+IHdyb3RlOgo+ID4gPiA+IE9u IE1vbiwgNCBEZWMgMjAyMywgSWFuIFJvZ2VycyB3cm90ZToKPiA+ID4gPiA+IEEgbWV0cmljIGlz IGRlZmF1bHQgYnkgaGF2aW5nICJEZWZhdWx0IiB3aXRoaW4gaXRzIGdyb3Vwcy4gVGhlIGRlZmF1 bHQKPiA+ID4gPiA+IG1ldHJpY2dyb3VwIG5hbWUgbmVlZG4ndCBiZSBzZXQgYW5kIHRoaXMgY2Fu IHJlc3VsdCBpbiBzZWd2IGluCj4gPiA+ID4gPiBkZWZhdWx0X21ldHJpY2dyb3VwX2NtcCBhbmQg cGVyZl9zdGF0X19wcmludF9zaGFkb3dfc3RhdHNfbWV0cmljZ3JvdXAKPiA+ID4gPiA+IHRoYXQg YXNzdW1lIGl0IGhhcyBhIHZhbHVlIHdoZW4gdGhlcmUgaXMgYSBEZWZhdWx0IG1ldHJpYyBncm91 cC4gVG8KPiA+ID4gPiA+IGF2b2lkIHRoZSBzZWd2IGluaXRpYWxpemUgdGhlIHZhbHVlIHRvICIi Lgo+ID4KPiA+ID4gPiA+IEZpeGVzOiAxYzBlNDc5NTZhOGUgKCJwZXJmIG1ldHJpY3M6IFNvcnQg dGhlIERlZmF1bHQgbWV0cmljZ3JvdXAiKQo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSWFuIFJv Z2VycyA8aXJvZ2Vyc0Bnb29nbGUuY29tPgo+ID4KPiA+ID4gPiBUaGFua3MhIEkgd2FzIGdvaW5n IHRvIGxvb2sgZm9yIHRoZSBidWcgYnV0IGdvdCBwdWxsZWQgdG8gb3RoZXIKPiA+ID4gPiB0YXNr cy4gVGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUgYW5kIEkgdGVzdGVkIGl0IHN1Y2Nlc3NmdWxs eSBvbgo+ID4gPiA+IEFtcGVyZU9uZS4KPiA+Cj4gPiA+ID4gICAgUmV2aWV3ZWQtYW5kLXRlc3Rl ZC1ieTogSWxra2EgS29za2luZW4gPGlsa2thQG9zLmFtcGVyZWNvbXB1dGluZy5jb20+Cj4gPgo+ ID4gPiBMb29rcyBsaWtlIGl0IG5lZWRzIHRvIGdvIHRocm91Z2ggcGVyZi10b29scyBmb3IgdjYu Ny4KPiA+ID4gSWFuLCBkbyB5b3UgdGhpbmsgdGhpcyBvbmUgaXMgZW5vdWdoPwo+ID4KPiA+IFNv IEkgaGFkIHRoaXMgb24gbXkgbG9jYWwgcGVyZi10b29scy1uZXh0LCByZW1vdmVkIG5vdywgSSBh bHNvIGhhdmUgc29tZQo+ID4gb3RoZXIgZml4ZXMgYnkgSWFuIG9uIHRoZSB0bXAucGVyZi10b29s cy1uZXh0LCBwbGVhc2UgbGV0IG1lIGtub3cgd2hhdAo+ID4geW91IGd1eXMgZGVjaWRlIHRvIGhh dmUgaW4gcGVyZi10b29scyBmb3IgdjYuNyBzbyB0aGF0IEkgY2FuIHJlbW92ZSBpdAo+ID4gZnJv bSB0aGVyZS4KPiAKPiBJIHRoaW5rIHdlIG5lZWQgdGhpcyBvbmUgYW5kIHRoZSBBbXBlcmUgZGVm YXVsdC1tZXRyaWMtZ3JvdXAgZml4Lgo+IAo+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAy MzEyMDEwMjE1NTAuMTEwOTE5Ni0yLWlsa2thQG9zLmFtcGVyZWNvbXB1dGluZy5jb20vCj4gCj4g QWxzbyBwZXJmIGxpc3QgSlNPTiBmaXggY2FuIGdvIHRvIHY2LjcuCj4gCj4gaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvci8yMDIzMTEyOTIxMzQyOC4yMjI3NDQ4LTItaXJvZ2Vyc0Bnb29nbGUuY29t LwoKT2ssIHJlbW92ZWQgYm90aCwgcGxlYXNlIGF1Z21lbnQgdGhlIGxhdGVyIGRlc2NyaXB0aW9u IHRvOgoKInBlcmYgbGlzdDogRml4IEpTT04gc2VnZmF1bHQgYnkgc2V0dGluZyB0aGUgdXNlZCBz a2lwX2Z1cGxpY2F0ZV9wbXVzIGNhbGxiYWNrIgoKVGhlIG9yaWdpbmFsIGRlc2NyaXB0aW9uIHdh cyB2YWd1ZSwgaW1wcm92aW5nIGl0IGEgYml0IGxpa2UgdGhhdCBoZWxwcwp3aGVuIGp1c3QgbG9v a2luZyBhdCB0aGUgb3V0cHV0IG9mICJnaXQgbG9nIC0tb25lbGluZSIuCgpUaGFua3MsCgotIEFy bmFsZG8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==