From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5A0DA4 for ; Fri, 24 Nov 2023 02:27:20 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1r6TP2-0036OO-Gi; Fri, 24 Nov 2023 18:27:17 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Nov 2023 18:27:25 +0800 Date: Fri, 24 Nov 2023 18:27:25 +0800 From: Herbert Xu To: Eric Biggers Cc: Linux Crypto Mailing List , Ard Biesheuvel Subject: Re: [PATCH 4/8] crypto: skcipher - Add lskcipher Message-ID: References: <20230914082828.895403-1-herbert@gondor.apana.org.au> <20230914082828.895403-5-herbert@gondor.apana.org.au> <20230920062551.GB2739@sol.localdomain> <20230922031030.GB935@sol.localdomain> <20231117054231.GC972@sol.localdomain> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 17, 2023 at 05:07:22PM +0800, Herbert Xu wrote: > On Thu, Nov 16, 2023 at 09:42:31PM -0800, Eric Biggers wrote: > . > > crypto_lskcipher_crypt_sg() assumes that a single en/decryption operation can be > > broken up into multiple ones. I think you're arguing that since there's no OK I see where some of the confusion is coming from. The current skcipher interface assumes that the underlying algorithm can be chained. So the implementation of chacha is actually wrong as it stands and it will produce incorrect results when used through if_alg. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt