From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set()
Date: Fri, 24 Nov 2023 13:13:12 +0200 [thread overview]
Message-ID: <ZWCFSGLB6LEzH979@smile.fi.intel.com> (raw)
In-Reply-To: <20231124053339.GG1074920@black.fi.intel.com>
On Fri, Nov 24, 2023 at 07:33:39AM +0200, Mika Westerberg wrote:
> On Wed, Nov 22, 2023 at 07:50:36PM +0200, Andy Shevchenko wrote:
> > When unpacked, the config value is split to two of different types.
> > Fix the types accordingly.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> There was one typo which I commented (please fix when applying).
> Otherwise the series looks good to me,
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Fixed locally.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-11-24 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 17:50 [PATCH v1 1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set() Andy Shevchenko
2023-11-22 17:50 ` [PATCH v1 2/4] pinctrl: baytrail: Factor out byt_gpio_force_input_mode() Andy Shevchenko
2023-11-23 14:53 ` Linus Walleij
2023-11-22 17:50 ` [PATCH v1 3/4] pinctrl: baytrail: Move default strength assignment to a switch-case Andy Shevchenko
2023-11-23 14:54 ` Linus Walleij
2023-11-24 5:31 ` Mika Westerberg
2023-11-22 17:50 ` [PATCH v1 4/4] pinctrl: baytrail: Simplify code with cleanup helpers Andy Shevchenko
2023-11-23 14:54 ` Linus Walleij
2023-11-24 5:33 ` [PATCH v1 1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set() Mika Westerberg
2023-11-24 11:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWCFSGLB6LEzH979@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.