From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD191EB54 for ; Fri, 24 Nov 2023 11:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85693C433C9; Fri, 24 Nov 2023 11:47:40 +0000 (UTC) Date: Fri, 24 Nov 2023 11:47:38 +0000 From: Catalin Marinas To: Huang Shijie Cc: will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4] arm64: irq: set the correct node for VMAP stack Message-ID: References: <20231124031513.81548-1-shijie@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124031513.81548-1-shijie@os.amperecomputing.com> On Fri, Nov 24, 2023 at 11:15:13AM +0800, Huang Shijie wrote: > In current code, init_irq_stacks() will call cpu_to_node(). > The cpu_to_node() depends on percpu "numa_node" which is initialized in: > arch_call_rest_init() --> rest_init() -- kernel_init() > --> kernel_init_freeable() --> smp_prepare_cpus() > > But init_irq_stacks() is called in init_IRQ() which is before > arch_call_rest_init(). > > So in init_irq_stacks(), the cpu_to_node() does not work, it > always return 0. In NUMA, it makes the node 1 cpu accesses the IRQ stack which > is in the node 0. > > This patch fixes it by: > 1.) export the early_cpu_to_node(), and use it in the init_irq_stacks(). > 2.) change init_irq_stacks() to __init function. > > Reviewed-by: Catalin Marinas > Signed-off-by: Huang Shijie > --- > v3 --> v4: > 1.) keep early_cpu_to_node() as __init function. > 2.) change init_irq_stacks() to __init function. > > --- > arch/arm64/kernel/irq.c | 5 +++-- > drivers/base/arch_numa.c | 2 +- > include/asm-generic/numa.h | 2 ++ > 3 files changed, 6 insertions(+), 3 deletions(-) Greg, Rafael - any objections to taking this patch through the arm64 tree? -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF37BC61D97 for ; Fri, 24 Nov 2023 11:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EDaOcIL0UN4/pGVYt7sNaynXa6LxOtCh4SIFew4z8bE=; b=anwYIOHM2kfI0Y PZSFMtXaiXMbKXdvHOx7d9/qk3B61GFV6WZjk+UfxeGMRSenUW5xIbounwFk0WoW+qinY6s4UhsY3 gfvg9YO8wRkSqVGkSPRd/5G+FEoLyWaw1SGUFieyc/Zi76os1fQ6feaIwmPZ+QZzM42j9MLbmEeoR 30dO4MibaBvHsnH9swAseff6tF6xMRBKh10PiXIvgfp/E4VuwbuZJ01zlUqSWwRBsvvg88xUBzQFN 8JRs9K/CRADJ1vhXGyweoeWQjlzRDtQqy3VrssI2AiTFPI7vabHYflTHJcp+OR5s9qMPJMHlzyJ6y h/vkjqSncWtQPCxL7l8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6Uev-00714B-2i; Fri, 24 Nov 2023 11:47:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6Uet-00712x-0d for linux-arm-kernel@lists.infradead.org; Fri, 24 Nov 2023 11:47:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 60931621B8; Fri, 24 Nov 2023 11:47:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85693C433C9; Fri, 24 Nov 2023 11:47:40 +0000 (UTC) Date: Fri, 24 Nov 2023 11:47:38 +0000 From: Catalin Marinas To: Huang Shijie Cc: will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4] arm64: irq: set the correct node for VMAP stack Message-ID: References: <20231124031513.81548-1-shijie@os.amperecomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231124031513.81548-1-shijie@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_034743_298858_C2C047FF X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 24, 2023 at 11:15:13AM +0800, Huang Shijie wrote: > In current code, init_irq_stacks() will call cpu_to_node(). > The cpu_to_node() depends on percpu "numa_node" which is initialized in: > arch_call_rest_init() --> rest_init() -- kernel_init() > --> kernel_init_freeable() --> smp_prepare_cpus() > > But init_irq_stacks() is called in init_IRQ() which is before > arch_call_rest_init(). > > So in init_irq_stacks(), the cpu_to_node() does not work, it > always return 0. In NUMA, it makes the node 1 cpu accesses the IRQ stack which > is in the node 0. > > This patch fixes it by: > 1.) export the early_cpu_to_node(), and use it in the init_irq_stacks(). > 2.) change init_irq_stacks() to __init function. > > Reviewed-by: Catalin Marinas > Signed-off-by: Huang Shijie > --- > v3 --> v4: > 1.) keep early_cpu_to_node() as __init function. > 2.) change init_irq_stacks() to __init function. > > --- > arch/arm64/kernel/irq.c | 5 +++-- > drivers/base/arch_numa.c | 2 +- > include/asm-generic/numa.h | 2 ++ > 3 files changed, 6 insertions(+), 3 deletions(-) Greg, Rafael - any objections to taking this patch through the arm64 tree? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel