From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCB47C61DF4 for ; Fri, 24 Nov 2023 16:08:55 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RlFsV7mZ; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RlFsV7mZ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ScKfZ3Hsjz3vcP for ; Sat, 25 Nov 2023 03:08:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RlFsV7mZ; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RlFsV7mZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ScKdZ40YDz3d8p for ; Sat, 25 Nov 2023 03:08:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700842079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=suN3V9rM6JohMwlCsG7PmWxd2SZ7oRR+3sWHfaA95QU=; b=RlFsV7mZ9Lb9QzQIvEy/FOIlM7UbxltRo8lrVElA4dAoLlY7xBUVeRj6/82uNn1VHPgijM nJoMSL5rJiQVvCc9VGZlKbSLCD0zlI6oPN4jnITQs+H6qQuZ263Okd2PB9k/vBDcNchYnl BwVawC60N4elkIY2VKAcugRQpPEmxW0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700842079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=suN3V9rM6JohMwlCsG7PmWxd2SZ7oRR+3sWHfaA95QU=; b=RlFsV7mZ9Lb9QzQIvEy/FOIlM7UbxltRo8lrVElA4dAoLlY7xBUVeRj6/82uNn1VHPgijM nJoMSL5rJiQVvCc9VGZlKbSLCD0zlI6oPN4jnITQs+H6qQuZ263Okd2PB9k/vBDcNchYnl BwVawC60N4elkIY2VKAcugRQpPEmxW0= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645--5K5v96uNCWBj_00SOZU9w-1; Fri, 24 Nov 2023 11:07:55 -0500 X-MC-Unique: -5K5v96uNCWBj_00SOZU9w-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4239693aebcso1211551cf.1 for ; Fri, 24 Nov 2023 08:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700842075; x=1701446875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=suN3V9rM6JohMwlCsG7PmWxd2SZ7oRR+3sWHfaA95QU=; b=CHdFG0gUFCsjbwKzRSfk7gC7qXW50nuIVOMKClFbWN5+UkudWltxetS929U/AcEAcE T4RtNO5JCmj7qCrmdg++qOIROVCnZbEv6Oc2xnJpgt09abQEdCmP+QsfPHkqse+sYwKj /LcKHCiUOoGfsKAAMM4sf/rpOY/tmd9nKuf0oGXqdzWbWgAVTHyDC+Xtpyvltr2c0ZkU k/YHADYLxIhYKgG9GOyWWiB8LXrsfwjsyM35gr4EX0nbVwINM4iIpy4rVQq51sRKjfzx PzIf/xbVjoGH+elUCFz8oC+nCtiCv8XyQNNmi1NiTxxl2IOP7OUDIlZ1RW90igpEpPqV 4EvQ== X-Gm-Message-State: AOJu0Yyw/WxlPb8ns6JC4pfcKTKU0zcH5I2Eywb4kYhF2HXH/X4sGP4t b6P9jm9jo9C0DhSPswPE+IfhKw2zFqH+2SlV3iJfSVfsgrDmzcGoyNWZG09fyBxdKROtRwGXxJt jVHxf2O21xrQVbC/m9SqQP+ofNw== X-Received: by 2002:a05:622a:199a:b0:421:aed7:d588 with SMTP id u26-20020a05622a199a00b00421aed7d588mr3709088qtc.5.1700842075390; Fri, 24 Nov 2023 08:07:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOd7ZcfkjfEnW/YGYpjdepTXsBQmefBUFY1Iktas3x8VnzCdZbnMDFzkUAABAl6vehhFBtZg== X-Received: by 2002:a05:622a:199a:b0:421:aed7:d588 with SMTP id u26-20020a05622a199a00b00421aed7d588mr3709008qtc.5.1700842074459; Fri, 24 Nov 2023 08:07:54 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id cf9-20020a05622a400900b0042380fb7ba0sm275601qtb.7.2023.11.24.08.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 08:07:54 -0800 (PST) Date: Fri, 24 Nov 2023 11:07:51 -0500 From: Peter Xu To: Ryan Roberts Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> <510adc26-9aed-4745-8807-dba071fadbbe@arm.com> MIME-Version: 1.0 In-Reply-To: <510adc26-9aed-4745-8807-dba071fadbbe@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , linux-mm@kvack.org, Mike Rapoport , Jason Gunthorpe , "Kirill A . Shutemov" , Axel Rasmussen , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Vlastimil Babka , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 24, 2023 at 09:06:01AM +0000, Ryan Roberts wrote: > I don't have any micro-benchmarks for GUP though, if that's your question. Is > there an easy-to-use test I can run to get some numbers? I'd be happy to try it out. Thanks Ryan. Then nothing is needed to be tested if gup is not yet touched from your side, afaict. I'll see whether I can provide some rough numbers instead in the next post (I'll probably only be able to test it in a VM, though, but hopefully that should still reflect mostly the truth). -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F98C61D97 for ; Fri, 24 Nov 2023 16:08:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 533518D0084; Fri, 24 Nov 2023 11:08:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3126B067C; Fri, 24 Nov 2023 11:08:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 384C88D0084; Fri, 24 Nov 2023 11:08:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 270756B067B for ; Fri, 24 Nov 2023 11:08:01 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F372EB63AB for ; Fri, 24 Nov 2023 16:08:00 +0000 (UTC) X-FDA: 81493329120.16.E1EB4C7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id B14B480028 for ; Fri, 24 Nov 2023 16:07:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aIHiIM15; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700842078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=suN3V9rM6JohMwlCsG7PmWxd2SZ7oRR+3sWHfaA95QU=; b=ILR3iTNzhC1/+YXmhlG3cM7IMRrqLQCl3EbvpqPlrgEwmhTVuHMqDcrallD3iyp9hW6vw8 fCtF29r612CzMgrVq/C0mMXRlHAyyusMeLELl+Et2xGB1yO6369PPsVbamYZAf83pDEyER b15z1sdL3kVQL+Cn9JfyjRIkF10Mc2U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700842078; a=rsa-sha256; cv=none; b=Ecn6EWfl6uPEoQW7HrC1D8zmmwq1Ff1e981WHxUBiic1cZx3B9xzmcsdJPPuYilMNSxuL0 n1VWr76aFTUTI0CNglT+/AAITi/z6SPsEOuoETVChFzskyCyMgkRaNUGqw03YrRAMbn2Bl OU3gwNautV/mzeuRmnzA7+Eyct/Hb4I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aIHiIM15; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700842077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=suN3V9rM6JohMwlCsG7PmWxd2SZ7oRR+3sWHfaA95QU=; b=aIHiIM15NTT9T9qSPGtHyNmKHbZ951tQHgdH/TMWA534tG4jke0tKqBi63kdKEaRqYFCit Dty6Skd+31n3JdTnN6dxwct2fr+R2mYG1sheU3yMDnPM37ZCjypr77kd9CDxPzRcmCzBFP OPbBNdGy2QTgQzvppZ1OjghmrwHqWXI= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-AnUekxabONetbDkbs-rxpA-1; Fri, 24 Nov 2023 11:07:55 -0500 X-MC-Unique: AnUekxabONetbDkbs-rxpA-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4239693aebcso1211531cf.1 for ; Fri, 24 Nov 2023 08:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700842075; x=1701446875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=suN3V9rM6JohMwlCsG7PmWxd2SZ7oRR+3sWHfaA95QU=; b=YR8hSGGxoM7GDtjs/o+CnSuT3Gwtr9i0Jrz0uTlHPjq2Fhy6OzcHuWJpg5fLTj51Oi +h8ptPtbVTKhPZq9s8nJYx255cSD6uTpTvdK8w8hjJ65kXd4ZuwMQNUxQYMJcCFQgzsH mkUU9nS2H3LpC12/hJEmjnXl8QsSSCKRpvkCtgSJW5Kj4oHIuJTFrogNgUIS0MtsYd/6 aiIWTny03Cc6kmOZYtN8hu/dngnWq3nqe798UI6OpSW0Pj04zUO1tUCKBP+PAcObwL3z GCJCZZqY6s+6fVGYgDQhClFzpczbRds7vFjUtodTNHTU6VtrvBKuO5Zd2CMiRdjyCQj8 AArA== X-Gm-Message-State: AOJu0YyB2idlux20TOBDwO/Y4s+YFh3dDPeTl4qMi9lyzFBKmrDd8NBh ju/OyLwBGGoPOTy+R8JmuhlnlTmQaCnNXJyNlwm1Zhyxx+pT+vYgmQjmAp1XeWknqR3yryyTeRv AgPQYlDyLJFE= X-Received: by 2002:a05:622a:199a:b0:421:aed7:d588 with SMTP id u26-20020a05622a199a00b00421aed7d588mr3709083qtc.5.1700842075384; Fri, 24 Nov 2023 08:07:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOd7ZcfkjfEnW/YGYpjdepTXsBQmefBUFY1Iktas3x8VnzCdZbnMDFzkUAABAl6vehhFBtZg== X-Received: by 2002:a05:622a:199a:b0:421:aed7:d588 with SMTP id u26-20020a05622a199a00b00421aed7d588mr3709008qtc.5.1700842074459; Fri, 24 Nov 2023 08:07:54 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id cf9-20020a05622a400900b0042380fb7ba0sm275601qtb.7.2023.11.24.08.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 08:07:54 -0800 (PST) Date: Fri, 24 Nov 2023 11:07:51 -0500 From: Peter Xu To: Ryan Roberts Cc: Matthew Wilcox , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> <510adc26-9aed-4745-8807-dba071fadbbe@arm.com> MIME-Version: 1.0 In-Reply-To: <510adc26-9aed-4745-8807-dba071fadbbe@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: B14B480028 X-Rspam-User: X-Stat-Signature: j83uk97xa1ciecnb9bwqyozrecbweefh X-Rspamd-Server: rspam03 X-HE-Tag: 1700842078-165808 X-HE-Meta: U2FsdGVkX1/wUJmduZxYlvtMdfk7HmjZZiMVH/+yqiEvfZdLMvGlGmRSYvSr2RujTQ0SxmdCjtBjgkxWpqB/rpL+cqx1pm1SoA3rXJTM9mQixYWnEoBynDJoO3WvejEPQE3FeSrq563WmAdVFeeaNrKeMfNRgBFgreMrvlgOylVOqBZx8PHpUclKc4cDQY2rjR/mndBzpuFtpffLAo/XDg+ll+mBdPriEqDm/6twnkhGvMimPzGDBTiwgOSwj+72jB2OxkK5Iwp1uHOdygGl+heWmcaLrCCQrah7v6GItFeJ/13S97db6Px7j1E85lxu9DxPtqBZpbJmQAncWiwVSsSVP+zYH7NcELmdxyjKUAK8+KZJPHU3mdME8IyghuTe7gJgn0+R9pZg/W+E6v1E25CV5kO4raYStoE4oPwnBPamiTTudVaCskMEEpnOEilLbwSuJ7CkUT1wcwv1r1DAovHY4v3LRJVCyt+TKtyo34P6Ds8KgEA0itR4tjQ7LHf8T8LLjqr0I24jWk418xAeWnqFGs6oKVB2CBGU+SLxPcGA5ZFSmW0UGHNGjB94Lo591Pb7XRAObFmsUEfQ95fGIn4rzjIsCagQFmEz0KbzVFfL2NtHY++0Yk5D3Rujk4WLb34mXUQ/RdIMMkXXuNG74W0DvD0d+720DgflV4YA6Yjp20rAcJtw4NBPeiDYH2WwbRl5iPysbG2GLRHB2OTAWnUJu6+M5rDkztafnv6dVf/MzAlQ3YEzwuRZ98war8Xxy88duYKIOsc6Yix1eLflt9+nUlj36ZNd8j958Ynn0yRT5i9a7eu7pEWjWWwbx7HKKEXKfuDMZVNcSSHWTx42jaHq8OnsMhkd4YpkiU+PnO0NyZp/huVscSfv/RmPvxxTwdm8r4nE/dXsHYYYGd3R+GpGTra1zvV3qEK4z4rL0kRdj5ZifpzA+CD4GMXyHBnIWox2Gn9Lz1vYJ3Ibtp1 0ea/gXCT 32Xto68WPUiTBIjwDqcM6pwFmCVwqMd5YU48vT/qnTPOODcW1bmXLZeFV/hKDzKc18LvJlqgRMAVxg9nmvlaQE2HoP0XoiAy0AUKLRSWjG9c0STjOfZUu/ClRCyKoOMBjtdHXwiWpYyY2EXr7mOHHxZUIY2sc/92uAlWQ/SlcPj1AgFF5b4t67244EqODsB59UO6MylVuTovwNPr21b24L4y8nLnFomvt92QaMYAj7k+0qwdlyfcj5TXGIMYGgFJBU0q/JkqJ7i3yQlHRy8ayK4IRxykpxwjoL+enbPtjnHhQNZIO4SdWGe8/h9rq0FC7LfqjmbTAdui+puXmAst8sCHZiV8gLR0Fy0Dk1yjRwz1lTXdeAAsz6Y8hGTdKOXZu6L+jKNW+w5zDiDUIujkgt+ZiFXadS4fR+9hG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 09:06:01AM +0000, Ryan Roberts wrote: > I don't have any micro-benchmarks for GUP though, if that's your question. Is > there an easy-to-use test I can run to get some numbers? I'd be happy to try it out. Thanks Ryan. Then nothing is needed to be tested if gup is not yet touched from your side, afaict. I'll see whether I can provide some rough numbers instead in the next post (I'll probably only be able to test it in a VM, though, but hopefully that should still reflect mostly the truth). -- Peter Xu