Re: posix_memalign(3)

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Hi Jonny,

On Fri, Nov 17, 2023 at 10:03:58PM +0000, Jonny Grant wrote:
> Hello
> 
> Some feedback, suggestions.
> 
> https://man7.org/linux/man-pages/man3/posix_memalign.3.html
> "ENOMEM There was insufficient memory to fulfill the allocation request."
> 
> Rather wordy, how about "ENOMEM Out of memory" ? that would match malloc(3)

LGTM

> 
> 
> There are quite a few extra words in the description, how about simplifying:
> 
> Orig:
> "The function posix_memalign() allocates size bytes and places the
> address of the allocated memory in *memptr. "
> 
> Simplification:
> "posix_memalign() allocates size bytes and places the

LGTM

> allocated memory address in *memptr."

This doesn't convince me.  I've applied patches for all the other
suggestions.

> 
> Another one.
> Orig:
> "The function aligned_alloc() is the same as memalign(), except
> for the added restriction that size should be a multiple of
> alignment."
> 
> simplification:
> 
> "aligned_alloc() is the same as memalign(), except

LGTM

> for the added restriction that size should be a multiple of
> alignment.
> 
> Kind regards, Jonny

Thanks,
Alex

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]