From: Jeff LaBundy <jeff@labundy.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Anshul Dalal <anshulusr@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] input: joystick: driver for Adafruit Seesaw Gamepad
Date: Sat, 25 Nov 2023 16:39:44 -0600 [thread overview]
Message-ID: <ZWJ3sFfrVQA3djmi@nixie71> (raw)
In-Reply-To: <d1dd2142-546f-42b7-8966-ab75fd4f8817@t-8ch.de>
Hi Thomas and Anshul,
On Fri, Oct 27, 2023 at 06:14:58AM +0000, Thomas Weißschuh wrote:
[...]
> > +struct seesaw_data {
> > + __be16 x;
> > + __be16 y;
>
> The fact that these are big endian is now an implementation detail
> hidden within seesaw_read_data(), so the __be16 can go away.
>
> > + u32 button_state;
> > +} __packed;
>
> While this was requested by Jeff I don't think it's correct.
> The struct is never received in this form from the device.
> I guess he also got confused, like me, by the fact that data is directly
> read into the fields of the struct.
Apologies for some confusion on my part here; Thomas is correct and
my comment can be disregarded. Originally I thought this struct was
mapped to a continguous range of registers, but after studying the
documentation some more, that is clearly not the case :)
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2023-11-25 22:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 5:18 [PATCH v6 1/2] dt-bindings: input: bindings for Adafruit Seesaw Gamepad Anshul Dalal
2023-10-27 5:18 ` Anshul Dalal
2023-10-27 5:18 ` [PATCH v6 2/2] input: joystick: driver " Anshul Dalal
2023-10-27 5:18 ` Anshul Dalal
2023-10-27 6:14 ` Thomas Weißschuh
2023-10-27 6:14 ` Thomas Weißschuh
2023-10-31 2:09 ` Anshul Dalal
2023-10-31 2:09 ` Anshul Dalal
2023-10-31 2:23 ` Thomas Weißschuh
2023-10-31 2:23 ` Thomas Weißschuh
2023-11-01 4:20 ` Anshul Dalal
2023-11-01 4:20 ` Anshul Dalal
2023-11-01 8:45 ` Thomas Weißschuh
2023-11-01 8:45 ` Thomas Weißschuh
2023-11-25 22:39 ` Jeff LaBundy [this message]
2023-10-30 6:56 ` Dmitry Torokhov
2023-10-30 6:56 ` Dmitry Torokhov
2023-10-31 2:05 ` Anshul Dalal
2023-10-31 2:05 ` Anshul Dalal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWJ3sFfrVQA3djmi@nixie71 \
--to=jeff@labundy.com \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.