From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54CD2C4167B for ; Mon, 27 Nov 2023 08:34:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B93FA84B; Mon, 27 Nov 2023 09:34:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B93FA84B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701074093; bh=unCaXJLxTUPj78Mw3wAj0N85QPztmDRO+DsnNzOcHyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=GiVpnWZ23sr7KQGOANzIzhg2LRlyexs05lJUYlxIaQPuZFOan6lGZrWkZcrzWaL/6 xoBGLL2YTZLMC0N28gz4QaZTr2oG0bbqoq5hOJCcvG1laUwufy6Dy4y+8H72wafWoW lmgYRwYJfXsTjGne+Y2b13Sz6vuUq7IljHq8dR7w= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30057F8057A; Mon, 27 Nov 2023 09:34:22 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id CAA5DF80589; Mon, 27 Nov 2023 09:34:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E7D34F801D5; Mon, 27 Nov 2023 09:34:17 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A9817F800F5 for ; Mon, 27 Nov 2023 09:34:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A9817F800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=eeGLYqfH Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D64356103E; Mon, 27 Nov 2023 08:34:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804CDC433C7; Mon, 27 Nov 2023 08:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701074051; bh=unCaXJLxTUPj78Mw3wAj0N85QPztmDRO+DsnNzOcHyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eeGLYqfHsnH5C6JZJowFVGo9N5tWStKUX+kM+DtxMi7feq8XDRqdrh5Kd71O7SOPv jcXSPKwkVBN/lTBdh6MAQMaoP9XelvBzA8LyL+R20UoV6Cs+fLQO7ldHpTAiHQA58e aZ+E4v/P+v+uD7kviN+GaxpOjy0gCd7+itWbRKSkjjUrYnLgBgqYUZoNrlpdB4+p88 ILOrEGU5g+6zjXMkhdBNzJ4DqEkYDEoVvu93RwXhbsXevJu2Mj21tpj1itZ59FcsqV he+pXIMym5Br9bRJdUZtYR3TuJET+EoeXlw16FnAF93Y996DFyICivSTRIH6uL3QBU Ys7Jt98Wddt+w== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r7X4f-0002ln-0B; Mon, 27 Nov 2023 09:34:37 +0100 Date: Mon, 27 Nov 2023 09:34:37 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [RFC PATCH 0/2] ASoC: soc-dai: add flag to mute and unmute stream during trigger. Message-ID: References: <20231027105747.32450-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Message-ID-Hash: NCRGMSOKRPZEBIYDGD3G2ZWQUN63VT72 X-Message-ID-Hash: NCRGMSOKRPZEBIYDGD3G2ZWQUN63VT72 X-MailFrom: johan@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 01:52:11PM +0200, Johan Hovold wrote: > On Fri, Oct 27, 2023 at 11:57:45AM +0100, Srinivas Kandagatla wrote: > > Click/Pop Noise was a long pending issue with WSA Codecs which are prone > > to accumlate DC when ports are active but without any data streams. > > There are multiple places in the current setup, where this could happen > > in both startup as well as shutdown path. > > > > This patchset adds a new flag mute_unmute_on_trigger to dai_ops to let > > generic code do the mute/unmute on trigger. > > > > This patches help fix those issues by making sure the PA is Muted/Unmuted > > inline with the stream start/stop events. > > > > Srinivas Kandagatla (2): > > ASoC: soc-dai: add flag to mute and unmute stream during trigger > > ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag > > I've verified that this fixes the pop sounds when starting and stopping > a stream on the X13s, even if the click sound when killing pulseaudio > (e.g. on reboot) is still there (as with the previous fixes). For the record, the remaining click sounds were incidentally fixed by commit 3efcb471f871 ("ASoC: soc-pcm.c: Make sure DAI parameters cleared if the DAI becomes inactive") which also went into 6.7-rc1: https://lore.kernel.org/lkml/20230920153621.711373-1-chancel.liu@nxp.com/ Johan