Re: [RFC] docs/s390: Fix wrong command example in s390-cpu-topology.rst

[Zhao Liu <zhao1.liu@linux.intel.com>]

Hi Nina,

On Mon, Nov 27, 2023 at 01:58:32PM +0100, Nina Schoetterl-Glausch wrote:
> Date: Mon, 27 Nov 2023 13:58:32 +0100
> From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> Subject: Re: [RFC] docs/s390: Fix wrong command example in
>  s390-cpu-topology.rst
> 
> On Mon, 2023-11-27 at 17:39 +0800, Zhao Liu wrote:
> > From: Zhao Liu <zhao1.liu@intel.com>
> > 
> > From s390_possible_cpu_arch_ids() in hw/s390x/s390-virtio-ccw.c, the
> > "core-id" is the index of pssible_cpus->cpus[], so it should only be
> 
> s/pssible_cpus/possible_cpus/

Thanks!

> 
> > less than possible_cpus->len, which is equal to ms->smp.max_cpus.
> > 
> > Fix the wrong "core-id" 112 because it is greater than maxcpus (36) in
> 
> Maybe s/is greater/isn't less/ since the valid ids are 0-35 inclusive.

Ok.

> 
> > -smp.
> > 
> > Cc: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> 
> Reviewed-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>

Thanks! Let me refresh a new version quickly.

-Zhao