* [PATCH] perf/tests:coresight:remove unused variables
@ 2023-11-15 6:42 zhujun2
2023-11-15 14:00 ` James Clark
0 siblings, 1 reply; 3+ messages in thread
From: zhujun2 @ 2023-11-15 6:42 UTC (permalink / raw)
To: suzuki.poulose
Cc: mike.leach, james.clark, leo.yan, peterz, mingo, acme,
mark.rutland, alexander.shishkin, jolsa, namhyung, irogers,
adrian.hunter, coresight, linux-perf-users, zhujun2
These variables are never referenced in the code, just remove them.
Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
---
tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c | 1 -
tools/perf/tests/shell/coresight/thread_loop/thread_loop.c | 1 -
.../shell/coresight/unroll_loop_thread/unroll_loop_thread.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c b/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
index a7e169d1bf64..5f886cd09e6b 100644
--- a/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
+++ b/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
@@ -42,7 +42,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
int main(int argc, char **argv)
{
unsigned long i, len, size, thr;
- pthread_t threads[256];
struct args args[256];
long long v;
diff --git a/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c b/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c
index c0158fac7d0b..e05a559253ca 100644
--- a/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c
+++ b/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c
@@ -57,7 +57,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
int main(int argc, char **argv)
{
unsigned int i, len, thr;
- pthread_t threads[256];
struct args args[256];
if (argc < 3) {
diff --git a/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c b/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c
index 8f6d384208ed..0fc7bf1a25af 100644
--- a/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c
+++ b/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c
@@ -51,7 +51,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
int main(int argc, char **argv)
{
unsigned int i, thr;
- pthread_t threads[256];
struct args args[256];
if (argc < 2) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf/tests:coresight:remove unused variables
2023-11-15 6:42 [PATCH] perf/tests:coresight:remove unused variables zhujun2
@ 2023-11-15 14:00 ` James Clark
2023-11-27 14:36 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: James Clark @ 2023-11-15 14:00 UTC (permalink / raw)
To: zhujun2, suzuki.poulose
Cc: mike.leach, leo.yan, peterz, mingo, acme, mark.rutland,
alexander.shishkin, jolsa, namhyung, irogers, adrian.hunter,
coresight, linux-perf-users
On 15/11/2023 06:42, zhujun2 wrote:
> These variables are never referenced in the code, just remove them.
>
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> ---
> tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c | 1 -
> tools/perf/tests/shell/coresight/thread_loop/thread_loop.c | 1 -
> .../shell/coresight/unroll_loop_thread/unroll_loop_thread.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c b/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
> index a7e169d1bf64..5f886cd09e6b 100644
> --- a/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
> +++ b/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
> @@ -42,7 +42,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
> int main(int argc, char **argv)
> {
> unsigned long i, len, size, thr;
> - pthread_t threads[256];
> struct args args[256];
> long long v;
>
> diff --git a/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c b/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c
> index c0158fac7d0b..e05a559253ca 100644
> --- a/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c
> +++ b/tools/perf/tests/shell/coresight/thread_loop/thread_loop.c
> @@ -57,7 +57,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
> int main(int argc, char **argv)
> {
> unsigned int i, len, thr;
> - pthread_t threads[256];
> struct args args[256];
>
> if (argc < 3) {
> diff --git a/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c b/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c
> index 8f6d384208ed..0fc7bf1a25af 100644
> --- a/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c
> +++ b/tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c
> @@ -51,7 +51,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
> int main(int argc, char **argv)
> {
> unsigned int i, thr;
> - pthread_t threads[256];
> struct args args[256];
>
> if (argc < 2) {
Reviewed-by: James Clark <james.clark@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf/tests:coresight:remove unused variables
2023-11-15 14:00 ` James Clark
@ 2023-11-27 14:36 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-11-27 14:36 UTC (permalink / raw)
To: James Clark
Cc: zhujun2, suzuki.poulose, mike.leach, leo.yan, peterz, mingo,
mark.rutland, alexander.shishkin, jolsa, namhyung, irogers,
adrian.hunter, coresight, linux-perf-users
Em Wed, Nov 15, 2023 at 02:00:21PM +0000, James Clark escreveu:
> On 15/11/2023 06:42, zhujun2 wrote:
> > These variables are never referenced in the code, just remove them.
> >
> > Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> > ---
> > tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c | 1 -
> > tools/perf/tests/shell/coresight/thread_loop/thread_loop.c | 1 -
> > .../shell/coresight/unroll_loop_thread/unroll_loop_thread.c | 1 -
> > 3 files changed, 3 deletions(-)
> > +++ b/tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c
> > @@ -42,7 +42,6 @@ static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
> > int main(int argc, char **argv)
> > {
> > unsigned long i, len, size, thr;
> > - pthread_t threads[256];
> > struct args args[256];
> > long long v;
<SNIP>
> Reviewed-by: James Clark <james.clark@arm.com>
Thanks, applied to perf-tools-next.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-27 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-15 6:42 [PATCH] perf/tests:coresight:remove unused variables zhujun2
2023-11-15 14:00 ` James Clark
2023-11-27 14:36 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.