From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-iio@vger.kernel.org,
Matti Vaittinen <mazziesaccount@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Andre Werner <andre.werner@systec-electronic.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@denx.de>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Mark Brown <broonie@kernel.org>,
Naresh Solanki <naresh.solanki@9elements.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Rob Herring <robh+dt@kernel.org>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
Vincent Tremblay <vincent@vtremblay.dev>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: light: isl76682: Add ISL76682 driver
Date: Mon, 27 Nov 2023 18:13:05 +0200 [thread overview]
Message-ID: <ZWTAEWRreMir7x_T@smile.fi.intel.com> (raw)
In-Reply-To: <20231125222738.97875-2-marex@denx.de>
On Sat, Nov 25, 2023 at 11:26:23PM +0100, Marek Vasut wrote:
> The ISL76682 is very basic ALS which only supports ALS or IR mode
> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any
> other fancy functionality.
...
> + for (i = 0; i < ARRAY_SIZE(isl76682_range_table); i++) {
> + if (chan->type == IIO_LIGHT && val2 != isl76682_range_table[i].als)
> + continue;
> + if (chan->type == IIO_INTENSITY && val2 != isl76682_range_table[i].ir)
> + continue;
You forgot to drop indentation level for 'continue' lines.
> + scoped_guard(mutex, &chip->lock)
> + chip->range = isl76682_range_table[i].range;
> + return 0;
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-27 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 22:26 [PATCH v5 1/2] dt-bindings: iio: light: isl76682: Document ISL76682 Marek Vasut
2023-11-25 22:26 ` [PATCH v5 2/2] iio: light: isl76682: Add ISL76682 driver Marek Vasut
2023-11-26 18:16 ` Jonathan Cameron
2023-11-26 22:09 ` Marek Vasut
2023-12-01 18:17 ` Jonathan Cameron
2023-12-02 6:48 ` Marek Vasut
2023-12-04 11:13 ` Jonathan Cameron
2023-11-26 19:33 ` Dr.-Ing. Andre Werner
2023-11-26 22:17 ` Marek Vasut
2023-12-01 18:20 ` Jonathan Cameron
2023-12-02 6:46 ` Marek Vasut
2023-11-27 16:11 ` Andy Shevchenko
2023-11-27 16:13 ` Andy Shevchenko [this message]
2023-11-27 20:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWTAEWRreMir7x_T@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.werner@systec-electronic.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.ceresoli@bootlin.com \
--cc=marex@denx.de \
--cc=mazziesaccount@gmail.com \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
--cc=vincent@vtremblay.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.