From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18CE1C4167B for ; Tue, 28 Nov 2023 11:19:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F9A710E4DE; Tue, 28 Nov 2023 11:19:38 +0000 (UTC) Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBA1A10E4DE for ; Tue, 28 Nov 2023 11:19:34 +0000 (UTC) Received: by mail-vs1-xe2e.google.com with SMTP id ada2fe7eead31-462abe45730so1830283137.1 for ; Tue, 28 Nov 2023 03:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701170374; x=1701775174; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bCnoZKgpcEhOGCM5lZjXBdwz27cftHLpr/W77wEAkbk=; b=BR4lab2n/4GEsXR2CNzxLKS6nH26h/mFjTL6+vaHRmREDMsWo7P/f6EigQpNB0QXWz N7nESwf1y9PqTxSRo5AUPDNckUjCzAEQKOrKodg7asvaWdIVOOOTyCKXhcr1MgrNz9V8 nefzRvCXVw7z3LpwGsqfmrSSplOL7z1d+Eya8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701170374; x=1701775174; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bCnoZKgpcEhOGCM5lZjXBdwz27cftHLpr/W77wEAkbk=; b=lLs7TPuV9Hhmfq3b7Q6JQjVLzHmdOU5Ue/k3B8tok0W6Pka5S8R+HTQgpvG/+mzjoP 9P1S2E5Q6qi+kU9HyaJswCBKNhAGxHWr+Zxwt5ESDXPBXfOiKFPgDrcjZ2kObvpwRJAc LV5DwTelNmXv/G5ZDe3m6Cb7sHJicIcyJ10PxXAxG5Do2YgYU/Zk7/LvfgtDX25rrJPZ y00AD3IcGgCN7FI35ee9puFDf5oksJ6SsEDXdfZBIBqPFhpcaTi1EHsTUwJpRFDJ38Ni t0UJmbF+/WkcMqdQgB0Ye6kds8yPlkHawx7600u/72VK2dqE/WV1ytE7KUHGPqvlXkDd rElA== X-Gm-Message-State: AOJu0YzgT5yAbPFEa9z4zrly8lxVztkC/Oj5Gmvv3f0Vmxiuh7Nyfhu5 LGqRxq1hfjBISbxY1kJsGLg/UQ== X-Google-Smtp-Source: AGHT+IH87Ag0JlT90Hx66H+qK+YLeNQoRQwoQQDAx90SCLVYeMakySpUwE7/cgjUOuOsUEPWnqz5xw== X-Received: by 2002:a05:6102:34f5:b0:45f:bab9:4414 with SMTP id bi21-20020a05610234f500b0045fbab94414mr16425679vsb.24.1701170373973; Tue, 28 Nov 2023 03:19:33 -0800 (PST) Received: from google.com (193.132.150.34.bc.googleusercontent.com. [34.150.132.193]) by smtp.gmail.com with ESMTPSA id dw12-20020a0562140a0c00b0067a1c7d8e98sm3852798qvb.41.2023.11.28.03.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 03:19:33 -0800 (PST) Date: Tue, 28 Nov 2023 11:19:32 +0000 From: Paz Zcharya To: Andrzej Hajda Message-ID: References: <20231105172718.18673-1-pazz@chromium.org> <8dd6f4da-dcc9-4ea3-8395-bf048b0dbc93@intel.com> <6f08cfee-a60b-4f6e-b69a-20517c563259@intel.com> <51baffb9-2249-4080-a245-eb1e03c02b9b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51baffb9-2249-4080-a245-eb1e03c02b9b@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Subrata Banik , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Rodrigo Vivi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul , matthew.auld@intel.com, Daniel Vetter , Marcin Wojtas , Drew Davenport , David Airlie , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Nov 28, 2023 at 12:12:08PM +0100, Andrzej Hajda wrote: > On 28.11.2023 04:47, Paz Zcharya wrote: > > > > On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > > > Hey Andrzej, > > > > On a second thought, what do you think about something like > > > > + gen8_pte_t __iomem *gte = to_gt(i915)->ggtt->gsm; > > + gen8_pte_t pte; > > + gte += base / I915_GTT_PAGE_SIZE; > > + pte = ioread64(gte); > > + pte = pte & I915_GTT_PAGE_MASK; > > + phys_base = pte - i915->mm.stolen_region->region.start; > > > > The only difference is the last line. > > Bingo :) It seems to be generic algorithm to get phys_base for all > platforms: > - on older platforms stolen_region points to system memory which starts at > 0, > - on DG2 it uses lmem region which starts at 0 as well, > - on MTL stolen_region points to stolen-local which starts at 0x800000. > > So this whole "if (IS_DGFX(i915)) {...} else {...}" could be replaced > with sth generic. > 1. Find pte. > 2. if(IS_DGFX(i915) && pte & GEN12_GGTT_PTE_LM) mem = > i915->mm.regions[INTEL_REGION_LMEM_0] else mem = i915->mm.stolen_region > 3. phys_base = (pte & I915_GTT_PAGE_MASK) - mem->region.start; > > Regards > Andrzej > > Good stuff!! I'll work on this revision and resubmit. Thank you so much Andrzej! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D8DCC4167B for ; Tue, 28 Nov 2023 11:19:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A1A110E4B6; Tue, 28 Nov 2023 11:19:37 +0000 (UTC) Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC0CC10E4E0 for ; Tue, 28 Nov 2023 11:19:34 +0000 (UTC) Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-460f623392fso1830498137.0 for ; Tue, 28 Nov 2023 03:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701170374; x=1701775174; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bCnoZKgpcEhOGCM5lZjXBdwz27cftHLpr/W77wEAkbk=; b=BR4lab2n/4GEsXR2CNzxLKS6nH26h/mFjTL6+vaHRmREDMsWo7P/f6EigQpNB0QXWz N7nESwf1y9PqTxSRo5AUPDNckUjCzAEQKOrKodg7asvaWdIVOOOTyCKXhcr1MgrNz9V8 nefzRvCXVw7z3LpwGsqfmrSSplOL7z1d+Eya8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701170374; x=1701775174; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bCnoZKgpcEhOGCM5lZjXBdwz27cftHLpr/W77wEAkbk=; b=VyWKA5STzOooHlVsbzP/yzad6hUfCBRIKwz0B8Vv91i3uJH1VdXpNziWcAazfNHrj/ Pc1E0Mxf9D3vb8VZ4iiaptgl8Xj01j/nnUpKquaYeqt2w6g28EW/VOB6SYELKNJ10Qvt D1Q4yXgU6Q5u23+sIWsCpVBhGqsf6cLHJZgPj11LB+yWVAxUJOr6z9p96Rma7PG31FK8 5k3Lc5ZhvLCwS0YV4EDtuZlNWNTqE37Cmdq8hxyAFtyOB7aZzuqRKKKC3D0Sw1MWTxqa nM4QXk0SMx8qjd9i5+TVd/3E1ivZgbOsNSr6S/5phqtvoe6/B87u5oE0fZwqdsvgvVOy vMYA== X-Gm-Message-State: AOJu0YyCursiL7DunLlRS10xEJQlwZjjinJzMTbSDQCC7/59D8RSW7se ZtiQMdhGped0+uvIXcSe4ZHU+w== X-Google-Smtp-Source: AGHT+IH87Ag0JlT90Hx66H+qK+YLeNQoRQwoQQDAx90SCLVYeMakySpUwE7/cgjUOuOsUEPWnqz5xw== X-Received: by 2002:a05:6102:34f5:b0:45f:bab9:4414 with SMTP id bi21-20020a05610234f500b0045fbab94414mr16425679vsb.24.1701170373973; Tue, 28 Nov 2023 03:19:33 -0800 (PST) Received: from google.com (193.132.150.34.bc.googleusercontent.com. [34.150.132.193]) by smtp.gmail.com with ESMTPSA id dw12-20020a0562140a0c00b0067a1c7d8e98sm3852798qvb.41.2023.11.28.03.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 03:19:33 -0800 (PST) Date: Tue, 28 Nov 2023 11:19:32 +0000 From: Paz Zcharya To: Andrzej Hajda Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute Message-ID: References: <20231105172718.18673-1-pazz@chromium.org> <8dd6f4da-dcc9-4ea3-8395-bf048b0dbc93@intel.com> <6f08cfee-a60b-4f6e-b69a-20517c563259@intel.com> <51baffb9-2249-4080-a245-eb1e03c02b9b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51baffb9-2249-4080-a245-eb1e03c02b9b@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Subrata Banik , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Rodrigo Vivi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul , matthew.auld@intel.com, Marcin Wojtas , Drew Davenport , Nirmoy Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 28, 2023 at 12:12:08PM +0100, Andrzej Hajda wrote: > On 28.11.2023 04:47, Paz Zcharya wrote: > > > > On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > > > Hey Andrzej, > > > > On a second thought, what do you think about something like > > > > + gen8_pte_t __iomem *gte = to_gt(i915)->ggtt->gsm; > > + gen8_pte_t pte; > > + gte += base / I915_GTT_PAGE_SIZE; > > + pte = ioread64(gte); > > + pte = pte & I915_GTT_PAGE_MASK; > > + phys_base = pte - i915->mm.stolen_region->region.start; > > > > The only difference is the last line. > > Bingo :) It seems to be generic algorithm to get phys_base for all > platforms: > - on older platforms stolen_region points to system memory which starts at > 0, > - on DG2 it uses lmem region which starts at 0 as well, > - on MTL stolen_region points to stolen-local which starts at 0x800000. > > So this whole "if (IS_DGFX(i915)) {...} else {...}" could be replaced > with sth generic. > 1. Find pte. > 2. if(IS_DGFX(i915) && pte & GEN12_GGTT_PTE_LM) mem = > i915->mm.regions[INTEL_REGION_LMEM_0] else mem = i915->mm.stolen_region > 3. phys_base = (pte & I915_GTT_PAGE_MASK) - mem->region.start; > > Regards > Andrzej > > Good stuff!! I'll work on this revision and resubmit. Thank you so much Andrzej! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0359C07E98 for ; Tue, 28 Nov 2023 11:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344529AbjK1LTa (ORCPT ); Tue, 28 Nov 2023 06:19:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344124AbjK1LT2 (ORCPT ); Tue, 28 Nov 2023 06:19:28 -0500 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2136D6 for ; Tue, 28 Nov 2023 03:19:34 -0800 (PST) Received: by mail-vs1-xe2d.google.com with SMTP id ada2fe7eead31-462bf380db8so1824781137.3 for ; Tue, 28 Nov 2023 03:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701170374; x=1701775174; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bCnoZKgpcEhOGCM5lZjXBdwz27cftHLpr/W77wEAkbk=; b=QLTkKrhsbZKx7TkYKjao9rP3Z48bnx4LI+O1SmR/pn94fMqJiB9R1+Y28+9lH8m0XC 8xyuTkVdIKG0ceIMqE+JGSpNWqnpPTyL3abpsLt4z0pouBikoPRr6ngYY2eUDBV5bavu hE0t2TwEpf6wmhbAvjltDh2kckliCHlH/t2n8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701170374; x=1701775174; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bCnoZKgpcEhOGCM5lZjXBdwz27cftHLpr/W77wEAkbk=; b=Z2ZHFrfuAPH79oHVlzKkPWYj9HJqwEBPj+Qkzhp55VmbcGDbb6Fm8oYTNUIfTHqfdc CBJM2EY9T2wDkTilR2M9tSaF35m7vS7K+6aZFbBuqBJ0yjpCdyDFoMwoet2XSLH3rQtH 7Kgxy4hBJQxR4PbL8dI2oxiuv3Fp8zp0qXUnfEraEZqdecdyd7cqvomI430yfxDZFjZV gPeryCxuRgv3Ul/f6xaQaoPIEw3hZ0l2PCinlEmK/GWNNZyI3UFsMBf7Kv8DQQg094X4 itLVNuQoACbKKe5b91AAYgMeY6us/J5F6gDqPHEvwWhkK0tVT6QnrH9OJjLvSrxHNo3z tNJQ== X-Gm-Message-State: AOJu0YzGfSXnjYXMilz/A2UiQ/BeRcpW1B5DQlaZRq++LcY+dXbrpDfD tQ6NE3+9t8mhSRUNE3fc+GZCeQ== X-Google-Smtp-Source: AGHT+IH87Ag0JlT90Hx66H+qK+YLeNQoRQwoQQDAx90SCLVYeMakySpUwE7/cgjUOuOsUEPWnqz5xw== X-Received: by 2002:a05:6102:34f5:b0:45f:bab9:4414 with SMTP id bi21-20020a05610234f500b0045fbab94414mr16425679vsb.24.1701170373973; Tue, 28 Nov 2023 03:19:33 -0800 (PST) Received: from google.com (193.132.150.34.bc.googleusercontent.com. [34.150.132.193]) by smtp.gmail.com with ESMTPSA id dw12-20020a0562140a0c00b0067a1c7d8e98sm3852798qvb.41.2023.11.28.03.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 03:19:33 -0800 (PST) Date: Tue, 28 Nov 2023 11:19:32 +0000 From: Paz Zcharya To: Andrzej Hajda Cc: Subrata Banik , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Marcin Wojtas , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul , matthew.auld@intel.com, Daniel Vetter , Rodrigo Vivi , Drew Davenport , David Airlie , Nirmoy Das Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute Message-ID: References: <20231105172718.18673-1-pazz@chromium.org> <8dd6f4da-dcc9-4ea3-8395-bf048b0dbc93@intel.com> <6f08cfee-a60b-4f6e-b69a-20517c563259@intel.com> <51baffb9-2249-4080-a245-eb1e03c02b9b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51baffb9-2249-4080-a245-eb1e03c02b9b@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 12:12:08PM +0100, Andrzej Hajda wrote: > On 28.11.2023 04:47, Paz Zcharya wrote: > > > > On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > > > Hey Andrzej, > > > > On a second thought, what do you think about something like > > > > + gen8_pte_t __iomem *gte = to_gt(i915)->ggtt->gsm; > > + gen8_pte_t pte; > > + gte += base / I915_GTT_PAGE_SIZE; > > + pte = ioread64(gte); > > + pte = pte & I915_GTT_PAGE_MASK; > > + phys_base = pte - i915->mm.stolen_region->region.start; > > > > The only difference is the last line. > > Bingo :) It seems to be generic algorithm to get phys_base for all > platforms: > - on older platforms stolen_region points to system memory which starts at > 0, > - on DG2 it uses lmem region which starts at 0 as well, > - on MTL stolen_region points to stolen-local which starts at 0x800000. > > So this whole "if (IS_DGFX(i915)) {...} else {...}" could be replaced > with sth generic. > 1. Find pte. > 2. if(IS_DGFX(i915) && pte & GEN12_GGTT_PTE_LM) mem = > i915->mm.regions[INTEL_REGION_LMEM_0] else mem = i915->mm.stolen_region > 3. phys_base = (pte & I915_GTT_PAGE_MASK) - mem->region.start; > > Regards > Andrzej > > Good stuff!! I'll work on this revision and resubmit. Thank you so much Andrzej!