From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41DFC4167B for ; Tue, 28 Nov 2023 12:40:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B22710E041; Tue, 28 Nov 2023 12:40:54 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C972A10E041 for ; Tue, 28 Nov 2023 12:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701175251; x=1732711251; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=bZ6fZLC8ReNri0gt28I2b9IPnQMETprBSuUigahjTMg=; b=bczmvgzNdn9e/+xX2WH1URNJ/WfJDcVLnp4KPUJXxWuyMaKv6gNVt88u XWBCpqaLZJ17z42CJQF2LZ+IdIC265p/FvAaxwAgU02bbs/FaIlx50eL+ CLiag2G3E7erFr1pbDm3oXsjuVgl5703jopHrwrOxPX/Pjsrx7PJP31rr G3J/cB5cklCV/t9tXxkPV/LOwjwbblp8ZpUpaJoEt585aa4+wXB2x9a+a NcOupOs4qBanZM4Q6TiyahpkpmLRCcMuMMFeM7TgIRKKUYTpwitA3bGXI R0zC873ML4kruCQxkbYhEtjSxHZfDk53Eca/IG0yxnPfOTCfrDG9ApDLJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="392665291" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="392665291" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 04:40:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="761918157" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="761918157" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga007.jf.intel.com with SMTP; 28 Nov 2023 04:40:42 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 28 Nov 2023 14:40:41 +0200 Date: Tue, 28 Nov 2023 14:40:41 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20231127145028.4899-1-ville.syrjala@linux.intel.com> <8734wq83uo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8734wq83uo.fsf@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915: Skip some timing checks on BXT/GLK DSI transcoders X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Nov 28, 2023 at 02:22:23PM +0200, Jani Nikula wrote: > On Mon, 27 Nov 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Apparently some BXT/GLK systems have DSI panels whose timings > > don't agree with the normal cpu transcoder hblank>=32 limitation. > > This is perhaps fine as there are no specific hblank/etc. limits > > listed for the BXT/GLK DSI transcoders. > > > > Move those checks out from the global intel_mode_valid() into > > into connector specific .mode_valid() hooks, skipping BXT/GLK > > DSI connectors. We'll leave the basic [hv]display/[hv]total > > checks in intel_mode_valid() as those seem like sensible upper > > limits regardless of the transcoder used. > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9720 > > Fixes: 8f4b1068e7fc ("drm/i915: Check some transcoder timing minimum limits") > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/icl_dsi.c | 7 +++++++ > > drivers/gpu/drm/i915/display/intel_crt.c | 5 +++++ > > drivers/gpu/drm/i915/display/intel_display.c | 10 ++++++++++ > > drivers/gpu/drm/i915/display/intel_display.h | 3 +++ > > drivers/gpu/drm/i915/display/intel_dp.c | 4 ++++ > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++++ > > drivers/gpu/drm/i915/display/intel_dvo.c | 6 ++++++ > > drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++++ > > drivers/gpu/drm/i915/display/intel_lvds.c | 5 +++++ > > drivers/gpu/drm/i915/display/intel_sdvo.c | 8 +++++++- > > drivers/gpu/drm/i915/display/intel_tv.c | 8 +++++++- > > drivers/gpu/drm/i915/display/vlv_dsi.c | 18 +++++++++++++++++- > > 12 files changed, 79 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c > > index 481fcb650850..ac456a2275db 100644 > > --- a/drivers/gpu/drm/i915/display/icl_dsi.c > > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c > > @@ -1440,6 +1440,13 @@ static void gen11_dsi_post_disable(struct intel_atomic_state *state, > > static enum drm_mode_status gen11_dsi_mode_valid(struct drm_connector *connector, > > struct drm_display_mode *mode) > > { > > + struct drm_i915_private *i915 = to_i915(connector->dev); > > + enum drm_mode_status status; > > + > > + status = intel_cpu_transcoder_mode_valid(i915, mode); > > + if (status != MODE_OK) > > + return status; > > + > > /* FIXME: DSC? */ > > return intel_dsi_mode_valid(connector, mode); > > } > > diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c > > index 0e33a0523a75..abaacea5c2cc 100644 > > --- a/drivers/gpu/drm/i915/display/intel_crt.c > > +++ b/drivers/gpu/drm/i915/display/intel_crt.c > > @@ -348,8 +348,13 @@ intel_crt_mode_valid(struct drm_connector *connector, > > struct drm_device *dev = connector->dev; > > struct drm_i915_private *dev_priv = to_i915(dev); > > int max_dotclk = dev_priv->max_dotclk_freq; > > + enum drm_mode_status status; > > int max_clock; > > > > + status = intel_cpu_transcoder_mode_valid(dev_priv, mode); > > + if (status != MODE_OK) > > + return status; > > + > > if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > > return MODE_NO_DBLESCAN; > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > > index 5cf162628b95..23b077f43614 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -7734,6 +7734,16 @@ enum drm_mode_status intel_mode_valid(struct drm_device *dev, > > mode->vtotal > vtotal_max) > > return MODE_V_ILLEGAL; > > > > + return MODE_OK; > > +} > > + > > +enum drm_mode_status intel_cpu_transcoder_mode_valid(struct drm_i915_private *dev_priv, > > + const struct drm_display_mode *mode) > > +{ > > Overall the patch looks fine, even if it's a bit meh we have to > duplicate the calls so much. No way around that I guess. > > Reviewed-by: Jani Nikula > > But please explain the intel_cpu_transcoder_mode_valid() naming. I'm not > sure I follow. These limits (suposedly) only apply to the normal transcoders but not to the BXT/GLK DSI transcoders. > > > > -- > Jani Nikula, Intel -- Ville Syrjälä Intel