From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dFh4j00t" Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A04B7 for ; Tue, 28 Nov 2023 10:31:22 -0800 (PST) Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-423a9cb7e80so17123861cf.3 for ; Tue, 28 Nov 2023 10:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701196281; x=1701801081; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=PTFy/ub85wR/nyvzrzcV4Xaa4IQTkz8R54DFVrDccF8=; b=dFh4j00tgo7EHOid2fI4iq4EVhT2rFolro2oM/szVGbQyKeU1SjTNCTIaHPrw/34KL 0aNBTVE2BsPlORqV/D2MFBzaUAHGXSSpn9XI82mlVxgTIWUiWamWBl/XLvr9TwSPPP/W OGwhXG7a+J5SMJfy4uyTNuxLhAT/H++jFZjC+tONMaxepKfayhq7bbYlrCEp351g1c/n Uk1lg2lIgclwgVVEZYRauDiMStT8yKk5VuJHXTXUvcjcPlfTBiKSHxrJJ5qO9FpLQEOx +U4pHmcdu/2DTIz582UUrTX55PycAgkruqbnDUtVXRDOT3Rx9XI7AGruGWrxGuXLKPEB PRFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701196281; x=1701801081; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PTFy/ub85wR/nyvzrzcV4Xaa4IQTkz8R54DFVrDccF8=; b=aEiORXOUyzv8AosScK13QJu7iAgqnHNDkyv7fCrCVi3CNOmPOusKSOPmHebA/xHi75 2Kkq85GiXTryii9Mn8wMcPnWYwuEK2Z6s21dl0ppnlgFGESjJh4XYt+tk7bK9xpJZRWW ivofGbJjth8rSqHutnBOtBXaes82RcFn7t8q+d6GkKoUw8IZ8ffaYrVgzjtx2Y+abV3Y O+l8ydg8oCFXaYKjGOJZ2kpvonYDIx/1G4aPTymLmnTwF3X6wWi2aGLPio3tY+VTvrlD 4E0/wEjamcl/jobslw7fixYFdsYbo9JHu7SEGe7wr2cZZQmS8SnxSekjU7/+gisApfus yF8Q== X-Gm-Message-State: AOJu0YybjfsV4W6JGYHMtOvsgxIJOB+scyzHaH+xFtPHoCxvPrW9IfRd LU3osWs1g1zCiZOUfvYc/Mw= X-Google-Smtp-Source: AGHT+IFG64qfNI9q/GwZ9p7+9sNh8gph4L1z9xLic5/aAWIqpY6W1w7dfP8dKrNSgME49dv6D+/Mtg== X-Received: by 2002:a05:622a:60e:b0:423:93cf:8a92 with SMTP id z14-20020a05622a060e00b0042393cf8a92mr20373448qta.21.1701196281376; Tue, 28 Nov 2023 10:31:21 -0800 (PST) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id j13-20020ac8404d000000b0040399fb5ef3sm4780657qtl.0.2023.11.28.10.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 10:31:20 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 8556927C007D; Tue, 28 Nov 2023 13:30:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 28 Nov 2023 13:30:17 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepueho qhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtf frrghtthgvrhhnpeejhfeikeekffejgeegueevffdtgeefudetleegjeelvdffteeihfel feehvdegkeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghu thhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqh hunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 13:30:16 -0500 (EST) Date: Tue, 28 Nov 2023 10:29:34 -0800 From: Boqun Feng To: Matthew Maurer Cc: Jamie Cunliffe , linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, Miguel Ojeda , Catalin Marinas , Will Deacon , steve.capper@arm.com, Asahi Lina , andrew@lunn.ch Subject: Re: [PATCH v4 2/2] arm64: rust: Enable Rust support for AArch64 Message-ID: References: <20231020155056.3495121-1-Jamie.Cunliffe@arm.com> <20231020155056.3495121-3-Jamie.Cunliffe@arm.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Oct 31, 2023 at 11:31:14AM -0700, Matthew Maurer wrote: > On Fri, Oct 20, 2023 at 8:53 AM Jamie Cunliffe wrote: > > +KBUILD_RUSTFLAGS += --target=aarch64-unknown-none -Ctarget-feature="-neon" > If I have aarch64-unknown-none target support already installed in my > local Rust compiler (either build a custom compiler and enable the > target, as is my real case, or as the common case, run `rustup target > add aarch64-unknown-none`), this produces a build error I didn't get > from the previous target.json approach: > > error[E0464]: multiple candidates for `rmeta` dependency `core` found > | > = note: candidate #1: > /usr/local/google/home/mmaurer/android/linux/out/cache/65c6e8ea/common/rust/libcore.rmeta > = note: candidate #2: > /usr/local/google/home/mmaurer/android/linux/prebuilts/rust/linux-x86/1.72.1/lib/rustlib/aarch64-unknown-none/lib/libcore-690113bb4de6f7fb.rlib > > Are we sure that we want to try to use `--target=aarch64-unknown-none` > rather than a custom target.json? If our libcore and their libcore may > be compiled differently (and they can be, because we are controlling > additional compilation options), it seems to me that we ought to be > defining our own target. > FWIW, the discussion around this: https://lore.kernel.org/rust-for-linux/20230126163552.GD29438@willie-the-truck/ > If we really do want to go ahead with using targets directly form > rustc, this patch should add `--sysroot=/dev/null` or a similar > override to `rustc_library_cmd` and `rust_common_cmd` to prevent rustc > from picking up any already installed sysroot libraries. > Agreed. Regards, Boqun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6158DC07CA9 for ; Tue, 28 Nov 2023 18:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ryy2BenZDMGNCuVpfh6CSqOBYAZA31LH4HLWUs5wvvY=; b=q8RhVSxLTDb6Ky clJAfipbfHyAm4a01Wlr0fha7s12Xbr4vqSboQFtbZe5CUKKKBzEsQcUK0rgVKhzygnchzQsQynSC 8pwtyPj058bRmweuDZ8jd/Eh/+LJHflldDB4x1FJWR3dHKX8l4ZveOyPE09bbdkY6jdJD2ofpwyth dsJNyVqEgh/CIqvFiS7fb4Hnpi1Wc5kI/piotRYRbtCkhJcomykUle3yyJhbSUsJqJe37dZDJ1aN6 R7zJye2MdBfe215y32aCl6n3BccZke+112VCJQzszE+zhhetIRbjkVRJfQUi2Ll7EVWhPUT2Hdv+v fYy57e3dlCAKg9gFYBSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r82rm-0065VL-2l; Tue, 28 Nov 2023 18:31:26 +0000 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r82rj-0065Tx-0W for linux-arm-kernel@lists.infradead.org; Tue, 28 Nov 2023 18:31:25 +0000 Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-41f155c862bso30325701cf.2 for ; Tue, 28 Nov 2023 10:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701196281; x=1701801081; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=PTFy/ub85wR/nyvzrzcV4Xaa4IQTkz8R54DFVrDccF8=; b=eUm/zL1sxgYRyIZlKmxNcTs4BjOS1WRvnYqexeTU8lCZ8rI7CfHFZuGyQgfjXo0YE2 LzamJcnp7c3fdiu8K/Qaohx28Z8iQR2lNbOP7lED4cy3DXSZbhTiUKZ18OYOgGYknNdM Ryq5DwaqVxPIUhfkwQEyb3vi4bTqKzxKw0gpWgYUT7OX0qGrVonIYR+d4Wtzcxtt4Gr4 RPf+wfwMISWqV/AB3qsW9JOtrIRXdRSuPajcQ22sSlKZ2UhosFQnBDLFZ6zJi1Zx+Xfo /odhVyVLU36p77rsh0giLpAdnfRgfTuAzZZrcbX0XO7W8Cgt7R3gPymE2Wt/ZAxH6dSa QAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701196281; x=1701801081; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PTFy/ub85wR/nyvzrzcV4Xaa4IQTkz8R54DFVrDccF8=; b=qPZW2NcNOJe3xc98pT82Tihanrcyc3SUQ1VxFifYocBukQe3JJ4oD2260cOBSH7jch 1km/FXvPs/Lzr8YtS1LzJuIp9WVGr0/vgoPy2dIotRc09dYAe5O00DpSPGWBL6Z3HZ2q i2Flymq1ZILiA/lZ/mxqS8EPr7yuxjeGzdwqyrCrng3gD3R/lGNv2jgOvJtpJmqz5WVl 0whSlmEJfHfDJ0wmMRBuQc3Jq+GBy9JRzaUZigmTKYVWmOyr8XLKOlhL+ed/dtl9tNyD AnbPFnsRHLdLWeX+isDcqXxW+hwG7ZDurAWgkGSclPhVup45iU9u5WUSdelSL4OfYfWq M1Eg== X-Gm-Message-State: AOJu0Yzt7NS1LvJzjhy6M0VAHc6Awrc+5upsM8FXtmcu//m8DTA2XcVw TQ4yTlT5jfUvMUvlspjqq4s= X-Google-Smtp-Source: AGHT+IFG64qfNI9q/GwZ9p7+9sNh8gph4L1z9xLic5/aAWIqpY6W1w7dfP8dKrNSgME49dv6D+/Mtg== X-Received: by 2002:a05:622a:60e:b0:423:93cf:8a92 with SMTP id z14-20020a05622a060e00b0042393cf8a92mr20373448qta.21.1701196281376; Tue, 28 Nov 2023 10:31:21 -0800 (PST) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id j13-20020ac8404d000000b0040399fb5ef3sm4780657qtl.0.2023.11.28.10.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 10:31:20 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 8556927C007D; Tue, 28 Nov 2023 13:30:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 28 Nov 2023 13:30:17 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepueho qhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtf frrghtthgvrhhnpeejhfeikeekffejgeegueevffdtgeefudetleegjeelvdffteeihfel feehvdegkeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghu thhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqh hunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 13:30:16 -0500 (EST) Date: Tue, 28 Nov 2023 10:29:34 -0800 From: Boqun Feng To: Matthew Maurer Cc: Jamie Cunliffe , linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, Miguel Ojeda , Catalin Marinas , Will Deacon , steve.capper@arm.com, Asahi Lina , andrew@lunn.ch Subject: Re: [PATCH v4 2/2] arm64: rust: Enable Rust support for AArch64 Message-ID: References: <20231020155056.3495121-1-Jamie.Cunliffe@arm.com> <20231020155056.3495121-3-Jamie.Cunliffe@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_103123_198742_C78F4FD5 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMzEsIDIwMjMgYXQgMTE6MzE6MTRBTSAtMDcwMCwgTWF0dGhldyBNYXVyZXIg d3JvdGU6Cj4gT24gRnJpLCBPY3QgMjAsIDIwMjMgYXQgODo1M+KAr0FNIEphbWllIEN1bmxpZmZl IDxKYW1pZS5DdW5saWZmZUBhcm0uY29tPiB3cm90ZToKPiA+ICtLQlVJTERfUlVTVEZMQUdTICs9 IC0tdGFyZ2V0PWFhcmNoNjQtdW5rbm93bi1ub25lIC1DdGFyZ2V0LWZlYXR1cmU9Ii1uZW9uIgo+ IElmIEkgaGF2ZSBhYXJjaDY0LXVua25vd24tbm9uZSB0YXJnZXQgc3VwcG9ydCBhbHJlYWR5IGlu c3RhbGxlZCBpbiBteQo+IGxvY2FsIFJ1c3QgY29tcGlsZXIgKGVpdGhlciBidWlsZCBhIGN1c3Rv bSBjb21waWxlciBhbmQgZW5hYmxlIHRoZQo+IHRhcmdldCwgYXMgaXMgbXkgcmVhbCBjYXNlLCBv ciBhcyB0aGUgY29tbW9uIGNhc2UsIHJ1biBgcnVzdHVwIHRhcmdldAo+IGFkZCBhYXJjaDY0LXVu a25vd24tbm9uZWApLCB0aGlzIHByb2R1Y2VzIGEgYnVpbGQgZXJyb3IgSSBkaWRuJ3QgZ2V0Cj4g ZnJvbSB0aGUgcHJldmlvdXMgdGFyZ2V0Lmpzb24gYXBwcm9hY2g6Cj4gCj4gZXJyb3JbRTA0NjRd OiBtdWx0aXBsZSBjYW5kaWRhdGVzIGZvciBgcm1ldGFgIGRlcGVuZGVuY3kgYGNvcmVgIGZvdW5k Cj4gICB8Cj4gICA9IG5vdGU6IGNhbmRpZGF0ZSAjMToKPiAvdXNyL2xvY2FsL2dvb2dsZS9ob21l L21tYXVyZXIvYW5kcm9pZC9saW51eC9vdXQvY2FjaGUvNjVjNmU4ZWEvY29tbW9uL3J1c3QvbGli Y29yZS5ybWV0YQo+ICAgPSBub3RlOiBjYW5kaWRhdGUgIzI6Cj4gL3Vzci9sb2NhbC9nb29nbGUv aG9tZS9tbWF1cmVyL2FuZHJvaWQvbGludXgvcHJlYnVpbHRzL3J1c3QvbGludXgteDg2LzEuNzIu MS9saWIvcnVzdGxpYi9hYXJjaDY0LXVua25vd24tbm9uZS9saWIvbGliY29yZS02OTAxMTNiYjRk ZTZmN2ZiLnJsaWIKPiAKPiBBcmUgd2Ugc3VyZSB0aGF0IHdlIHdhbnQgdG8gdHJ5IHRvIHVzZSBg LS10YXJnZXQ9YWFyY2g2NC11bmtub3duLW5vbmVgCj4gcmF0aGVyIHRoYW4gYSBjdXN0b20gdGFy Z2V0Lmpzb24/IElmIG91ciBsaWJjb3JlIGFuZCB0aGVpciBsaWJjb3JlIG1heQo+IGJlIGNvbXBp bGVkIGRpZmZlcmVudGx5IChhbmQgdGhleSBjYW4gYmUsIGJlY2F1c2Ugd2UgYXJlIGNvbnRyb2xs aW5nCj4gYWRkaXRpb25hbCBjb21waWxhdGlvbiBvcHRpb25zKSwgaXQgc2VlbXMgdG8gbWUgdGhh dCB3ZSBvdWdodCB0byBiZQo+IGRlZmluaW5nIG91ciBvd24gdGFyZ2V0Lgo+IAoKRldJVywgdGhl IGRpc2N1c3Npb24gYXJvdW5kIHRoaXM6CgoJaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvcnVzdC1m b3ItbGludXgvMjAyMzAxMjYxNjM1NTIuR0QyOTQzOEB3aWxsaWUtdGhlLXRydWNrLwkKCj4gSWYg d2UgcmVhbGx5IGRvIHdhbnQgdG8gZ28gYWhlYWQgd2l0aCB1c2luZyB0YXJnZXRzIGRpcmVjdGx5 IGZvcm0KPiBydXN0YywgdGhpcyBwYXRjaCBzaG91bGQgYWRkIGAtLXN5c3Jvb3Q9L2Rldi9udWxs YCBvciBhIHNpbWlsYXIKPiBvdmVycmlkZSB0byBgcnVzdGNfbGlicmFyeV9jbWRgIGFuZCBgcnVz dF9jb21tb25fY21kYCB0byBwcmV2ZW50IHJ1c3RjCj4gZnJvbSBwaWNraW5nIHVwIGFueSBhbHJl YWR5IGluc3RhbGxlZCBzeXNyb290IGxpYnJhcmllcy4KPiAKCkFncmVlZC4KClJlZ2FyZHMsCkJv cXVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==