Re: [Intel-xe] [PATCH 2/3] drm/xe: Add skip_guc_pc flag

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Nov 27, 2023 at 02:22:35PM -0800, Vinay Belgaumkar wrote:
> This flag can be used to disable GuC based power management. This
> could be used for debug or comparison to host based C6.
> 
> v2: Fix missing definition
> 
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device_types.h | 2 ++
>  drivers/gpu/drm/xe/xe_pci.c          | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 2712905c7a91..b1877270960a 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -264,6 +264,8 @@ struct xe_device {
>  		u8 supports_mmio_ext:1;
>  		/** @has_heci_gscfi: device has heci gscfi */
>  		u8 has_heci_gscfi:1;
> +		/** @skip_guc_pc: Skip GuC based PM feature init */
> +		u8 skip_guc_pc:1;
>  
>  #if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
>  		struct {
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index cb762c11dd0f..d54cae326e1a 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -64,6 +64,7 @@ struct xe_device_desc {
>  	u8 has_sriov:1;
>  	u8 bypass_mtcfg:1;
>  	u8 supports_mmio_ext:1;
> +	u8 skip_guc_pc:1;
>  };
>  
>  __diag_push();
> @@ -592,6 +593,7 @@ static int xe_info_init(struct xe_device *xe,
>  	xe->info.has_asid = graphics_desc->has_asid;
>  	xe->info.has_flat_ccs = graphics_desc->has_flat_ccs;
>  	xe->info.has_range_tlb_invalidation = graphics_desc->has_range_tlb_invalidation;
> +	xe->info.skip_guc_pc = desc->skip_guc_pc;
>  
>  	xe->info.enable_display = IS_ENABLED(CONFIG_DRM_XE_DISPLAY) &&
>  				  enable_display &&
> -- 
> 2.38.1
>