From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@suse.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Yosry Ahmed <yosryahmed@google.com>,
Liu Shixin <liushixin2@huawei.com>, Yu Zhao <yuzhao@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Sachin Sant <sachinp@linux.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space
Date: Tue, 28 Nov 2023 14:45:09 -0800 [thread overview]
Message-ID: <ZWZtdQKSSnLC8kZ6@google.com> (raw)
In-Reply-To: <ZWW95JPQ1B0cVPY-@tiehlicka>
On Tue, Nov 28, 2023 at 11:16:04AM +0100, Michal Hocko wrote:
> On Tue 28-11-23 09:31:06, Huang, Ying wrote:
> > Michal Hocko <mhocko@suse.com> writes:
> [...]
> > > Right. On the other hand we could be more aggressive when dropping the
> > > swapcache. Is there any actual reason why we cannot try to folio_free_swap
> > > even when mem_cgroup_swap_full == F?
> >
> > If there are plenty free space in swap device, why not take advantage of
> > it?
>
> Maybe a stupid question but what is the advantage of keeping around in
> the swap cache?
If the page is shared, we avoids addtional IO to bring them back so
swap cache.
If the page is still clean on reclaim moment since swap-in, VM doesn't
need to write them out to the swap disk since original data is already
there.
next prev parent reply other threads:[~2023-11-28 22:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 9:06 [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space Liu Shixin
2023-11-21 13:00 ` Michal Hocko
2023-11-22 6:41 ` Liu Shixin
2023-11-22 6:44 ` Yosry Ahmed
2023-11-22 6:57 ` Huang, Ying
2023-11-22 8:55 ` Michal Hocko
2023-11-22 8:52 ` Michal Hocko
2023-11-22 10:09 ` Michal Hocko
2023-11-22 10:39 ` Yosry Ahmed
2023-11-22 13:19 ` Michal Hocko
2023-11-22 20:13 ` Yosry Ahmed
2023-11-23 6:15 ` Huang, Ying
2023-11-24 16:30 ` Michal Hocko
2023-11-27 2:34 ` Huang, Ying
2023-11-27 7:42 ` Chris Li
2023-11-27 8:11 ` Huang, Ying
2023-11-27 8:22 ` Chris Li
2023-11-27 21:31 ` Minchan Kim
2023-11-27 21:56 ` Yosry Ahmed
2023-11-28 3:19 ` Huang, Ying
2023-11-28 3:27 ` Yosry Ahmed
2023-11-28 4:03 ` Huang, Ying
2023-11-28 4:13 ` Yosry Ahmed
2023-11-28 5:37 ` Huang, Ying
2023-11-28 5:41 ` Yosry Ahmed
2023-11-28 5:52 ` Huang, Ying
2023-11-28 22:37 ` Minchan Kim
2023-11-29 3:12 ` Huang, Ying
2023-11-29 10:22 ` Michal Hocko
2023-11-30 8:07 ` Huang, Ying
2023-11-28 23:45 ` Chris Li
2023-11-27 9:10 ` Michal Hocko
2023-11-28 1:31 ` Huang, Ying
2023-11-28 10:16 ` Michal Hocko
2023-11-28 22:45 ` Minchan Kim [this message]
2023-11-28 23:05 ` Yosry Ahmed
2023-11-28 23:15 ` Minchan Kim
2023-11-29 10:17 ` Michal Hocko
2023-12-13 23:13 ` Andrew Morton
2023-12-15 5:05 ` Huang, Ying
2023-12-15 19:24 ` Andrew Morton
2023-11-23 17:30 ` Chris Li
2023-11-23 17:19 ` Chris Li
2023-11-28 1:59 ` Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWZtdQKSSnLC8kZ6@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=mhocko@suse.com \
--cc=sachinp@linux.ibm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.