From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB651C4167B for ; Wed, 29 Nov 2023 09:08:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4440710E1A1; Wed, 29 Nov 2023 09:08:56 +0000 (UTC) Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D9F610E18D; Wed, 29 Nov 2023 09:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1701248932; bh=Xv3LVDjykwD/IOkFuRPxIVNxFelutLAZSXS7jeSQqIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAZ/6qGNguReQ4NFwPXT8Bi2uaQNZ0Q93gRgXJPFRYxINiE+0NAHwqYEo8gcRktTI g5OWo09C5jJHok3S1c3vfX72MgTtnOlRCfK/TqM9Rhw5IHY9zlrMU0Lm6ESMeYefR5 o0o+IWUBwaImm3Ew7Uz5W7jNB5PpjVR/Xzp9G3VEMAH3MPFJnFwTN5A/JF0jvSM53H TD72MGqWdop+SC6I4X83nrxxAJKPcPymeSSvEn8ptLrmEICedV7+oDpdhH/aFgVPau +Aaz/bRn6yA421udzBxvVtiTPtc21WHM3jUynkqXosp+xZ5HbIh4FPd2hzKqYs08uU fPTAj/lk7FXSA== Received: by gofer.mess.org (Postfix, from userid 1000) id CB5B0100100; Wed, 29 Nov 2023 09:08:52 +0000 (GMT) Date: Wed, 29 Nov 2023 09:08:52 +0000 From: Sean Young To: Thierry Reding Message-ID: References: <2b973840d800ffb71c2683c37bc996e0cf90a140.1700323916.git.sean@mess.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Pavel Machek , David Airlie , linux-leds@vger.kernel.org, Daniel Thompson , Ivaylo Dimitrov , Jonathan Corbet , Helge Deller , Lee Jones , Javier Martinez Canillas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Guenter Roeck , linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Jean Delvare , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, Mark Gross , Hans de Goede , Mark Brown , Maxime Ripard , Rodrigo Vivi , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Support Opensource , Jingoo Han , Dmitry Torokhov , Liam Girdwood , Thomas Zimmermann Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote: > On Sat, Nov 18, 2023 at 04:16:17PM +0000, Sean Young wrote: > > In order to introduce a pwm api which can be used from atomic context, > > we will need two functions for applying pwm changes: > > > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > > int pwm_apply_atomic(struct pwm *, struct pwm_state *); > > > > This commit just deals with renaming pwm_apply_state(), a following > > commit will introduce the pwm_apply_atomic() function. > > Sorry, I still don't agree with that _cansleep suffix. I think it's the > wrong terminology. Just because something can sleep doesn't mean that it > ever will. "Might sleep" is much more accurate because it says exactly > what might happen and indicates what we're guarding against. Sorry, I forgot about this in the last round. I've renamed it _might_sleep in v6 which I'll post shortly. Sean From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mess.org header.i=@mess.org header.b="BAZ/6qGN" Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A214171D; Wed, 29 Nov 2023 01:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1701248932; bh=Xv3LVDjykwD/IOkFuRPxIVNxFelutLAZSXS7jeSQqIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAZ/6qGNguReQ4NFwPXT8Bi2uaQNZ0Q93gRgXJPFRYxINiE+0NAHwqYEo8gcRktTI g5OWo09C5jJHok3S1c3vfX72MgTtnOlRCfK/TqM9Rhw5IHY9zlrMU0Lm6ESMeYefR5 o0o+IWUBwaImm3Ew7Uz5W7jNB5PpjVR/Xzp9G3VEMAH3MPFJnFwTN5A/JF0jvSM53H TD72MGqWdop+SC6I4X83nrxxAJKPcPymeSSvEn8ptLrmEICedV7+oDpdhH/aFgVPau +Aaz/bRn6yA421udzBxvVtiTPtc21WHM3jUynkqXosp+xZ5HbIh4FPd2hzKqYs08uU fPTAj/lk7FXSA== Received: by gofer.mess.org (Postfix, from userid 1000) id CB5B0100100; Wed, 29 Nov 2023 09:08:52 +0000 (GMT) Date: Wed, 29 Nov 2023 09:08:52 +0000 From: Sean Young To: Thierry Reding Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Corbet , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jean Delvare , Guenter Roeck , Support Opensource , Dmitry Torokhov , Pavel Machek , Lee Jones , Mauro Carvalho Chehab , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Mark Gross , Liam Girdwood , Mark Brown , Daniel Thompson , Jingoo Han , Helge Deller , Jani Nikula , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep() Message-ID: References: <2b973840d800ffb71c2683c37bc996e0cf90a140.1700323916.git.sean@mess.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote: > On Sat, Nov 18, 2023 at 04:16:17PM +0000, Sean Young wrote: > > In order to introduce a pwm api which can be used from atomic context, > > we will need two functions for applying pwm changes: > > > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > > int pwm_apply_atomic(struct pwm *, struct pwm_state *); > > > > This commit just deals with renaming pwm_apply_state(), a following > > commit will introduce the pwm_apply_atomic() function. > > Sorry, I still don't agree with that _cansleep suffix. I think it's the > wrong terminology. Just because something can sleep doesn't mean that it > ever will. "Might sleep" is much more accurate because it says exactly > what might happen and indicates what we're guarding against. Sorry, I forgot about this in the last round. I've renamed it _might_sleep in v6 which I'll post shortly. Sean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24D1FC4167B for ; Wed, 29 Nov 2023 09:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P8bbxqhueWVSZN0940tvu7NFPpAvXKQlfX7xLFLMBuk=; b=BSXdm8z1lsBKUY mAOXyKUl8msS34dmCgEaKZSFqilZGgD2T46S7XpFcKIkOe7Y6c8/4Bi3Y4anSnj8OzZctQOhey08S z7sZy2ad5nq1DhoiGPlWSGksN9Nu1DfpTDNuNmlRobFxpSW7BDKMYi3PplZWUCj1Rd8G++9HAIDng Iyt+SQZJKHObjPYkUGGAE9+xeggkY2lu7Ee+9mj7Puq8ByepteE2TRGQAXAqJhw72w0B2Z79bTmKE 2n3zXb3RWjilm71P31iOt3gI0j8+iR9c190uRdLNTBBpsC1mWZhNS/tTBn77lS11SQ5le4Vq52zpk e88wWX74+xf4SNAHgB/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8GZ3-007ZSW-1B; Wed, 29 Nov 2023 09:09:01 +0000 Received: from gofer.mess.org ([88.97.38.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8GZ0-007ZRA-2H for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 09:09:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1701248932; bh=Xv3LVDjykwD/IOkFuRPxIVNxFelutLAZSXS7jeSQqIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAZ/6qGNguReQ4NFwPXT8Bi2uaQNZ0Q93gRgXJPFRYxINiE+0NAHwqYEo8gcRktTI g5OWo09C5jJHok3S1c3vfX72MgTtnOlRCfK/TqM9Rhw5IHY9zlrMU0Lm6ESMeYefR5 o0o+IWUBwaImm3Ew7Uz5W7jNB5PpjVR/Xzp9G3VEMAH3MPFJnFwTN5A/JF0jvSM53H TD72MGqWdop+SC6I4X83nrxxAJKPcPymeSSvEn8ptLrmEICedV7+oDpdhH/aFgVPau +Aaz/bRn6yA421udzBxvVtiTPtc21WHM3jUynkqXosp+xZ5HbIh4FPd2hzKqYs08uU fPTAj/lk7FXSA== Received: by gofer.mess.org (Postfix, from userid 1000) id CB5B0100100; Wed, 29 Nov 2023 09:08:52 +0000 (GMT) Date: Wed, 29 Nov 2023 09:08:52 +0000 From: Sean Young To: Thierry Reding Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Corbet , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jean Delvare , Guenter Roeck , Support Opensource , Dmitry Torokhov , Pavel Machek , Lee Jones , Mauro Carvalho Chehab , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Mark Gross , Liam Girdwood , Mark Brown , Daniel Thompson , Jingoo Han , Helge Deller , Jani Nikula , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep() Message-ID: References: <2b973840d800ffb71c2683c37bc996e0cf90a140.1700323916.git.sean@mess.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_010858_894515_126134FF X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote: > On Sat, Nov 18, 2023 at 04:16:17PM +0000, Sean Young wrote: > > In order to introduce a pwm api which can be used from atomic context, > > we will need two functions for applying pwm changes: > > > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > > int pwm_apply_atomic(struct pwm *, struct pwm_state *); > > > > This commit just deals with renaming pwm_apply_state(), a following > > commit will introduce the pwm_apply_atomic() function. > > Sorry, I still don't agree with that _cansleep suffix. I think it's the > wrong terminology. Just because something can sleep doesn't mean that it > ever will. "Might sleep" is much more accurate because it says exactly > what might happen and indicates what we're guarding against. Sorry, I forgot about this in the last round. I've renamed it _might_sleep in v6 which I'll post shortly. Sean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FD95C46CA3 for ; Wed, 29 Nov 2023 09:08:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DCD410E18D; Wed, 29 Nov 2023 09:08:56 +0000 (UTC) Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D9F610E18D; Wed, 29 Nov 2023 09:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1701248932; bh=Xv3LVDjykwD/IOkFuRPxIVNxFelutLAZSXS7jeSQqIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAZ/6qGNguReQ4NFwPXT8Bi2uaQNZ0Q93gRgXJPFRYxINiE+0NAHwqYEo8gcRktTI g5OWo09C5jJHok3S1c3vfX72MgTtnOlRCfK/TqM9Rhw5IHY9zlrMU0Lm6ESMeYefR5 o0o+IWUBwaImm3Ew7Uz5W7jNB5PpjVR/Xzp9G3VEMAH3MPFJnFwTN5A/JF0jvSM53H TD72MGqWdop+SC6I4X83nrxxAJKPcPymeSSvEn8ptLrmEICedV7+oDpdhH/aFgVPau +Aaz/bRn6yA421udzBxvVtiTPtc21WHM3jUynkqXosp+xZ5HbIh4FPd2hzKqYs08uU fPTAj/lk7FXSA== Received: by gofer.mess.org (Postfix, from userid 1000) id CB5B0100100; Wed, 29 Nov 2023 09:08:52 +0000 (GMT) Date: Wed, 29 Nov 2023 09:08:52 +0000 From: Sean Young To: Thierry Reding Subject: Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep() Message-ID: References: <2b973840d800ffb71c2683c37bc996e0cf90a140.1700323916.git.sean@mess.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Pavel Machek , linux-leds@vger.kernel.org, Daniel Thompson , Ivaylo Dimitrov , Jonathan Corbet , Helge Deller , Lee Jones , Javier Martinez Canillas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Guenter Roeck , linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Jean Delvare , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, Mark Gross , Hans de Goede , Mark Brown , Maxime Ripard , Rodrigo Vivi , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Tvrtko Ursulin , Support Opensource , Jingoo Han , Dmitry Torokhov , Liam Girdwood , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote: > On Sat, Nov 18, 2023 at 04:16:17PM +0000, Sean Young wrote: > > In order to introduce a pwm api which can be used from atomic context, > > we will need two functions for applying pwm changes: > > > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > > int pwm_apply_atomic(struct pwm *, struct pwm_state *); > > > > This commit just deals with renaming pwm_apply_state(), a following > > commit will introduce the pwm_apply_atomic() function. > > Sorry, I still don't agree with that _cansleep suffix. I think it's the > wrong terminology. Just because something can sleep doesn't mean that it > ever will. "Might sleep" is much more accurate because it says exactly > what might happen and indicates what we're guarding against. Sorry, I forgot about this in the last round. I've renamed it _might_sleep in v6 which I'll post shortly. Sean