From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, corbet@lwn.net
Subject: Re: [patch net-next] docs: netlink: add NLMSG_DONE message format for doit actions
Date: Thu, 30 Nov 2023 14:30:36 +0100 [thread overview]
Message-ID: <ZWiOfMs1PT14LLau@nanopsycho> (raw)
In-Reply-To: <20231129071656.6de3f298@kernel.org>
Wed, Nov 29, 2023 at 04:16:56PM CET, kuba@kernel.org wrote:
>On Wed, 29 Nov 2023 15:46:15 +0100 Jiri Pirko wrote:
>> >> In case NLMSG_DONE message is sent as a reply to doit action, multiple
>> >> kernel implementation do not send anything else than struct nlmsghdr.
>> >> Add this note to the Netlink intro documentation.
>> >
>> >You mean when the reply has F_MULTI set, correct?
>>
>> Well, that would be ideal. However, that flag is parallel to NLMSG_DONE.
>> I see that at least drivers/connector/connector.c does not set this flag
>> when sending NLMSG_DONE type.
>
>connector is a really bad example, the doc would have to say "some
>families use NLMSG_DONE as an actual message type which may have pretty
>much anything attached to it". It's not worth it, sorry.
The existing documentation confuses uapi users (I have sample).
They expect error with NLMSG_DONE.
>--
>pw-bot: reject
next prev parent reply other threads:[~2023-11-30 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 15:19 [patch net-next] docs: netlink: add NLMSG_DONE message format for doit actions Jiri Pirko
2023-11-28 15:30 ` Jakub Kicinski
2023-11-29 14:46 ` Jiri Pirko
2023-11-29 15:16 ` Jakub Kicinski
2023-11-30 13:30 ` Jiri Pirko [this message]
2023-11-30 17:39 ` Jakub Kicinski
2023-12-01 7:51 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWiOfMs1PT14LLau@nanopsycho \
--to=jiri@resnulli.us \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.