From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH net-next v5] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml
Date: Wed, 6 Dec 2023 08:51:54 +0100 [thread overview]
Message-ID: <ZXAoGhUnBFzQxD0f@nanopsycho> (raw)
In-Reply-To: <20231205191944.6738deb7@kernel.org>
Wed, Dec 06, 2023 at 04:19:44AM CET, kuba@kernel.org wrote:
>On Sat, 2 Dec 2023 18:00:48 +0530 Swarup Laxman Kotiaklapudi wrote:
>> Add some missing(not all) attributes in devlink.yaml.
>
>Hi Jiri,
>
>Do you want to take a closer look at the spec here?
>Looks fine to me, on a quick scroll.
Yep, will do that later today.
>
>> Suggested-by: Jiri Pirko <jiri@resnulli.us>
>> Suggested-by: Jakub Kicinski <kuba@kernel.org>
>> Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")
>
>I'll drop these when / if applying, FWIW.
>
>Swarup, for future reference if there are comments / changes suggested
>during normal review process you don't have to add the Suggested-by
My "suggested-by" is probably fine as I suggested Swarup to make the patch :)
>tag. The expectation is that the reviewer will send a Reviewed-by tag
>themselves at the end instead.
next prev parent reply other threads:[~2023-12-06 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 12:30 [PATCH net-next v5] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml Swarup Laxman Kotiaklapudi
2023-12-06 3:19 ` Jakub Kicinski
2023-12-06 7:51 ` Jiri Pirko [this message]
2023-12-06 16:06 ` Jakub Kicinski
2023-12-07 2:08 ` swarup
2023-12-08 18:30 ` swarup
2023-12-10 11:47 ` Jiri Pirko
2023-12-10 17:44 ` swarup
2023-12-06 13:18 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXAoGhUnBFzQxD0f@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.