From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
"Maciej Żenczykowski" <zenczykowski@gmail.com>
Subject: Re: [PATCH nft v3] parser: tcpopt: fix tcp option parsing with NUM + length field
Date: Wed, 6 Dec 2023 16:56:08 +0100 [thread overview]
Message-ID: <ZXCZmBW67HbEUNw/@calendula> (raw)
In-Reply-To: <20231206115205.4289-1-fw@strlen.de>
On Wed, Dec 06, 2023 at 12:52:00PM +0100, Florian Westphal wrote:
> tcp option 254 length ge 4
>
> ... will segfault.
> The crash bug is that tcpopt_expr_alloc() can return NULL if we cannot
> find a suitable template for the requested kind + field combination,
> so add the needed error handling in the bison parser.
>
> However, we can handle this. NOP and EOL have templates, all other
> options (known or unknown) must also have a length field.
>
> So also add a fallback template to handle both kind and length, even
> if only a numeric option is given that nft doesn't recognize.
>
> Don't bother with output, above will be printed via raw syntax, i.e.
> tcp option @254,8,8 >= 4.
Patch LGTM, please push it out.
Thanks.
prev parent reply other threads:[~2023-12-06 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 11:52 [PATCH nft v3] parser: tcpopt: fix tcp option parsing with NUM + length field Florian Westphal
2023-12-06 15:56 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXCZmBW67HbEUNw/@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.