From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: "Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"brenda.streiff@ni.com" <brenda.streiff@ni.com>,
"Crescent CY Hsieh" <crescentcy.hsieh@moxa.com>,
"Tomas Paukrt" <tomaspaukrt@email.cz>
Subject: Re: [PATCH 1/2] dt-bindings: serial: rs485: add rs485-mux-gpios binding
Date: Thu, 7 Dec 2023 14:35:24 +0200 [thread overview]
Message-ID: <ZXG8DI8diij72fBR@smile.fi.intel.com> (raw)
In-Reply-To: <5c140498-69e3-4187-8703-db0c41e7ca89@gmx.de>
On Wed, Dec 06, 2023 at 04:42:53PM +0100, Lino Sanfilippo wrote:
> On 27.11.23 13:14, Christoph Niedermaier wrote:
> > From: Lino Sanfilippo [mailto:LinoSanfilippo@gmx.de]
> > Sent: Sunday, November 26, 2023 12:40 AM
...
> > RS-485 (2-wire NO RX_DURING_TX): rs485->flags = SER_RS485_ENABLED|SER_RS485_MODE_HALF_DUPLEX
> > RS-485 (2-wire RX_DURING_TX): rs485->flags = SER_RS485_ENABLED|SER_RS485_MODE_HALF_DUPLEX|SER_RS485_RX_DURING_TX
>
> I think we can omit the SER_RS485_MODE_HALF_DUPLEX flag if we assume that
> a missing SER_RS485_MODE_FULL_DUPLEX means half duplex (i.e. controlling
> the RTS line).
You should be very careful on these assumptions, i.e. one must to check _all_
existing user space tools (at least that are in use / supplied by main distros)
on how they behave.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-07 12:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 15:10 [PATCH 0/2] serial: add rs485-mux-gpio dt binding and support Rasmus Villemoes
2023-11-20 15:10 ` [PATCH 1/2] dt-bindings: serial: rs485: add rs485-mux-gpios binding Rasmus Villemoes
2023-11-21 7:52 ` Krzysztof Kozlowski
2023-11-21 8:27 ` Rasmus Villemoes
2023-11-21 8:34 ` Krzysztof Kozlowski
2023-11-21 9:28 ` Rasmus Villemoes
2023-11-22 18:00 ` Krzysztof Kozlowski
2023-11-22 14:53 ` Lukas Wunner
2023-11-23 10:07 ` Rasmus Villemoes
2023-11-23 10:38 ` Lukas Wunner
2023-11-23 13:48 ` Rasmus Villemoes
2023-11-25 23:40 ` Lino Sanfilippo
2023-11-27 12:14 ` Christoph Niedermaier
2023-12-06 15:42 ` Lino Sanfilippo
2023-12-07 12:35 ` Andy Shevchenko [this message]
2023-12-09 11:24 ` Lino Sanfilippo
2023-12-09 11:47 ` Lino Sanfilippo
2023-12-11 13:07 ` Andy Shevchenko
2023-12-14 8:52 ` Lino Sanfilippo
2023-12-14 10:24 ` Crescent CY Hsieh
2023-12-14 13:41 ` Christoph Niedermaier
2023-12-14 14:04 ` Lino Sanfilippo
2023-12-14 14:50 ` Christoph Niedermaier
2023-12-15 22:13 ` Lino Sanfilippo
2023-12-18 9:08 ` Christoph Niedermaier
2023-12-21 15:53 ` Lukas Wunner
2023-12-23 12:49 ` Christoph Niedermaier
2023-12-23 13:40 ` Lino Sanfilippo
2023-12-24 10:11 ` Christoph Niedermaier
2023-12-28 23:25 ` Lukas Wunner
2023-11-20 15:10 ` [PATCH 2/2] serial: core: implement support for rs485-mux-gpios Rasmus Villemoes
2023-11-20 23:28 ` Lino Sanfilippo
2023-11-21 10:49 ` Dan Carpenter
2023-11-22 15:10 ` Lukas Wunner
2023-12-04 5:00 ` Dan Carpenter
2023-11-22 14:57 ` [PATCH 0/2] serial: add rs485-mux-gpio dt binding and support Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2023-12-27 17:40 [PATCH 1/2] dt-bindings: serial: rs485: add rs485-mux-gpios binding Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXG8DI8diij72fBR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=brenda.streiff@ni.com \
--cc=cniedermaier@dh-electronics.com \
--cc=conor+dt@kernel.org \
--cc=crescentcy.hsieh@moxa.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=robh+dt@kernel.org \
--cc=tomaspaukrt@email.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.