From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/9] imap-send: don't use git_die_config() inside callback
Date: Thu, 7 Dec 2023 09:57:55 +0100 [thread overview]
Message-ID: <ZXGJE-pkb3BjlO-d@tanuki> (raw)
In-Reply-To: <20231207072458.GC1277973@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Thu, Dec 07, 2023 at 02:24:58AM -0500, Jeff King wrote:
[snip]
> diff --git a/imap-send.c b/imap-send.c
> index 996651e4f8..5b0fe4f95a 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1346,7 +1346,7 @@ static int git_imap_config(const char *var, const char *val,
> server.port = git_config_int(var, val, ctx->kvi);
> else if (!strcmp("imap.host", var)) {
> if (!val) {
> - git_die_config("imap.host", "Missing value for 'imap.host'");
> + return error("Missing value for 'imap.host'");
Nit: while at it we might also mark this error for translation. Not
worth a reroll on its own though.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-12-07 8:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:23 [PATCH 0/9] bonus config cleanups Jeff King
2023-12-07 7:24 ` [PATCH 1/9] config: reject bogus values for core.checkstat Jeff King
2023-12-08 22:50 ` Taylor Blau
2023-12-07 7:24 ` [PATCH 2/9] git_xmerge_config(): prefer error() to die() Jeff King
2023-12-07 7:24 ` [PATCH 3/9] imap-send: don't use git_die_config() inside callback Jeff King
2023-12-07 8:57 ` Patrick Steinhardt [this message]
2023-12-08 22:58 ` Taylor Blau
2023-12-11 7:43 ` Patrick Steinhardt
2023-12-12 1:37 ` Jeff King
2023-12-07 7:25 ` [PATCH 4/9] config: use config_error_nonbool() instead of custom messages Jeff King
2023-12-07 7:25 ` [PATCH 5/9] diff: give more detailed messages for bogus diff.* config Jeff King
2023-12-07 7:26 ` [PATCH 6/9] config: use git_config_string() for core.checkRoundTripEncoding Jeff King
2023-12-07 7:26 ` [PATCH 7/9] push: drop confusing configset/callback redundancy Jeff King
2023-12-07 7:26 ` [PATCH 8/9] gpg-interface: drop pointless config_error_nonbool() checks Jeff King
2023-12-07 7:26 ` [PATCH 9/9] sequencer: simplify away extra git_config_string() call Jeff King
2023-12-07 8:58 ` [PATCH 0/9] bonus config cleanups Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXGJE-pkb3BjlO-d@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.