From: Bruce Richardson <bruce.richardson@intel.com>
To: <skori@marvell.com>
Cc: Rakesh Kudurumalla <rkudurumalla@marvell.com>, <dev@dpdk.org>
Subject: Re: [PATCH] app/graph: generate cmdline boilerplate
Date: Thu, 7 Dec 2023 10:29:26 +0000 [thread overview]
Message-ID: <ZXGehmWrMoY7bbIM@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20231207071205.3008880-1-skori@marvell.com>
On Thu, Dec 07, 2023 at 12:42:05PM +0530, skori@marvell.com wrote:
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
> structs and defines for the commandline part of the application.
>
> Depends-on: series-30459 ("enhancements for dpdk-cmdline-gen script")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> app/graph/cli.c | 27 ---
> app/graph/commands.list | 32 ++++
> app/graph/ethdev.c | 288 +++++-------------------------
> app/graph/ethdev.h | 9 -
> app/graph/ethdev_priv.h | 63 -------
> app/graph/ethdev_rx.c | 67 +------
> app/graph/ethdev_rx.h | 2 -
> app/graph/ethdev_rx_priv.h | 16 --
> app/graph/examples/l3fwd.cli | 12 +-
> app/graph/examples/l3fwd_pcap.cli | 12 +-
> app/graph/graph.c | 131 ++------------
> app/graph/graph.h | 5 -
> app/graph/graph_priv.h | 35 ----
> app/graph/ip4_route.c | 86 ++-------
> app/graph/ip6_route.c | 88 ++-------
> app/graph/mempool.c | 68 +------
> app/graph/mempool.h | 3 -
> app/graph/mempool_priv.h | 18 --
> app/graph/meson.build | 8 +
> app/graph/module_api.h | 1 +
> app/graph/neigh.c | 103 ++---------
> app/graph/neigh.h | 4 -
> app/graph/neigh_priv.h | 21 ---
> app/graph/route.h | 5 -
> app/graph/route_priv.h | 34 ----
> 25 files changed, 164 insertions(+), 974 deletions(-)
> create mode 100644 app/graph/commands.list
>
I really like the diff-stats of this patch! More than 800 lines fewer in our
codebase.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2023-12-07 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:12 [PATCH] app/graph: generate cmdline boilerplate skori
2023-12-07 10:29 ` Bruce Richardson [this message]
2023-12-12 17:05 ` [PATCH v2 1/1] " skori
2023-12-18 8:48 ` Nithin Dabilpuram
2024-03-06 21:52 ` Thomas Monjalon
2024-03-07 7:06 ` [EXTERNAL] " Sunil Kumar Kori
2024-03-07 9:41 ` Sunil Kumar Kori
2024-03-07 9:40 ` [PATCH v3 " skori
2024-03-07 15:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXGehmWrMoY7bbIM@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rkudurumalla@marvell.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.