From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30985C4167B for ; Thu, 7 Dec 2023 13:30:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 566527F4; Thu, 7 Dec 2023 14:30:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 566527F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701955851; bh=zwPMEj8AGYxUrl9j0Jq1ozkQShkFbNl7hWQyodjk+mQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=RRBlbZJo9iyba0FXuJmxFWRz0bVM1Gt5wbeB+TrjUSEaCymFDQzVe25EZL9L0+tnI 0LBPh7/1GB9U0Zxlr16cE9sIiSxO6OdxA+ord+7FLwiQVTG+GRbPw29VDJmUiMRfWL rInt8Fj7PlP2P3gsXywfuHB9x+2RzhNd5yr8Q0/4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 85C7FF80563; Thu, 7 Dec 2023 14:30:28 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A20D8F8057F; Thu, 7 Dec 2023 14:30:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF0A1F800D2; Thu, 7 Dec 2023 14:06:12 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 97FB9F800D2 for ; Thu, 7 Dec 2023 14:00:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 97FB9F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NwL1hqRr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701954049; x=1733490049; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zwPMEj8AGYxUrl9j0Jq1ozkQShkFbNl7hWQyodjk+mQ=; b=NwL1hqRrUHDlIUw4fvHqy9PndqyDAhkFZForOMf0Imvvg6k2Hmt7ZCWt RVKHMzxRB6VrKeuNcA6OOObNb0BrwhVoPAMWq0dANHK2SX+vqGMCz+605 VhjNzM6EiPceWMLW711VujeyEvZlty/0ROEZbaJ1ukw5zLgmWXlx8+pgx QWjDCmegyHMLsQVqIvzJTXSq4rdnT2r0eglIY5W16KRImgdvRMmRVR7EH L51YaRlwV9wAvPCVX6rmqH8AMsrcOJcgbeuBY9wnwjzGxUTKgVnHVFbsj YHLmXcyZrKQXyQjORqxmmklbkc4UB600Bk9d05olcvmp1/qwuCHjuAT1J Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="12938856" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="12938856" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 05:00:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1103191636" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="1103191636" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 05:00:22 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rBDzH-00000002bUI-1HzU; Thu, 07 Dec 2023 15:00:19 +0200 Date: Thu, 7 Dec 2023 15:00:19 +0200 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Pierre-Louis Bossart , Gergo Koteles , Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 2/2] ALSA: hda/tas2563: Add tas2563 HDA driver Message-ID: References: <4a2f31d4eb8479789ceb1daf2e93ec0e25c23171.1701733441.git.soyer@irl.hu> <90765ee0-a814-4852-9b2a-020cda98d930@linux.intel.com> <974d41f6c703d9b65ebcd75a2c659cecf13bd877.camel@irl.hu> <9c3846ae0da417c0fe5d4fa2d9d4134143184dda.camel@irl.hu> <830d8e26-dbb9-4b9c-bbab-a5c4c49a7ffd@linux.intel.com> <4cd78962-027c-4bbb-a42a-6ccbca81ac8e@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4cd78962-027c-4bbb-a42a-6ccbca81ac8e@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: 5FGOJGYASUZG4PAAEKTHBHBWDSYTTYTU X-Message-ID-Hash: 5FGOJGYASUZG4PAAEKTHBHBWDSYTTYTU X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Dec 06, 2023 at 05:07:16PM +0100, Amadeusz Sławiński wrote: > On 12/5/2023 6:22 PM, Pierre-Louis Bossart wrote: ... > > > > > > > + tas2xxx_generic_fixup(cdc, action, "i2c", "INT8866"); > > > > > > > > > > > > Any specific reason to use an Intel ACPI identifier? Why not use > > > > > > "TIAS2563" ? > > Will just note that prefix should probably be TXNW (not TIAS) as discussed > recently on list. ...which should come directly from TI as it's their responsibility to allocate an ACPI ID. ... > > > > > INT8866 is in the ACPI. > > > > > I don't know why Lenovo uses this name. > > > > > I think it's more internal than intel. This is wrong (PNP) ID. ... > > > > >             Name (_HID, "INT8866") // _HID: Hardware ID > > > > > > > > Ouch, I hope they checked with Intel that this isn't an HID already in > > > > use... > > > > > > > It looks the INT prefix is not reserved. (yet) > > > https://uefi.org/ACPI_ID_List?acpi_search=INT You are looking into wrong registry, and yeah, Intel used wrong PNP ID for years... > > It's been de-facto reclaimed by Intel over the years, apparently using > > INTC or INTL was too hard for some of my colleagues... > > Perhaps it should be reserved then, so it is present on above list? -- With Best Regards, Andy Shevchenko