All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
	linux-block@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 2/3] block: Rework bio_for_each_folio_all(), add bio_for_each_folio()
Date: Thu, 7 Dec 2023 13:45:45 -0700	[thread overview]
Message-ID: <ZXIu-Yj2tBd2895_@kbusch-mbp> (raw)
In-Reply-To: <20231122232818.178256-2-kent.overstreet@linux.dev>

On Wed, Nov 22, 2023 at 06:28:14PM -0500, Kent Overstreet wrote:
> +#define __bio_for_each_folio(bvl, bio, iter, start)			\
> +	for (iter = (start);						\
> +	     (iter).bi_size &&						\
> +		((bvl = bio_iter_iovec_folio((bio), (iter))), 1);	\
> +	     bio_advance_iter_single((bio), &(iter), (bvl).fv_len))

I know your just moving this macro, but perhaps now would be a good
opportunity to rename 'bvl' to 'fv' to match the callers and have a
different naming convention from the bio_vec macros.

  parent reply	other threads:[~2023-12-07 20:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 23:28 [PATCH 1/3] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-11-22 23:28 ` [PATCH 2/3] block: Rework bio_for_each_folio_all(), add bio_for_each_folio() Kent Overstreet
2023-12-07 19:02   ` Matthew Wilcox
2023-12-07 20:09   ` Matthew Wilcox
2023-12-07 20:45   ` Keith Busch [this message]
2023-12-07 22:11   ` Eric Biggers
2023-11-22 23:28 ` [PATCH 3/3] block: Add documentation for bio iterator macros Kent Overstreet
2023-12-07  9:21   ` Ming Lei
2023-12-06 21:34 ` [PATCH 1/3] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-12-06 22:40   ` Jens Axboe
2023-12-06 23:27     ` Kent Overstreet
2023-12-07 17:57       ` Jens Axboe
2023-12-07 18:06         ` Kent Overstreet
2023-12-07 18:26           ` Jens Axboe
2023-12-07 20:58     ` Matthew Wilcox
2023-12-07 21:01       ` Jens Axboe
2023-12-07 21:04         ` Jens Axboe
2023-12-07  9:20 ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXIu-Yj2tBd2895_@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.