From: Yury Norov <yury.norov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v2 0/6] lib/group_cpus: rework grp_spread_init_one() and make it O(1)
Date: Thu, 7 Dec 2023 14:19:43 -0800 [thread overview]
Message-ID: <ZXJE/1z5DR8lIBOK@yury-ThinkPad> (raw)
In-Reply-To: <20231207134619.52545aaf4e5f393618a92c41@linux-foundation.org>
On Thu, Dec 07, 2023 at 01:46:19PM -0800, Andrew Morton wrote:
> On Thu, 7 Dec 2023 12:38:54 -0800 Yury Norov <yury.norov@gmail.com> wrote:
>
> > grp_spread_init_one() implementation is sub-optimal because it
> > traverses bitmaps from the beginning, instead of picking from the
> > previous iteration.
> >
> > Fix it and use find_bit API where appropriate. While here, optimize
> > cpumasks allocation and drop unneeded cpumask_empty() call.
>
> Thanks. This isn't my playground, but I'll grab the patches to at
> least get them some testing. Review from those who have worked
> on this code would be appreciated.
Thanks you!
prev parent reply other threads:[~2023-12-07 22:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 20:38 [PATCH v2 0/6] lib/group_cpus: rework grp_spread_init_one() and make it O(1) Yury Norov
2023-12-07 20:38 ` [PATCH v2 1/6] cpumask: introduce for_each_cpu_and_from() Yury Norov
2023-12-07 21:41 ` Andrew Morton
2023-12-07 22:16 ` Yury Norov
2023-12-07 20:38 ` [PATCH v2 2/6] lib/group_cpus: relax atomicity requirement in grp_spread_init_one() Yury Norov
2023-12-08 1:31 ` Ming Lei
2023-12-08 2:49 ` Yury Norov
2023-12-08 3:28 ` Ming Lei
2023-12-07 20:38 ` [PATCH v2 3/6] lib/group_cpus: optimize inner loop " Yury Norov
2023-12-07 21:45 ` Andrew Morton
2023-12-07 22:07 ` Yury Norov
2023-12-07 20:38 ` [PATCH v2 4/6] lib/group_cpus: optimize outer " Yury Norov
2023-12-07 20:38 ` [PATCH 5/6] lib/cgroup_cpus.c: don't zero cpumasks in group_cpus_evenly() on allocation Yury Norov
2023-12-07 20:39 ` [PATCH 6/6] lib/group_cpus.c: drop unneeded cpumask_empty() call in __group_cpus_evenly() Yury Norov
2023-12-07 21:46 ` [PATCH v2 0/6] lib/group_cpus: rework grp_spread_init_one() and make it O(1) Andrew Morton
2023-12-07 22:19 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXJE/1z5DR8lIBOK@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.