From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EEB01094B; Fri, 8 Dec 2023 08:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tm2W3sFT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD8FEC433C7; Fri, 8 Dec 2023 08:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702023514; bh=85cnqYAPP8hKzPB4QuuMegY8qDFlijd/F4k4kPybf3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tm2W3sFTrdPwgFXfQ0kjCMqNCQivTotVWHI8wacQElTC6famiPCWqVVWsk7bln4vp tUL7BJzSCSqgK444YJtm50jydcW0s13t8tAhLD7DDXAQFjlBArujRsBSrzFlNjBcM4 5+ZCLAc3hCHUkVhC7KHLOh43Jc+k97r71e3aR+cF4P7oV3kRhd+Hq/+XLzx+49T9Cz vT5sJSQNI9qoVQSUlcD0ky8FqwYNpbFZ56uVbZ9k24humMK4PCDGc8/03fI3di/E8C N+mLtBN4kt/YNG/89mmkzzMhuBPMPUDei6bILv7l2gfKwvYuHn1l0O8a+R8y3rpjnZ 3+u4Vx4cimnZA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rBW4y-0001eK-11; Fri, 08 Dec 2023 09:19:24 +0100 Date: Fri, 8 Dec 2023 09:19:24 +0100 From: Johan Hovold To: Rob Clark Cc: iommu@lists.linux-foundation.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Konrad Dybcio , Dmitry Baryshkov , Bjorn Andersson , Elliot Berman , Richard Acayan , Manivannan Sadhasivam , "moderated list:ARM SMMU DRIVERS" , "open list:IOMMU SUBSYSTEM" , open list Subject: Re: [PATCH] iommu/arm-smmu-qcom: Add missing GMU entry to match table Message-ID: References: <20231207212441.6199-1-robdclark@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207212441.6199-1-robdclark@gmail.com> On Thu, Dec 07, 2023 at 01:24:39PM -0800, Rob Clark wrote: > From: Rob Clark > > We also want the default domain for the GMU to be an identy domain, > so it does not get a context bank assigned. Without this, both > of_dma_configure() and drm/msm's iommu_domain_attach() will trigger > allocating and configuring a context bank. So GMU ends up attached > to both cbndx 1 and cbndx 2. This arrangement seemingly confounds > and surprises the firmware if the GPU later triggers a translation > fault, resulting (on sc8280xp / lenovo x13s, at least) in the SMMU > getting wedged and the GPU stuck without memory access. This sounds like something that should be backported. Should you add a Fixes and CC-stable tag? > Signed-off-by: Rob Clark Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8BA4C4167B for ; Fri, 8 Dec 2023 08:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T2bDG+slyG94S0NLUILsxU+pWrF2QjPinb93TDhhVpw=; b=qCcMs+JS7PAXow g3alUkeCCNJcGHj5F/G0Kli0dHMZ7hqgDtV5AeWQSsRZmlYmi9gD0b9l3eJMFdoqRkEjekXlqjE9a eA2Nt0a59uniQGzQ8BgWxoUDjnLHJNTUG45vjeJ5LXjR5WVvRnlhC4khg3BzI1ofz6ZdW8Cckzywb Psg/iw3oaIs7HDkb8ZIRGWLTjTIA9fJcr2qtJsCBn3BCMbG1LMueR3XD3U522TE0/Mi9SaUFviUFH dwld8fGmpjCYRBPI96O2jjdiF4cfI9+YPpnTsRmfjDi8ykCTVLI02ynxrd/UcJkr+ph0T5s7+uWpI iTUMYkZEQyllcDCYW3YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBW4E-00F28R-0y; Fri, 08 Dec 2023 08:18:38 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBW4C-00F27H-02 for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 08:18:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 34A1961FA2; Fri, 8 Dec 2023 08:18:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD8FEC433C7; Fri, 8 Dec 2023 08:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702023514; bh=85cnqYAPP8hKzPB4QuuMegY8qDFlijd/F4k4kPybf3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tm2W3sFTrdPwgFXfQ0kjCMqNCQivTotVWHI8wacQElTC6famiPCWqVVWsk7bln4vp tUL7BJzSCSqgK444YJtm50jydcW0s13t8tAhLD7DDXAQFjlBArujRsBSrzFlNjBcM4 5+ZCLAc3hCHUkVhC7KHLOh43Jc+k97r71e3aR+cF4P7oV3kRhd+Hq/+XLzx+49T9Cz vT5sJSQNI9qoVQSUlcD0ky8FqwYNpbFZ56uVbZ9k24humMK4PCDGc8/03fI3di/E8C N+mLtBN4kt/YNG/89mmkzzMhuBPMPUDei6bILv7l2gfKwvYuHn1l0O8a+R8y3rpjnZ 3+u4Vx4cimnZA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rBW4y-0001eK-11; Fri, 08 Dec 2023 09:19:24 +0100 Date: Fri, 8 Dec 2023 09:19:24 +0100 From: Johan Hovold To: Rob Clark Cc: iommu@lists.linux-foundation.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Konrad Dybcio , Dmitry Baryshkov , Bjorn Andersson , Elliot Berman , Richard Acayan , Manivannan Sadhasivam , "moderated list:ARM SMMU DRIVERS" , "open list:IOMMU SUBSYSTEM" , open list Subject: Re: [PATCH] iommu/arm-smmu-qcom: Add missing GMU entry to match table Message-ID: References: <20231207212441.6199-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231207212441.6199-1-robdclark@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_001836_091380_A4BE39AE X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 07, 2023 at 01:24:39PM -0800, Rob Clark wrote: > From: Rob Clark > > We also want the default domain for the GMU to be an identy domain, > so it does not get a context bank assigned. Without this, both > of_dma_configure() and drm/msm's iommu_domain_attach() will trigger > allocating and configuring a context bank. So GMU ends up attached > to both cbndx 1 and cbndx 2. This arrangement seemingly confounds > and surprises the firmware if the GPU later triggers a translation > fault, resulting (on sc8280xp / lenovo x13s, at least) in the SMMU > getting wedged and the GPU stuck without memory access. This sounds like something that should be backported. Should you add a Fixes and CC-stable tag? > Signed-off-by: Rob Clark Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel