From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 2/2] gpiolib: use a mutex to protect the list of GPIO devices
Date: Fri, 8 Dec 2023 16:05:31 +0200 [thread overview]
Message-ID: <ZXMiq3wDOt9zFzuX@smile.fi.intel.com> (raw)
In-Reply-To: <20231208102020.36390-3-brgl@bgdev.pl>
On Fri, Dec 08, 2023 at 11:20:20AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The global list of GPIO devices is never modified or accessed from
> atomic context so it's fine to protect it using a mutex. Add a new
> global lock dedicated to the gpio_devices list and use it whenever
> accessing or modifying it.
...
> While at it: fold the sysfs registering of existing devices into
> gpiolib.c and make gpio_devices static within its compilation unit.
TBH I do not like injecting sysfs (legacy!) code into gpiolib.
It makes things at very least confusing.
That _ugly_ ifdeffery and sysfs in the function name are not okay.
If you want do that, please create a separate change and explain the rationale
behind with answering to the Q "Why do we need all that and why is it better
than any alternatives?".
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-14 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 10:20 [PATCH v2 0/2] gpiolib: protect the list of GPIO devices with a mutex Bartosz Golaszewski
2023-12-08 10:20 ` [PATCH v2 1/2] gpiolib: rename static functions that are called with the lock taken Bartosz Golaszewski
2023-12-08 14:06 ` Andy Shevchenko
2023-12-08 10:20 ` [PATCH v2 2/2] gpiolib: use a mutex to protect the list of GPIO devices Bartosz Golaszewski
2023-12-08 14:05 ` Andy Shevchenko [this message]
2023-12-14 13:59 ` Bartosz Golaszewski
2023-12-14 14:04 ` Andy Shevchenko
2023-12-14 14:18 ` Bartosz Golaszewski
2023-12-14 12:26 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXMiq3wDOt9zFzuX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.